Re: [PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2

[Javier Martinez Canillas <javierm@redhat.com>]

Chukun Pan <amadeus@jmu.edu.cn> writes:

> Hi,
>
>> +&sdhci0 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&mmc1_cfg>;
>
> It would be better to arrange them in alphabetical order.
> (Place pinctrl below no-sdio)
>
>> +	bus-width = <4>;
>> +	cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>;
>
> It seems that "cap-sd-highspeed" is missing?
>
>> +	cd-inverted;
>> +	no-sdio;
>> +	status = "okay";
>> +};
>
>> +			sdhci0: mmc@d4280000 {
>
> An immature idea. Would naming nodes this way be better?
>
> sdmmc: mmc@d4280000
>  sdio: mmc@d4280800
>  emmc: mmc@d4281000
>
> This seems to fit the description here better:
> https://bianbu-linux.spacemit.com/en/device/peripheral_driver/SDHC/#dts-configuration
>

I initially thought something similar but it's not accurate. Because as
explained in the doc that you referred:

* slot1 supports SD/SDIO (1/4 bit)
* slot2 supports SDIO/eMMC (1/4 bit)
* slot3 supports only eMMC (1/4/8 bit)

Which means that only slot3 is limited to eMMC.

So even when a typical configuration is what you mentioned (and what I saw
in most of the existing designs), slots 1 and 2 won't always be SD and SDIO.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv