Re: [PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Yao Zi <me@ziyao.cc>
Cc: michael.opdenacker@rootcommit.com,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	Yixun Lan <dlan@gentoo.org>
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2
Date: Mon, 15 Dec 2025 13:58:41 +0000 (UTC)	[thread overview]
Message-ID: <bf815359-4b6e-4243-8a7a-6b00e259f4f6@rootcommit.com> (raw)
In-Reply-To: <aUADG5c8r0GEN6iP@pie>

Hi Yao

Thanks a lot for the review!

On 12/15/25 13:46, Yao Zi wrote:
> On Mon, Dec 15, 2025 at 10:10:14AM +0000, Michael Opdenacker wrote:
>> This introduces a new sdhci0 node and enables it
>> for the BananaPI F3 and OrangePi RV2 boards.
>>
>> Note that card detect is marked as broken in the driver
>> (SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk), therefore removing the card
>> while the system is running won't have any effect.
> This description looks suspicious: SDHCI_QUIRK_BROKEN_CARD_DETECTION
> doesn't break hotplug. It only informs sdhci core to actively poll for
> card status, instead of relying on interrupts for status change.

I must have misinterpreted the code.  I modified the description to just 
mention
that card detection currently doesn't work with these changes.

>
> ...
>
>> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
>> index 7818ca4979b6..a5b7d7c8c066 100644
>> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
>> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
>> @@ -987,6 +987,16 @@ emmc: mmc@d4281000 {
>>   				interrupts = <101>;
>>   				status = "disabled";
>>   			};
>> +
>> +			sdhci0: mmc@d4280000 {
>> +				compatible = "spacemit,k1-sdhci";
>> +				reg = <0x0 0xd4280000 0x0 0x200>;
>> +				clocks = <&syscon_apmu CLK_SDH_AXI>,
>> +					 <&syscon_apmu CLK_SDH0>;
>> +				clock-names = "core", "io";
>> +				interrupts = <99>;
>> +				status = "disabled";
>> +			};
> This node should be probably put before the emmc node, since it comes
> with lower address.

Oops, correct in my branch. Thanks!
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv