Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Alok Kataria]

On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> passed unsigned int. Unsigned int is more proper type for IRQ number
> so let's use it. This shuts off a compile warning with recent
> compilers.
> 
> Signed-off-by: Dmitry Torokhov <dtor@vmware.com>

LGTM.

Signed-off-by: Alok N Kataria <akataria@vmware.com>

Thanks.
> ---
>  drivers/scsi/vmw_pvscsi.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index d2604c8..e4ac582 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -1069,7 +1069,8 @@ static void pvscsi_free_sgls(const struct pvscsi_adapter *adapter)
>  		free_pages((unsigned long)ctx->sgl, get_order(SGL_SIZE));
>  }
>  
> -static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter, int *irq)
> +static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter,
> +			     unsigned int *irq)
>  {
>  	struct msix_entry entry = { 0, PVSCSI_VECTOR_COMPLETION };
>  	int ret;
> 
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[James Bottomley]

On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > passed unsigned int. Unsigned int is more proper type for IRQ number
> > so let's use it. This shuts off a compile warning with recent
> > compilers.
> > 
> > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> 
> LGTM.
> 
> Signed-off-by: Alok N Kataria <akataria@vmware.com>

That would be acked-by unless you want to resend the patch to me?  I
don't have an unmangled copy of it, so someone needs to send it to the
scsi list.

Thanks,

James

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Alok Kataria]

On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > > passed unsigned int. Unsigned int is more proper type for IRQ number
> > > so let's use it. This shuts off a compile warning with recent
> > > compilers.
> > > 
> > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > 
> > LGTM.
> > 
> > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> 
> That would be acked-by unless you want to resend the patch to me?  I
> don't have an unmangled copy of it, so someone needs to send it to the
> scsi list.
> 
Acked-by is fine with me too. If its an hassle to pick these lines after
the patch is sent, I am totally fine if you pick the patch without my
Acked-by or SOB line, just wanted to acknowledge that the change is fine
by me. 

Thanks,
Alok

> Thanks,
> 
> James
> 
> 

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Dmitry Torokhov]

On Tuesday 19 January 2010 10:19:04 am Alok Kataria wrote:
> On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > > > passed unsigned int. Unsigned int is more proper type for IRQ number
> > > > so let's use it. This shuts off a compile warning with recent
> > > > compilers.
> > > >
> > > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > >
> > > LGTM.
> > >
> > > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> >
> > That would be acked-by unless you want to resend the patch to me?  I
> > don't have an unmangled copy of it, so someone needs to send it to the
> > scsi list.
> 
> Acked-by is fine with me too. If its an hassle to pick these lines after
> the patch is sent, I am totally fine if you pick the patch without my
> Acked-by or SOB line, just wanted to acknowledge that the change is fine
> by me.
> 

Hm, I wonder why the original did not make through to linux-scsi/James.
I will resend from my other address then.

-- 
Dmitry

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[James Bottomley]

On Tue, 2010-01-19 at 10:20 -0800, Dmitry Torokhov wrote:
> On Tuesday 19 January 2010 10:19:04 am Alok Kataria wrote:
> > On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > > > > passed unsigned int. Unsigned int is more proper type for IRQ number
> > > > > so let's use it. This shuts off a compile warning with recent
> > > > > compilers.
> > > > >
> > > > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > > >
> > > > LGTM.
> > > >
> > > > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> > >
> > > That would be acked-by unless you want to resend the patch to me?  I
> > > don't have an unmangled copy of it, so someone needs to send it to the
> > > scsi list.
> > 
> > Acked-by is fine with me too. If its an hassle to pick these lines after
> > the patch is sent, I am totally fine if you pick the patch without my
> > Acked-by or SOB line, just wanted to acknowledge that the change is fine
> > by me.
> > 
> 
> Hm, I wonder why the original did not make through to linux-scsi/James.
> I will resend from my other address then.

Well, sometimes it's because someone is using a mail tool that breaks
threading ... but I did a subject search, it definitely isn't in my
folder.  Vger has a fairly esoteric spam reduction mechanism based on
regexps ... perhaps you fell foul of that?

James

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Dmitry Torokhov]

On Tuesday 19 January 2010 10:23:43 am James Bottomley wrote:
> On Tue, 2010-01-19 at 10:20 -0800, Dmitry Torokhov wrote:
> > On Tuesday 19 January 2010 10:19:04 am Alok Kataria wrote:
> > > On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > > > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is
> > > > > > being passed unsigned int. Unsigned int is more proper type for
> > > > > > IRQ number so let's use it. This shuts off a compile warning with
> > > > > > recent compilers.
> > > > > >
> > > > > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > > > >
> > > > > LGTM.
> > > > >
> > > > > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> > > >
> > > > That would be acked-by unless you want to resend the patch to me?  I
> > > > don't have an unmangled copy of it, so someone needs to send it to
> > > > the scsi list.
> > >
> > > Acked-by is fine with me too. If its an hassle to pick these lines
> > > after the patch is sent, I am totally fine if you pick the patch
> > > without my Acked-by or SOB line, just wanted to acknowledge that the
> > > change is fine by me.
> >
> > Hm, I wonder why the original did not make through to linux-scsi/James.
> > I will resend from my other address then.
> 
> Well, sometimes it's because someone is using a mail tool that breaks
> threading ... but I did a subject search, it definitely isn't in my
> folder.  Vger has a fairly esoteric spam reduction mechanism based on
> regexps ... perhaps you fell foul of that?

Mutt usually does not fail me when sending patches. Let's see if my other 
account works better.

-- 
Dmitry

Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[James Bottomley]

On Tue, 2010-01-19 at 10:19 -0800, Alok Kataria wrote:
> On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > > > passed unsigned int. Unsigned int is more proper type for IRQ number
> > > > so let's use it. This shuts off a compile warning with recent
> > > > compilers.
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > > 
> > > LGTM.
> > > 
> > > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> > 
> > That would be acked-by unless you want to resend the patch to me?  I
> > don't have an unmangled copy of it, so someone needs to send it to the
> > scsi list.
> > 
> Acked-by is fine with me too. If its an hassle to pick these lines after
> the patch is sent, I am totally fine if you pick the patch without my
> Acked-by or SOB line, just wanted to acknowledge that the change is fine
> by me. 

The difference is Acked-by means you looked at the patch and said it was
OK.  This is fairly essential if you want the change to go into the SCSI
tree because otherwise it goes in my pile to look at ordered by
importance (and changes like this tend to land close to the bottom).

If you want to send it to me yourself, you resend it with a
signed-off-by tag (this tracks whose hands the change passed through).

James