From: Hasun Park <hasunpark@gmail.com>
To: vijendar.mukunda@amd.com
Cc: Richard.Gong@amd.com, Sunil-kumar.Dommati@amd.com,
broonie@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
mario.limonciello@amd.com, perex@perex.cz, tiwai@suse.com,
venkataprasad.potturu@amd.com, Hasun Park <hasunpark@gmail.com>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine
Date: Tue, 17 Mar 2026 00:46:06 +0900 [thread overview]
Message-ID: <20260316154606.24110-1-hasunpark@gmail.com> (raw)
In-Reply-To: <a7e7e79d-c839-4a76-8a2a-f3422d2cc089@amd.com>
>On 11/03/26 23:02, Mukunda,Vijendar wrote:
>> On 11/03/26 22:51, Mark Brown wrote:
>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>>>> From: Hasun Park <hasunpark@gmail.com>
>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>>>> machine driver.
>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>>>> platform-specific jack/DMIC quirk path is selected.
>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>>> Presumably nothing stops the system integrator wiring a DMIC directly to
>>> the SoC even if the CODEC can also use it? It doesn't seem an obviously
>>> silly configuration.
>> On this platform Soundwire Codec RT721 already comes up with DMIC
>> endpoint. As per our understanding current soundwire topology points to
>> use RT721 + TI codecs. ACP DMIC is not being used.
>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and
>> routed to ACP PDM controller instead of Soundwire Codec (Which supports
>> DMIC path), then ACP_PDM_DMIC quirk should be enabled.
>
>We have cross-checked hw configuration. This platform uses DMIC connected
>to Soundwire codec(ALC721). This patch should be dropped.
Thanks for double-checking the hw configs.
I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP.
But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC.
next prev parent reply other threads:[~2026-03-16 15:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 15:16 [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks hasunpark
2026-03-08 15:16 ` [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag hasunpark
2026-03-09 5:33 ` Mukunda,Vijendar
2026-03-09 11:34 ` Mark Brown
2026-03-09 15:31 ` Mario Limonciello
2026-03-09 15:48 ` Mark Brown
2026-03-08 15:16 ` [PATCH 2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2 hasunpark
2026-03-08 15:16 ` [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine hasunpark
2026-03-09 5:37 ` Mukunda,Vijendar
2026-03-11 17:21 ` Mark Brown
2026-03-11 17:32 ` Mukunda,Vijendar
2026-03-12 6:49 ` Mukunda,Vijendar
2026-03-12 13:06 ` Mark Brown
2026-03-15 20:20 ` Eric Naim
2026-03-15 23:53 ` Mark Brown
2026-03-16 2:30 ` Mario Limonciello
2026-03-16 3:50 ` Eric Naim
2026-03-16 15:46 ` Hasun Park [this message]
2026-03-17 4:00 ` Mukunda,Vijendar
2026-03-17 17:04 ` Mukunda,Vijendar
2026-03-17 17:22 ` Hasun Park
2026-03-19 16:33 ` [PATCH v2] " Hasun Park
2026-03-19 16:35 ` Mark Brown
2026-03-20 12:53 ` Mark Brown
2026-03-16 0:14 ` (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks Mark Brown
2026-03-16 16:47 ` Hasun Park
2026-03-16 17:45 ` Mark Brown
2026-03-16 17:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316154606.24110-1-hasunpark@gmail.com \
--to=hasunpark@gmail.com \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox