Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: hasunpark@gmail.com, linux-sound@vger.kernel.org
Cc: venkataprasad.potturu@amd.com, lgirdwood@gmail.com,
	broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	linux-kernel@vger.kernel.org,
	mario Limonciello <mario.limonciello@amd.com>,
	"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
	"Gong, Richard" <Richard.Gong@amd.com>
Subject: Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag
Date: Mon, 9 Mar 2026 11:03:21 +0530	[thread overview]
Message-ID: <55265fbb-490b-4af9-aee5-1af1960c2b51@amd.com> (raw)
In-Reply-To: <20260308151654.29059-2-hasunpark@gmail.com>

On 08/03/26 20:46, hasunpark@gmail.com wrote:
> [You don't often get email from hasunpark@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Hasun Park <hasunpark@gmail.com>
>
> Some ASUS ProArt PX13 systems expose ACP ACPI config flags that can
> select a non-working fallback path.
>
> Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
> return 0 so ACP ACPI flag-based selection is skipped on this platform.
>
> This keeps machine driver selection on the intended SoundWire path.

This patch should be dropped.
To avoid overgrowing DMI quirks table, we have introduced "acp-audio-config-flag"
which should be updated based on platform hw configuration and required driver
solution to be loaded.

ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.

>
> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---
>  sound/soc/amd/acp-config.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
> index 365209ea53f3..1604ed679224 100644
> --- a/sound/soc/amd/acp-config.c
> +++ b/sound/soc/amd/acp-config.c
> @@ -23,6 +23,16 @@
>
>  static int acp_quirk_data;
>
> +static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
> +               },
> +       },
> +       {}
> +};
> +
>  static const struct config_entry config_table[] = {
>         {
>                 .flags = FLAG_AMD_SOF,
> @@ -186,8 +196,11 @@ int snd_amd_acp_find_config(struct pci_dev *pci)
>          */
>         if (!pci->revision)
>                 return 0;
> -       else if (pci->revision >= ACP_7_0_REV)
> +       else if (pci->revision >= ACP_7_0_REV) {
> +               if (dmi_check_system(acp70_acpi_flag_override_table))
> +                       return 0;
>                 return snd_amd_acp_acpi_find_config(pci);
> +       }
>
>         for (i = 0; i < ARRAY_SIZE(config_table); i++, table++) {
>                 if (table->device != device)
> --
> 2.53.0
>


  reply	other threads:[~2026-03-09  5:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 15:16 [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks hasunpark
2026-03-08 15:16 ` [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag hasunpark
2026-03-09  5:33   ` Mukunda,Vijendar [this message]
2026-03-09 11:34     ` Mark Brown
2026-03-09 15:31       ` Mario Limonciello
2026-03-09 15:48         ` Mark Brown
2026-03-08 15:16 ` [PATCH 2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2 hasunpark
2026-03-08 15:16 ` [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine hasunpark
2026-03-09  5:37   ` Mukunda,Vijendar
2026-03-11 17:21     ` Mark Brown
2026-03-11 17:32       ` Mukunda,Vijendar
2026-03-12  6:49         ` Mukunda,Vijendar
2026-03-12 13:06           ` Mark Brown
2026-03-15 20:20             ` Eric Naim
2026-03-15 23:53               ` Mark Brown
2026-03-16  2:30                 ` Mario Limonciello
2026-03-16  3:50                   ` Eric Naim
2026-03-16 15:46           ` Hasun Park
2026-03-17  4:00             ` Mukunda,Vijendar
2026-03-17 17:04               ` Mukunda,Vijendar
2026-03-17 17:22                 ` Hasun Park
2026-03-19 16:33   ` [PATCH v2] " Hasun Park
2026-03-19 16:35     ` Mark Brown
2026-03-20 12:53     ` Mark Brown
2026-03-16  0:14 ` (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks Mark Brown
2026-03-16 16:47   ` Hasun Park
2026-03-16 17:45     ` Mark Brown
2026-03-16 17:52 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55265fbb-490b-4af9-aee5-1af1960c2b51@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Richard.Gong@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=broonie@kernel.org \
    --cc=hasunpark@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox