From: Mark Brown <broonie@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>,
hasunpark@gmail.com, linux-sound@vger.kernel.org,
venkataprasad.potturu@amd.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org,
"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
"Gong, Richard" <Richard.Gong@amd.com>
Subject: Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag
Date: Mon, 9 Mar 2026 15:48:49 +0000 [thread overview]
Message-ID: <5fcdbec7-697c-41ae-9d3d-8e6007225d27@sirena.org.uk> (raw)
In-Reply-To: <cee01998-e94a-4f73-bcc8-2e71513166af@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
On Mon, Mar 09, 2026 at 10:31:00AM -0500, Mario Limonciello wrote:
> On 3/9/2026 6:34 AM, Mark Brown wrote:
> > On Mon, Mar 09, 2026 at 11:03:21AM +0530, Mukunda,Vijendar wrote:
> > > ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.
> > This is a good thing to have going forward but I don't think we can
> > require that people get or apply firmware updates for existing systems,
> > there's no guarantee that vendors will make them and the process of
> > getting and applying the update may not be trivial, particularly for
> > people running Linux on a system the vendor shipped with Windows.
> At least for pre-production hardware we should not accept quirks like this.
> Vendors should populate their BIOS properly.
Yeah, for preproduction that's definitely reasonable in the normal
course of affairs.
> But I gather this is a production hardware and the vendor made a mistake.
> In this case I guess the vendor doesn't make Linux BIOS update easy either,
> and thus the reporter suffers.
> So maybe we should let this one go, but let's look through these closely if
> more come.
> We really don't want to end up with a giant quirk table of BIOS mistakes.
I mean, that's idiomatic for ACPI :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-09 15:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 15:16 [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks hasunpark
2026-03-08 15:16 ` [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag hasunpark
2026-03-09 5:33 ` Mukunda,Vijendar
2026-03-09 11:34 ` Mark Brown
2026-03-09 15:31 ` Mario Limonciello
2026-03-09 15:48 ` Mark Brown [this message]
2026-03-08 15:16 ` [PATCH 2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2 hasunpark
2026-03-08 15:16 ` [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine hasunpark
2026-03-09 5:37 ` Mukunda,Vijendar
2026-03-11 17:21 ` Mark Brown
2026-03-11 17:32 ` Mukunda,Vijendar
2026-03-12 6:49 ` Mukunda,Vijendar
2026-03-12 13:06 ` Mark Brown
2026-03-15 20:20 ` Eric Naim
2026-03-15 23:53 ` Mark Brown
2026-03-16 2:30 ` Mario Limonciello
2026-03-16 3:50 ` Eric Naim
2026-03-16 15:46 ` Hasun Park
2026-03-17 4:00 ` Mukunda,Vijendar
2026-03-17 17:04 ` Mukunda,Vijendar
2026-03-17 17:22 ` Hasun Park
2026-03-19 16:33 ` [PATCH v2] " Hasun Park
2026-03-19 16:35 ` Mark Brown
2026-03-20 12:53 ` Mark Brown
2026-03-16 0:14 ` (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks Mark Brown
2026-03-16 16:47 ` Hasun Park
2026-03-16 17:45 ` Mark Brown
2026-03-16 17:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fcdbec7-697c-41ae-9d3d-8e6007225d27@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Richard.Gong@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=hasunpark@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox