Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[Mario Limonciello <mario.limonciello@amd.com>]

On 3/9/2026 6:34 AM, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 11:03:21AM +0530, Mukunda,Vijendar wrote:
>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
> 
>>> Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
>>> return 0 so ACP ACPI flag-based selection is skipped on this platform.
> 
>> This patch should be dropped.
>> To avoid overgrowing DMI quirks table, we have introduced "acp-audio-config-flag"
>> which should be updated based on platform hw configuration and required driver
>> solution to be loaded.
> 
>> ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.
> 
> This is a good thing to have going forward but I don't think we can
> require that people get or apply firmware updates for existing systems,
> there's no guarantee that vendors will make them and the process of
> getting and applying the update may not be trivial, particularly for
> people running Linux on a system the vendor shipped with Windows.

At least for pre-production hardware we should not accept quirks like 
this.  Vendors should populate their BIOS properly.

But I gather this is a production hardware and the vendor made a 
mistake.  In this case I guess the vendor doesn't make Linux BIOS update 
easy either, and thus the reporter suffers.

So maybe we should let this one go, but let's look through these closely 
if more come.

We really don't want to end up with a giant quirk table of BIOS mistakes.