Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: hasunpark@gmail.com, linux-sound@vger.kernel.org
Cc: venkataprasad.potturu@amd.com, lgirdwood@gmail.com,
	broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	linux-kernel@vger.kernel.org,
	Mario Limonciello <mario.limonciello@amd.com>,
	"Gong, Richard" <Richard.Gong@amd.com>,
	"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine
Date: Mon, 9 Mar 2026 11:07:30 +0530	[thread overview]
Message-ID: <53a03615-7a5c-4f1d-88f7-1e6554092946@amd.com> (raw)
In-Reply-To: <20260308151654.29059-4-hasunpark@gmail.com>

On 08/03/26 20:46, hasunpark@gmail.com wrote:
> [You don't often get email from hasunpark@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Hasun Park <hasunpark@gmail.com>
>
> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
> machine driver.
>
> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
> platform-specific jack/DMIC quirk path is selected.

As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>
> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---
>  sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> index c30ccf23005a..d22b71e3fd2d 100644
> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> @@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
>                 },
>                 .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>         },
> +       {
> +               .callback = soc_sdw_quirk_cb,
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
> +               },
> +               .driver_data = (void *)(RT711_JD1 | ASOC_SDW_ACP_DMIC),
> +       },
>         {}
>  };
>
> --
> 2.53.0
>


  reply	other threads:[~2026-03-09  5:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 15:16 [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks hasunpark
2026-03-08 15:16 ` [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag hasunpark
2026-03-09  5:33   ` Mukunda,Vijendar
2026-03-09 11:34     ` Mark Brown
2026-03-09 15:31       ` Mario Limonciello
2026-03-09 15:48         ` Mark Brown
2026-03-08 15:16 ` [PATCH 2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2 hasunpark
2026-03-08 15:16 ` [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine hasunpark
2026-03-09  5:37   ` Mukunda,Vijendar [this message]
2026-03-11 17:21     ` Mark Brown
2026-03-11 17:32       ` Mukunda,Vijendar
2026-03-12  6:49         ` Mukunda,Vijendar
2026-03-12 13:06           ` Mark Brown
2026-03-15 20:20             ` Eric Naim
2026-03-15 23:53               ` Mark Brown
2026-03-16  2:30                 ` Mario Limonciello
2026-03-16  3:50                   ` Eric Naim
2026-03-16 15:46           ` Hasun Park
2026-03-17  4:00             ` Mukunda,Vijendar
2026-03-17 17:04               ` Mukunda,Vijendar
2026-03-17 17:22                 ` Hasun Park
2026-03-19 16:33   ` [PATCH v2] " Hasun Park
2026-03-19 16:35     ` Mark Brown
2026-03-20 12:53     ` Mark Brown
2026-03-16  0:14 ` (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks Mark Brown
2026-03-16 16:47   ` Hasun Park
2026-03-16 17:45     ` Mark Brown
2026-03-16 17:52 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53a03615-7a5c-4f1d-88f7-1e6554092946@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Richard.Gong@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=broonie@kernel.org \
    --cc=hasunpark@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox