Re: [PATCH v2 00/20] sunxi: Add Allwinner A523 support

[Yixun Lan <dlan@gentoo.org>]

Hi Andre,

On 00:54 Fri 18 Jul     , Andre Przywara wrote:
> Hi,
> 
> (Mikhail and Jernej: please reply with S-o-b: lines for your patches!)
> 
> this series introduces support for the Allwinner A523 SoC family.
> Compared to v1, a good chunk of those patches have been merged, so we are
> down from 34 to 20 patches now. There are some small fixes to the
> pinctrl driver, and the SPL clock bits got updated to fix the conflicts
> with the now merged A133 support. I rewrote the SPL watchdog code, to
> avoid the MMIO register C struct. The DRAM driver lost one MMIO register
> struct. The DT files have now landed in the DT rebasing repo, so we can
> cherry-pick them from there.
> 
> Otherwise this now based on latest U-Boot master, which hopefully makes
> testing easier. If people don't shout, I would like to merge it still
> during this merge window, since the patches have been around for a while,
> and people want to use them, alongside the now supported mainline Linux
> code. So please test and review!
> 
> ==================================
> This series introduces support for the Allwinner A523 SoC family. The
> same die is used in different packages: the A523, A527, T527, and H728:
> they connect a different set of peripherals to the pins, or enable extra
> goodies like an NPU. From a U-Boot perspective those chips do not differ
> much, all the differences are described in the board DT files.
> 
> To be able to share the SPL clock code, the existing H6 code gets
> refactored in patches 01-04. This unifies the (CPU) PLL handling across
> the SoCs supported by this code (H6, H616, A133), and adds support for
> the separate CPU PLLs on the A523.
> 
> Patches 05-10 extend the existing Allwinner U-Boot drivers to cope with
> some of the changed peripherals, this includes the mandatory clock and
> pinctrl drivers, but also some clock tweaks for the MMC controller
> driver, and support for the new-ish AXP323 PMIC used on most boards.
> 
> Patches 11 updates some SPL bits to be able to cope with the A523.
> Patches 12-15 add the new SPL bits for the A523, most prominently the DRAM
> initialisation code. Many thanks to Jernej and Mikhail for providing
> this part, there is a great reverse engineering and testing effort behind
> this.
> 
> Patches 16-19 cherry-pick the DT files from the DT rebasing repo. There
> are more fix patches queued, I will update them once they hit the repo.
> 
> The final patch adds defconfig files for the three boards that seem to be
> the most popular at the moment, they include two development boards and
> one TV box. The most interesting bits in there are the DRAM parameters.
> 
> Please have a look, review, and test.
> 
for the series, I've only got one clk warning, but otherwise works for me..

Tested-by: Yixun Lan <dlan@gentoo.org> # Radxa A5E

-- 
Yixun Lan (dlan)