Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean

[Arend van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

On 2/8/2024 9:51 AM, Alexey Berezhok wrote:
> In 'brcmf_cfg80211_start_ap()', not assume that
> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
> an explicit check instead. Compile tested only.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Thanks, Alexey

Makes sense, but ....

> Signed-off-by: Alexey Berezhok <a@bayrepo.ru>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 736b2ada6..63f6e9436 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5272,7 +5272,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
>   					      settings->hidden_ssid);

settings->hidden_ssid has already been used above in following call:

		err = brcmf_fil_iovar_int_set(ifp, "closednet",
					      settings->hidden_ssid);

So we pass the value as is to firmware using the same assumption, ie. 
NL80211_HIDDEN_SSID_NOT_IN_USE. Is this not ABI thus very unlikely to 
change?

@Johannes:
Actually not quite understanding the reason for having this setting in 
nl80211. hidden_ssid means SSID element length is zero, right?

Regards,
Arend

>   		if (err) {
>   			bphy_err(drvr, "%s closednet error (%d)\n",
> -				 settings->hidden_ssid ?
> +				 (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
>   				 "enabled" : "disabled",
>   				 err);
>   			goto exit;

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]