From: andy.shevchenko@gmail.com
To: Alexey Berezhok <a@bayrepo.ru>
Cc: Arend van Spriel <aspriel@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean
Date: Mon, 19 Feb 2024 20:25:05 +0200 [thread overview]
Message-ID: <ZdOdARuxnN5B0zdS@surfacebook.localdomain> (raw)
In-Reply-To: <20240208085121.2430-1-a@bayrepo.ru>
Thu, Feb 08, 2024 at 11:51:21AM +0300, Alexey Berezhok kirjoitti:
...
> - settings->hidden_ssid ?
> + (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
> "enabled" : "disabled",
Can somebody switch this to use str_enabled_disabled() from string_choices.h?
Ideally, add str_disabled_enabled() in that header (as macro with negation on
its argument) and use here as
str_disabled_enabled(settings->hidden_ssid == NL80211_HIDDEN_SSID_NOT_IN_USE)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-19 18:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 8:51 [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean Alexey Berezhok
2024-02-08 14:06 ` Arend van Spriel
2024-02-08 14:15 ` Johannes Berg
2024-02-08 15:56 ` Arend Van Spriel
2024-02-12 15:38 ` Kalle Valo
2024-02-12 16:00 ` Arend van Spriel
2024-02-12 16:03 ` Kalle Valo
2024-02-12 16:43 ` Arend Van Spriel
2024-02-13 13:34 ` Kalle Valo
2024-02-13 14:01 ` Arend van Spriel
2024-02-13 15:46 ` Kalle Valo
2024-02-13 17:40 ` Arend Van Spriel
2024-02-14 10:28 ` Alexey Berezhok
2024-02-14 11:44 ` Arend Van Spriel
2024-02-19 18:25 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdOdARuxnN5B0zdS@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=a@bayrepo.ru \
--cc=aspriel@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox