From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Alexey Berezhok <a@bayrepo.ru>,
Arend van Spriel <aspriel@gmail.com>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean
Date: Thu, 08 Feb 2024 15:15:22 +0100 [thread overview]
Message-ID: <4e3b72023f30d8765154805816e6eb1f4e73593c.camel@sipsolutions.net> (raw)
In-Reply-To: <1bc49c2a-1f62-4801-90c3-048b27f6475c@broadcom.com>
On Thu, 2024-02-08 at 15:06 +0100, Arend van Spriel wrote:
>
> settings->hidden_ssid has already been used above in following call:
>
> err = brcmf_fil_iovar_int_set(ifp, "closednet",
> settings->hidden_ssid);
>
> So we pass the value as is to firmware using the same assumption, ie.
> NL80211_HIDDEN_SSID_NOT_IN_USE. Is this not ABI thus very unlikely to
> change?
The ABI won't change, that'd break all the users of nl80211 that use
this :-)
> @Johannes:
> Actually not quite understanding the reason for having this setting in
> nl80211. hidden_ssid means SSID element length is zero, right?
>
Well, there at least _were_ APs doing the correct SSID length but
setting all octets to zero ... Not sure that's still a thing though.
johannes
next prev parent reply other threads:[~2024-02-08 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 8:51 [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean Alexey Berezhok
2024-02-08 14:06 ` Arend van Spriel
2024-02-08 14:15 ` Johannes Berg [this message]
2024-02-08 15:56 ` Arend Van Spriel
2024-02-12 15:38 ` Kalle Valo
2024-02-12 16:00 ` Arend van Spriel
2024-02-12 16:03 ` Kalle Valo
2024-02-12 16:43 ` Arend Van Spriel
2024-02-13 13:34 ` Kalle Valo
2024-02-13 14:01 ` Arend van Spriel
2024-02-13 15:46 ` Kalle Valo
2024-02-13 17:40 ` Arend Van Spriel
2024-02-14 10:28 ` Alexey Berezhok
2024-02-14 11:44 ` Arend Van Spriel
2024-02-19 18:25 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3b72023f30d8765154805816e6eb1f4e73593c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=a@bayrepo.ru \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox