From: Alexey Berezhok <a@bayrepo.ru>
To: Arend van Spriel <aspriel@gmail.com>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
Alexey Berezhok <a@bayrepo.ru>
Subject: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean
Date: Thu, 8 Feb 2024 11:51:21 +0300 [thread overview]
Message-ID: <20240208085121.2430-1-a@bayrepo.ru> (raw)
In 'brcmf_cfg80211_start_ap()', not assume that
NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
an explicit check instead. Compile tested only.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexey Berezhok <a@bayrepo.ru>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 736b2ada6..63f6e9436 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5272,7 +5272,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
settings->hidden_ssid);
if (err) {
bphy_err(drvr, "%s closednet error (%d)\n",
- settings->hidden_ssid ?
+ (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
"enabled" : "disabled",
err);
goto exit;
--
2.39.3
next reply other threads:[~2024-02-08 8:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 8:51 Alexey Berezhok [this message]
2024-02-08 14:06 ` [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean Arend van Spriel
2024-02-08 14:15 ` Johannes Berg
2024-02-08 15:56 ` Arend Van Spriel
2024-02-12 15:38 ` Kalle Valo
2024-02-12 16:00 ` Arend van Spriel
2024-02-12 16:03 ` Kalle Valo
2024-02-12 16:43 ` Arend Van Spriel
2024-02-13 13:34 ` Kalle Valo
2024-02-13 14:01 ` Arend van Spriel
2024-02-13 15:46 ` Kalle Valo
2024-02-13 17:40 ` Arend Van Spriel
2024-02-14 10:28 ` Alexey Berezhok
2024-02-14 11:44 ` Arend Van Spriel
2024-02-19 18:25 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208085121.2430-1-a@bayrepo.ru \
--to=a@bayrepo.ru \
--cc=aspriel@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox