From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@kernel.org>, Alexey Berezhok <a@bayrepo.ru>
Cc: Arend van Spriel <aspriel@gmail.com>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean
Date: Mon, 12 Feb 2024 17:00:59 +0100 [thread overview]
Message-ID: <9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com> (raw)
In-Reply-To: <170775233602.2851594.8173116143852900695.kvalo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On 2/12/2024 4:38 PM, Kalle Valo wrote:
> Alexey Berezhok <a@bayrepo.ru> wrote:
>
>> In 'brcmf_cfg80211_start_ap()', not assume that
>> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
>> an explicit check instead. Compile tested only.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Signed-off-by: Alexey Berezhok <a@bayrepo.ru>
>
> Patch applied to wireless-next.git, thanks.
>
> f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value to boolean
Alexey,
Can you do a follow-up patch addressing my comment? If not I will do it
myself.
Regards,
Arend
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240208085121.2430-1-a@bayrepo.ru/
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2024-02-12 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 8:51 [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean Alexey Berezhok
2024-02-08 14:06 ` Arend van Spriel
2024-02-08 14:15 ` Johannes Berg
2024-02-08 15:56 ` Arend Van Spriel
2024-02-12 15:38 ` Kalle Valo
2024-02-12 16:00 ` Arend van Spriel [this message]
2024-02-12 16:03 ` Kalle Valo
2024-02-12 16:43 ` Arend Van Spriel
2024-02-13 13:34 ` Kalle Valo
2024-02-13 14:01 ` Arend van Spriel
2024-02-13 15:46 ` Kalle Valo
2024-02-13 17:40 ` Arend Van Spriel
2024-02-14 10:28 ` Alexey Berezhok
2024-02-14 11:44 ` Arend Van Spriel
2024-02-19 18:25 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=a@bayrepo.ru \
--cc=aspriel@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox