* [PATCH 01/18] backlight: adp5520: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
@ 2014-08-26 12:57 ` Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:57 ` [PATCH 02/18] backlight: adp8860: " Jingoo Han
` (16 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:57 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/adp5520_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c
index f37097a261a2..8280245d7c12 100644
--- a/drivers/video/backlight/adp5520_bl.c
+++ b/drivers/video/backlight/adp5520_bl.c
@@ -67,6 +67,7 @@ static int adp5520_bl_set(struct backlight_device *bl, int brightness)
static int adp5520_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;
+
if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 01/18] backlight: adp5520: add blank line after declarations
2014-08-26 12:57 ` [PATCH 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
@ 2014-08-26 16:37 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:37 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/adp5520_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c
> index f37097a261a2..8280245d7c12 100644
> --- a/drivers/video/backlight/adp5520_bl.c
> +++ b/drivers/video/backlight/adp5520_bl.c
> @@ -67,6 +67,7 @@ static int adp5520_bl_set(struct backlight_device *bl, int brightness)
> static int adp5520_bl_update_status(struct backlight_device *bl)
> {
> int brightness = bl->props.brightness;
> +
> if (bl->props.power != FB_BLANK_UNBLANK)
> brightness = 0;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 02/18] backlight: adp8860: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-26 12:57 ` [PATCH 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
@ 2014-08-26 12:57 ` Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:57 ` [PATCH 03/18] backlight: adp8870: " Jingoo Han
` (15 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:57 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/adp8860_bl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index be8d83deca7d..71147f4461b8 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -181,6 +181,7 @@ static int adp8860_clr_bits(struct i2c_client *client, int reg, uint8_t bit_mask
static void adp8860_led_work(struct work_struct *work)
{
struct adp8860_led *led = container_of(work, struct adp8860_led, work);
+
adp8860_write(led->client, ADP8860_ISC1 - led->id + 1,
led->new_brightness >> 1);
}
@@ -362,6 +363,7 @@ static int adp8860_bl_set(struct backlight_device *bl, int brightness)
static int adp8860_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;
+
if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;
@@ -499,6 +501,7 @@ static ssize_t adp8860_bl_l1_daylight_max_store(struct device *dev,
{
struct adp8860_bl *data = dev_get_drvdata(dev);
int ret = kstrtoul(buf, 10, &data->cached_daylight_max);
+
if (ret)
return ret;
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 02/18] backlight: adp8860: add blank line after declarations
2014-08-26 12:57 ` [PATCH 02/18] backlight: adp8860: " Jingoo Han
@ 2014-08-26 16:37 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:37 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index be8d83deca7d..71147f4461b8 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -181,6 +181,7 @@ static int adp8860_clr_bits(struct i2c_client *client, int reg, uint8_t bit_mask
> static void adp8860_led_work(struct work_struct *work)
> {
> struct adp8860_led *led = container_of(work, struct adp8860_led, work);
> +
> adp8860_write(led->client, ADP8860_ISC1 - led->id + 1,
> led->new_brightness >> 1);
> }
> @@ -362,6 +363,7 @@ static int adp8860_bl_set(struct backlight_device *bl, int brightness)
> static int adp8860_bl_update_status(struct backlight_device *bl)
> {
> int brightness = bl->props.brightness;
> +
> if (bl->props.power != FB_BLANK_UNBLANK)
> brightness = 0;
>
> @@ -499,6 +501,7 @@ static ssize_t adp8860_bl_l1_daylight_max_store(struct device *dev,
> {
> struct adp8860_bl *data = dev_get_drvdata(dev);
> int ret = kstrtoul(buf, 10, &data->cached_daylight_max);
> +
> if (ret)
> return ret;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 03/18] backlight: adp8870: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-26 12:57 ` [PATCH 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
2014-08-26 12:57 ` [PATCH 02/18] backlight: adp8860: " Jingoo Han
@ 2014-08-26 12:57 ` Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:58 ` [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
` (14 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:57 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/adp8870_bl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
index 251af4d38d86..037e43083343 100644
--- a/drivers/video/backlight/adp8870_bl.c
+++ b/drivers/video/backlight/adp8870_bl.c
@@ -144,6 +144,7 @@ static int adp8870_read(struct i2c_client *client, int reg, uint8_t *val)
static int adp8870_write(struct i2c_client *client, u8 reg, u8 val)
{
int ret = i2c_smbus_write_byte_data(client, reg, val);
+
if (ret)
dev_err(&client->dev, "failed to write\n");
@@ -195,6 +196,7 @@ static int adp8870_clr_bits(struct i2c_client *client, int reg, uint8_t bit_mask
static void adp8870_led_work(struct work_struct *work)
{
struct adp8870_led *led = container_of(work, struct adp8870_led, work);
+
adp8870_write(led->client, ADP8870_ISC1 + led->id - 1,
led->new_brightness >> 1);
}
@@ -399,6 +401,7 @@ static int adp8870_bl_set(struct backlight_device *bl, int brightness)
static int adp8870_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;
+
if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;
@@ -649,6 +652,7 @@ static ssize_t adp8870_bl_l1_daylight_max_store(struct device *dev,
{
struct adp8870_bl *data = dev_get_drvdata(dev);
int ret = kstrtoul(buf, 10, &data->cached_daylight_max);
+
if (ret)
return ret;
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 03/18] backlight: adp8870: add blank line after declarations
2014-08-26 12:57 ` [PATCH 03/18] backlight: adp8870: " Jingoo Han
@ 2014-08-26 16:37 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:37 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/adp8870_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 251af4d38d86..037e43083343 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -144,6 +144,7 @@ static int adp8870_read(struct i2c_client *client, int reg, uint8_t *val)
> static int adp8870_write(struct i2c_client *client, u8 reg, u8 val)
> {
> int ret = i2c_smbus_write_byte_data(client, reg, val);
> +
> if (ret)
> dev_err(&client->dev, "failed to write\n");
>
> @@ -195,6 +196,7 @@ static int adp8870_clr_bits(struct i2c_client *client, int reg, uint8_t bit_mask
> static void adp8870_led_work(struct work_struct *work)
> {
> struct adp8870_led *led = container_of(work, struct adp8870_led, work);
> +
> adp8870_write(led->client, ADP8870_ISC1 + led->id - 1,
> led->new_brightness >> 1);
> }
> @@ -399,6 +401,7 @@ static int adp8870_bl_set(struct backlight_device *bl, int brightness)
> static int adp8870_bl_update_status(struct backlight_device *bl)
> {
> int brightness = bl->props.brightness;
> +
> if (bl->props.power != FB_BLANK_UNBLANK)
> brightness = 0;
>
> @@ -649,6 +652,7 @@ static ssize_t adp8870_bl_l1_daylight_max_store(struct device *dev,
> {
> struct adp8870_bl *data = dev_get_drvdata(dev);
> int ret = kstrtoul(buf, 10, &data->cached_daylight_max);
> +
> if (ret)
> return ret;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (2 preceding siblings ...)
2014-08-26 12:57 ` [PATCH 03/18] backlight: adp8870: " Jingoo Han
@ 2014-08-26 12:58 ` Jingoo Han
2014-08-26 16:36 ` Lee Jones
2014-08-26 12:58 ` [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
` (13 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:58 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/ams369fg06.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c
index 4726c8be626f..5f897f99cc9b 100644
--- a/drivers/video/backlight/ams369fg06.c
+++ b/drivers/video/backlight/ams369fg06.c
@@ -325,11 +325,11 @@ static int ams369fg06_power_on(struct ams369fg06 *lcd)
if (!pd->reset) {
dev_err(lcd->dev, "reset is NULL.\n");
return -EINVAL;
- } else {
- pd->reset(lcd->ld);
- msleep(pd->reset_delay);
}
+ pd->reset(lcd->ld);
+ msleep(pd->reset_delay);
+
ret = ams369fg06_ldi_init(lcd);
if (ret) {
dev_err(lcd->dev, "failed to initialize ldi.\n");
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return
2014-08-26 12:58 ` [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
@ 2014-08-26 16:36 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:36 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ams369fg06.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c
> index 4726c8be626f..5f897f99cc9b 100644
> --- a/drivers/video/backlight/ams369fg06.c
> +++ b/drivers/video/backlight/ams369fg06.c
> @@ -325,11 +325,11 @@ static int ams369fg06_power_on(struct ams369fg06 *lcd)
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = ams369fg06_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (3 preceding siblings ...)
2014-08-26 12:58 ` [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
@ 2014-08-26 12:58 ` Jingoo Han
2014-08-26 16:36 ` Lee Jones
2014-08-26 12:58 ` [PATCH 06/18] backlight: cr_bllcd: " Jingoo Han
` (12 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:58 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/corgi_lcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
index 51d18d637e2b..d7c37a8ccd1f 100644
--- a/drivers/video/backlight/corgi_lcd.c
+++ b/drivers/video/backlight/corgi_lcd.c
@@ -143,6 +143,7 @@ static void lcdtg_i2c_send_byte(struct corgi_lcd *lcd,
uint8_t base, uint8_t data)
{
int i;
+
for (i = 0; i < 8; i++) {
if (data & 0x80)
lcdtg_i2c_send_bit(lcd, base | POWER0_COM_DOUT);
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations
2014-08-26 12:58 ` [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
@ 2014-08-26 16:36 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:36 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/corgi_lcd.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
> index 51d18d637e2b..d7c37a8ccd1f 100644
> --- a/drivers/video/backlight/corgi_lcd.c
> +++ b/drivers/video/backlight/corgi_lcd.c
> @@ -143,6 +143,7 @@ static void lcdtg_i2c_send_byte(struct corgi_lcd *lcd,
> uint8_t base, uint8_t data)
> {
> int i;
> +
> for (i = 0; i < 8; i++) {
> if (data & 0x80)
> lcdtg_i2c_send_bit(lcd, base | POWER0_COM_DOUT);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 06/18] backlight: cr_bllcd: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (4 preceding siblings ...)
2014-08-26 12:58 ` [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
@ 2014-08-26 12:58 ` Jingoo Han
2014-08-26 16:35 ` Lee Jones
2014-08-26 12:59 ` [PATCH 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
` (11 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:58 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/cr_bllcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
index f3fed9ef745f..3e3880fc8c8e 100644
--- a/drivers/video/backlight/cr_bllcd.c
+++ b/drivers/video/backlight/cr_bllcd.c
@@ -235,6 +235,7 @@ static int cr_backlight_probe(struct platform_device *pdev)
static int cr_backlight_remove(struct platform_device *pdev)
{
struct cr_panel *crp = platform_get_drvdata(pdev);
+
crp->cr_backlight_device->props.power = FB_BLANK_POWERDOWN;
crp->cr_backlight_device->props.brightness = 0;
crp->cr_backlight_device->props.max_brightness = 0;
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 06/18] backlight: cr_bllcd: add blank line after declarations
2014-08-26 12:58 ` [PATCH 06/18] backlight: cr_bllcd: " Jingoo Han
@ 2014-08-26 16:35 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:35 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/cr_bllcd.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
> index f3fed9ef745f..3e3880fc8c8e 100644
> --- a/drivers/video/backlight/cr_bllcd.c
> +++ b/drivers/video/backlight/cr_bllcd.c
> @@ -235,6 +235,7 @@ static int cr_backlight_probe(struct platform_device *pdev)
> static int cr_backlight_remove(struct platform_device *pdev)
> {
> struct cr_panel *crp = platform_get_drvdata(pdev);
> +
> crp->cr_backlight_device->props.power = FB_BLANK_POWERDOWN;
> crp->cr_backlight_device->props.brightness = 0;
> crp->cr_backlight_device->props.max_brightness = 0;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 07/18] backlight: ili922x: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (5 preceding siblings ...)
2014-08-26 12:58 ` [PATCH 06/18] backlight: cr_bllcd: " Jingoo Han
@ 2014-08-26 12:59 ` Jingoo Han
2014-08-26 16:35 ` Lee Jones
2014-08-26 12:59 ` [PATCH 08/18] backlight: ld9040: " Jingoo Han
` (10 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:59 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/ili922x.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
index ea67fe199e34..e7f0890cc211 100644
--- a/drivers/video/backlight/ili922x.c
+++ b/drivers/video/backlight/ili922x.c
@@ -495,17 +495,18 @@ static int ili922x_probe(struct spi_device *spi)
"no LCD found: Chip ID 0x%x, ret %d\n",
reg, ret);
return -ENODEV;
- } else {
- dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
- reg, spi->max_speed_hz, spi->mode);
}
+ dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
+ reg, spi->max_speed_hz, spi->mode);
+
ret = ili922x_read_status(spi, ®);
if (ret) {
dev_err(&spi->dev, "reading RS failed...\n");
return ret;
- } else
- dev_dbg(&spi->dev, "status: 0x%x\n", reg);
+ }
+
+ dev_dbg(&spi->dev, "status: 0x%x\n", reg);
ili922x_display_init(spi);
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 07/18] backlight: ili922x: remove 'else' after a return
2014-08-26 12:59 ` [PATCH 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
@ 2014-08-26 16:35 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:35 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ili922x.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index ea67fe199e34..e7f0890cc211 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -495,17 +495,18 @@ static int ili922x_probe(struct spi_device *spi)
> "no LCD found: Chip ID 0x%x, ret %d\n",
> reg, ret);
> return -ENODEV;
> - } else {
> - dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> - reg, spi->max_speed_hz, spi->mode);
> }
>
> + dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> + reg, spi->max_speed_hz, spi->mode);
> +
> ret = ili922x_read_status(spi, ®);
> if (ret) {
> dev_err(&spi->dev, "reading RS failed...\n");
> return ret;
> - } else
> - dev_dbg(&spi->dev, "status: 0x%x\n", reg);
> + }
> +
> + dev_dbg(&spi->dev, "status: 0x%x\n", reg);
>
> ili922x_display_init(spi);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 08/18] backlight: ld9040: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (6 preceding siblings ...)
2014-08-26 12:59 ` [PATCH 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
@ 2014-08-26 12:59 ` Jingoo Han
2014-08-26 16:34 ` Lee Jones
2014-08-26 12:59 ` [PATCH 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
` (9 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:59 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/ld9040.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
index ccb44e8e4927..f71eaf10c4eb 100644
--- a/drivers/video/backlight/ld9040.c
+++ b/drivers/video/backlight/ld9040.c
@@ -566,11 +566,11 @@ static int ld9040_power_on(struct ld9040 *lcd)
if (!pd->reset) {
dev_err(lcd->dev, "reset is NULL.\n");
return -EINVAL;
- } else {
- pd->reset(lcd->ld);
- msleep(pd->reset_delay);
}
+ pd->reset(lcd->ld);
+ msleep(pd->reset_delay);
+
ret = ld9040_ldi_init(lcd);
if (ret) {
dev_err(lcd->dev, "failed to initialize ldi.\n");
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 08/18] backlight: ld9040: remove 'else' after a return
2014-08-26 12:59 ` [PATCH 08/18] backlight: ld9040: " Jingoo Han
@ 2014-08-26 16:34 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:34 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ld9040.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
> index ccb44e8e4927..f71eaf10c4eb 100644
> --- a/drivers/video/backlight/ld9040.c
> +++ b/drivers/video/backlight/ld9040.c
> @@ -566,11 +566,11 @@ static int ld9040_power_on(struct ld9040 *lcd)
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = ld9040_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 09/18] backlight: lm3639: remove unnecessary return statements
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (7 preceding siblings ...)
2014-08-26 12:59 ` [PATCH 08/18] backlight: ld9040: " Jingoo Han
@ 2014-08-26 12:59 ` Jingoo Han
2014-08-26 16:34 ` Lee Jones
2014-08-26 13:00 ` [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
` (8 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 12:59 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/lm3639_bl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 5f36808d214f..cd50df5807ea 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -254,7 +254,6 @@ static void lm3639_torch_brightness_set(struct led_classdev *cdev,
return;
out:
dev_err(pchip->dev, "i2c failed to access register\n");
- return;
}
/* flash */
@@ -293,7 +292,6 @@ static void lm3639_flash_brightness_set(struct led_classdev *cdev,
return;
out:
dev_err(pchip->dev, "i2c failed to access register\n");
- return;
}
static const struct regmap_config lm3639_regmap = {
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 09/18] backlight: lm3639: remove unnecessary return statements
2014-08-26 12:59 ` [PATCH 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
@ 2014-08-26 16:34 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:34 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lm3639_bl.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 5f36808d214f..cd50df5807ea 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -254,7 +254,6 @@ static void lm3639_torch_brightness_set(struct led_classdev *cdev,
> return;
> out:
> dev_err(pchip->dev, "i2c failed to access register\n");
> - return;
> }
>
> /* flash */
> @@ -293,7 +292,6 @@ static void lm3639_flash_brightness_set(struct led_classdev *cdev,
> return;
> out:
> dev_err(pchip->dev, "i2c failed to access register\n");
> - return;
> }
>
> static const struct regmap_config lm3639_regmap = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (8 preceding siblings ...)
2014-08-26 12:59 ` [PATCH 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
@ 2014-08-26 13:00 ` Jingoo Han
2014-08-26 16:33 ` Lee Jones
2014-08-26 13:00 ` [PATCH 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
` (7 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:00 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/lms501kf03.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c
index 77258b7b04be..7e3810308c3e 100644
--- a/drivers/video/backlight/lms501kf03.c
+++ b/drivers/video/backlight/lms501kf03.c
@@ -232,19 +232,19 @@ static int lms501kf03_power_on(struct lms501kf03 *lcd)
if (!pd->power_on) {
dev_err(lcd->dev, "power_on is NULL.\n");
return -EINVAL;
- } else {
- pd->power_on(lcd->ld, 1);
- msleep(pd->power_on_delay);
}
+ pd->power_on(lcd->ld, 1);
+ msleep(pd->power_on_delay);
+
if (!pd->reset) {
dev_err(lcd->dev, "reset is NULL.\n");
return -EINVAL;
- } else {
- pd->reset(lcd->ld);
- msleep(pd->reset_delay);
}
+ pd->reset(lcd->ld);
+ msleep(pd->reset_delay);
+
ret = lms501kf03_ldi_init(lcd);
if (ret) {
dev_err(lcd->dev, "failed to initialize ldi.\n");
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return
2014-08-26 13:00 ` [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
@ 2014-08-26 16:33 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:33 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lms501kf03.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c
> index 77258b7b04be..7e3810308c3e 100644
> --- a/drivers/video/backlight/lms501kf03.c
> +++ b/drivers/video/backlight/lms501kf03.c
> @@ -232,19 +232,19 @@ static int lms501kf03_power_on(struct lms501kf03 *lcd)
> if (!pd->power_on) {
> dev_err(lcd->dev, "power_on is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->power_on(lcd->ld, 1);
> - msleep(pd->power_on_delay);
> }
>
> + pd->power_on(lcd->ld, 1);
> + msleep(pd->power_on_delay);
> +
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = lms501kf03_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 11/18] backlight: lp855x: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (9 preceding siblings ...)
2014-08-26 13:00 ` [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
@ 2014-08-26 13:00 ` Jingoo Han
2014-08-26 16:33 ` Lee Jones
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
` (6 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:00 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/lp855x_bl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index dcdd5443efcf..25fb8e3d75b1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -268,6 +268,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
} else if (lp->mode == REGISTER_BASED) {
u8 val = bl->props.brightness;
+
lp855x_write_byte(lp, lp->cfg->reg_brightness, val);
}
@@ -308,6 +309,7 @@ static ssize_t lp855x_get_chip_id(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct lp855x *lp = dev_get_drvdata(dev);
+
return scnprintf(buf, PAGE_SIZE, "%s\n", lp->chipname);
}
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 11/18] backlight: lp855x: add blank line after declarations
2014-08-26 13:00 ` [PATCH 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
@ 2014-08-26 16:33 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:33 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index dcdd5443efcf..25fb8e3d75b1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -268,6 +268,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
>
> } else if (lp->mode == REGISTER_BASED) {
> u8 val = bl->props.brightness;
> +
> lp855x_write_byte(lp, lp->cfg->reg_brightness, val);
> }
>
> @@ -308,6 +309,7 @@ static ssize_t lp855x_get_chip_id(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct lp855x *lp = dev_get_drvdata(dev);
> +
> return scnprintf(buf, PAGE_SIZE, "%s\n", lp->chipname);
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 12/18] backlight: pcf50633: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (10 preceding siblings ...)
2014-08-26 13:00 ` [PATCH 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
@ 2014-08-26 13:00 ` Jingoo Han
2014-08-26 16:31 ` Lee Jones
2014-08-26 16:32 ` Lee Jones
2014-08-26 13:01 ` [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
` (5 subsequent siblings)
17 siblings, 2 replies; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:00 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/pcf50633-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c
index b95d3b0aaffe..85bd573b6d15 100644
--- a/drivers/video/backlight/pcf50633-backlight.c
+++ b/drivers/video/backlight/pcf50633-backlight.c
@@ -90,6 +90,7 @@ static int pcf50633_bl_update_status(struct backlight_device *bl)
static int pcf50633_bl_get_brightness(struct backlight_device *bl)
{
struct pcf50633_bl *pcf_bl = bl_get_data(bl);
+
return pcf_bl->brightness;
}
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 12/18] backlight: pcf50633: add blank line after declarations
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
@ 2014-08-26 16:31 ` Lee Jones
2014-08-26 16:32 ` Lee Jones
1 sibling, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:31 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/pcf50633-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c
> index b95d3b0aaffe..85bd573b6d15 100644
> --- a/drivers/video/backlight/pcf50633-backlight.c
> +++ b/drivers/video/backlight/pcf50633-backlight.c
> @@ -90,6 +90,7 @@ static int pcf50633_bl_update_status(struct backlight_device *bl)
> static int pcf50633_bl_get_brightness(struct backlight_device *bl)
> {
> struct pcf50633_bl *pcf_bl = bl_get_data(bl);
> +
> return pcf_bl->brightness;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH 12/18] backlight: pcf50633: add blank line after declarations
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
2014-08-26 16:31 ` Lee Jones
@ 2014-08-26 16:32 ` Lee Jones
2014-08-26 16:32 ` Lee Jones
1 sibling, 1 reply; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:32 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/pcf50633-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c
> index b95d3b0aaffe..85bd573b6d15 100644
> --- a/drivers/video/backlight/pcf50633-backlight.c
> +++ b/drivers/video/backlight/pcf50633-backlight.c
> @@ -90,6 +90,7 @@ static int pcf50633_bl_update_status(struct backlight_device *bl)
> static int pcf50633_bl_get_brightness(struct backlight_device *bl)
> {
> struct pcf50633_bl *pcf_bl = bl_get_data(bl);
> +
> return pcf_bl->brightness;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH 12/18] backlight: pcf50633: add blank line after declarations
2014-08-26 16:32 ` Lee Jones
@ 2014-08-26 16:32 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:32 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Lee Jones wrote:
> On Tue, 26 Aug 2014, Jingoo Han wrote:
>
> > Fixed the following checkpatch warning.
> >
> > WARNING: Missing a blank line after declarations
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/video/backlight/pcf50633-backlight.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Whoops, sorry for the duplication. I forgot to refresh my INBOX!
> > diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c
> > index b95d3b0aaffe..85bd573b6d15 100644
> > --- a/drivers/video/backlight/pcf50633-backlight.c
> > +++ b/drivers/video/backlight/pcf50633-backlight.c
> > @@ -90,6 +90,7 @@ static int pcf50633_bl_update_status(struct backlight_device *bl)
> > static int pcf50633_bl_get_brightness(struct backlight_device *bl)
> > {
> > struct pcf50633_bl *pcf_bl = bl_get_data(bl);
> > +
> > return pcf_bl->brightness;
> > }
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (11 preceding siblings ...)
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
@ 2014-08-26 13:01 ` Jingoo Han
2014-08-26 16:31 ` Lee Jones
2014-08-26 13:01 ` [PATCH 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
` (4 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:01 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/s6e63m0.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index f3a65c8940ed..28bfa127fee4 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -507,19 +507,19 @@ static int s6e63m0_power_on(struct s6e63m0 *lcd)
if (!pd->power_on) {
dev_err(lcd->dev, "power_on is NULL.\n");
return -EINVAL;
- } else {
- pd->power_on(lcd->ld, 1);
- msleep(pd->power_on_delay);
}
+ pd->power_on(lcd->ld, 1);
+ msleep(pd->power_on_delay);
+
if (!pd->reset) {
dev_err(lcd->dev, "reset is NULL.\n");
return -EINVAL;
- } else {
- pd->reset(lcd->ld);
- msleep(pd->reset_delay);
}
+ pd->reset(lcd->ld);
+ msleep(pd->reset_delay);
+
ret = s6e63m0_ldi_init(lcd);
if (ret) {
dev_err(lcd->dev, "failed to initialize ldi.\n");
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return
2014-08-26 13:01 ` [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
@ 2014-08-26 16:31 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:31 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/s6e63m0.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index f3a65c8940ed..28bfa127fee4 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -507,19 +507,19 @@ static int s6e63m0_power_on(struct s6e63m0 *lcd)
> if (!pd->power_on) {
> dev_err(lcd->dev, "power_on is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->power_on(lcd->ld, 1);
> - msleep(pd->power_on_delay);
> }
>
> + pd->power_on(lcd->ld, 1);
> + msleep(pd->power_on_delay);
> +
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = s6e63m0_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 14/18] backlight: tdo24m: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (12 preceding siblings ...)
2014-08-26 13:01 ` [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
@ 2014-08-26 13:01 ` Jingoo Han
2014-08-26 16:30 ` Lee Jones
2014-08-26 13:01 ` [PATCH 15/18] backlight: wm831x_bl: " Jingoo Han
` (3 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:01 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/tdo24m.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/tdo24m.c b/drivers/video/backlight/tdo24m.c
index 908016fc5829..30afce33ef2a 100644
--- a/drivers/video/backlight/tdo24m.c
+++ b/drivers/video/backlight/tdo24m.c
@@ -300,12 +300,14 @@ static int tdo24m_power(struct tdo24m *lcd, int power)
static int tdo24m_set_power(struct lcd_device *ld, int power)
{
struct tdo24m *lcd = lcd_get_data(ld);
+
return tdo24m_power(lcd, power);
}
static int tdo24m_get_power(struct lcd_device *ld)
{
struct tdo24m *lcd = lcd_get_data(ld);
+
return lcd->power;
}
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 14/18] backlight: tdo24m: add blank line after declarations
2014-08-26 13:01 ` [PATCH 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
@ 2014-08-26 16:30 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/tdo24m.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/tdo24m.c b/drivers/video/backlight/tdo24m.c
> index 908016fc5829..30afce33ef2a 100644
> --- a/drivers/video/backlight/tdo24m.c
> +++ b/drivers/video/backlight/tdo24m.c
> @@ -300,12 +300,14 @@ static int tdo24m_power(struct tdo24m *lcd, int power)
> static int tdo24m_set_power(struct lcd_device *ld, int power)
> {
> struct tdo24m *lcd = lcd_get_data(ld);
> +
> return tdo24m_power(lcd, power);
> }
>
> static int tdo24m_get_power(struct lcd_device *ld)
> {
> struct tdo24m *lcd = lcd_get_data(ld);
> +
> return lcd->power;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 15/18] backlight: wm831x_bl: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (13 preceding siblings ...)
2014-08-26 13:01 ` [PATCH 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
@ 2014-08-26 13:01 ` Jingoo Han
2014-08-26 16:30 ` Lee Jones
2014-08-26 13:02 ` [PATCH 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
` (2 subsequent siblings)
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:01 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/wm831x_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/wm831x_bl.c b/drivers/video/backlight/wm831x_bl.c
index 8b9455e93069..07ca98e2a5d4 100644
--- a/drivers/video/backlight/wm831x_bl.c
+++ b/drivers/video/backlight/wm831x_bl.c
@@ -111,6 +111,7 @@ static int wm831x_backlight_update_status(struct backlight_device *bl)
static int wm831x_backlight_get_brightness(struct backlight_device *bl)
{
struct wm831x_backlight_data *data = bl_get_data(bl);
+
return data->current_brightness;
}
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 15/18] backlight: wm831x_bl: add blank line after declarations
2014-08-26 13:01 ` [PATCH 15/18] backlight: wm831x_bl: " Jingoo Han
@ 2014-08-26 16:30 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/wm831x_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/wm831x_bl.c b/drivers/video/backlight/wm831x_bl.c
> index 8b9455e93069..07ca98e2a5d4 100644
> --- a/drivers/video/backlight/wm831x_bl.c
> +++ b/drivers/video/backlight/wm831x_bl.c
> @@ -111,6 +111,7 @@ static int wm831x_backlight_update_status(struct backlight_device *bl)
> static int wm831x_backlight_get_brightness(struct backlight_device *bl)
> {
> struct wm831x_backlight_data *data = bl_get_data(bl);
> +
> return data->current_brightness;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 16/18] backlight: jornada720: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (14 preceding siblings ...)
2014-08-26 13:01 ` [PATCH 15/18] backlight: wm831x_bl: " Jingoo Han
@ 2014-08-26 13:02 ` Jingoo Han
2014-08-26 16:29 ` Lee Jones
2014-08-26 13:02 ` [PATCH 17/18] " Jingoo Han
2014-08-26 13:02 ` [PATCH 18/18] backlight: omap1: add blank line after declarations Jingoo Han
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:02 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/jornada720_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
index 6ce96b4a8796..7e6ff5346892 100644
--- a/drivers/video/backlight/jornada720_bl.c
+++ b/drivers/video/backlight/jornada720_bl.c
@@ -41,11 +41,11 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
dev_err(&bd->dev, "get brightness timeout\n");
jornada_ssp_end();
return -ETIMEDOUT;
- } else {
- /* exchange txdummy for value */
- ret = jornada_ssp_byte(TXDUMMY);
}
+ /* exchange txdummy for value */
+ ret = jornada_ssp_byte(TXDUMMY);
+
jornada_ssp_end();
return BL_MAX_BRIGHT - ret;
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 16/18] backlight: jornada720: remove 'else' after a return
2014-08-26 13:02 ` [PATCH 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
@ 2014-08-26 16:29 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:29 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/jornada720_bl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 6ce96b4a8796..7e6ff5346892 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -41,11 +41,11 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
> dev_err(&bd->dev, "get brightness timeout\n");
> jornada_ssp_end();
> return -ETIMEDOUT;
> - } else {
> - /* exchange txdummy for value */
> - ret = jornada_ssp_byte(TXDUMMY);
> }
>
> + /* exchange txdummy for value */
> + ret = jornada_ssp_byte(TXDUMMY);
> +
> jornada_ssp_end();
>
> return BL_MAX_BRIGHT - ret;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 17/18] backlight: jornada720: remove 'else' after a return
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (15 preceding siblings ...)
2014-08-26 13:02 ` [PATCH 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
@ 2014-08-26 13:02 ` Jingoo Han
2014-08-26 16:28 ` Lee Jones
2014-08-26 13:02 ` [PATCH 18/18] backlight: omap1: add blank line after declarations Jingoo Han
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:02 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/jornada720_lcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
index 228bc319de19..1cf3d59f1e7f 100644
--- a/drivers/video/backlight/jornada720_lcd.c
+++ b/drivers/video/backlight/jornada720_lcd.c
@@ -30,8 +30,8 @@ static int jornada_lcd_get_power(struct lcd_device *ld)
/* LDD2 in PPC = LCD POWER */
if (PPSR & PPC_LDD2)
return FB_BLANK_UNBLANK; /* PW ON */
- else
- return FB_BLANK_POWERDOWN; /* PW OFF */
+
+ return FB_BLANK_POWERDOWN; /* PW OFF */
}
static int jornada_lcd_get_contrast(struct lcd_device *ld)
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 17/18] backlight: jornada720: remove 'else' after a return
2014-08-26 13:02 ` [PATCH 17/18] " Jingoo Han
@ 2014-08-26 16:28 ` Lee Jones
2014-08-27 0:37 ` Jingoo Han
0 siblings, 1 reply; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:28 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/jornada720_lcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 228bc319de19..1cf3d59f1e7f 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -30,8 +30,8 @@ static int jornada_lcd_get_power(struct lcd_device *ld)
> /* LDD2 in PPC = LCD POWER */
> if (PPSR & PPC_LDD2)
> return FB_BLANK_UNBLANK; /* PW ON */
> - else
> - return FB_BLANK_POWERDOWN; /* PW OFF */
> +
> + return FB_BLANK_POWERDOWN; /* PW OFF */
How about:
return PPSR & PPC_LDD2 ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;
> }
>
> static int jornada_lcd_get_contrast(struct lcd_device *ld)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 17/18] backlight: jornada720: remove 'else' after a return
2014-08-26 16:28 ` Lee Jones
@ 2014-08-27 0:37 ` Jingoo Han
0 siblings, 0 replies; 40+ messages in thread
From: Jingoo Han @ 2014-08-27 0:37 UTC (permalink / raw)
To: 'Lee Jones'
Cc: linux-kernel, 'Bryan Wu', 'Jingoo Han'
On Wednesday, August 27, 2014 1:28 AM, Lee Jones wrote:
> On Tue, 26 Aug 2014, Jingoo Han wrote:
>
> > Fixed the following checkpatch warning.
> >
> > WARNING: else is not generally useful after a break or return
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/video/backlight/jornada720_lcd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> > index 228bc319de19..1cf3d59f1e7f 100644
> > --- a/drivers/video/backlight/jornada720_lcd.c
> > +++ b/drivers/video/backlight/jornada720_lcd.c
> > @@ -30,8 +30,8 @@ static int jornada_lcd_get_power(struct lcd_device *ld)
> > /* LDD2 in PPC = LCD POWER */
> > if (PPSR & PPC_LDD2)
> > return FB_BLANK_UNBLANK; /* PW ON */
> > - else
> > - return FB_BLANK_POWERDOWN; /* PW OFF */
> > +
> > + return FB_BLANK_POWERDOWN; /* PW OFF */
>
> How about:
>
> return PPSR & PPC_LDD2 ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;
OK, it looks good.
Thank you for your suggestion!
Best regards,
Jingoo Han
>
> > }
> >
> > static int jornada_lcd_get_contrast(struct lcd_device *ld)
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 18/18] backlight: omap1: add blank line after declarations
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
` (16 preceding siblings ...)
2014-08-26 13:02 ` [PATCH 17/18] " Jingoo Han
@ 2014-08-26 13:02 ` Jingoo Han
2014-08-26 16:28 ` Lee Jones
17 siblings, 1 reply; 40+ messages in thread
From: Jingoo Han @ 2014-08-26 13:02 UTC (permalink / raw)
To: linux-kernel
Cc: 'Bryan Wu', 'Lee Jones', 'Jingoo Han'
Fixed the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/omap1_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
index a0dcd88ac74f..546d94df21d5 100644
--- a/drivers/video/backlight/omap1_bl.c
+++ b/drivers/video/backlight/omap1_bl.c
@@ -120,6 +120,7 @@ static int omapbl_update_status(struct backlight_device *dev)
static int omapbl_get_intensity(struct backlight_device *dev)
{
struct omap_backlight *bl = bl_get_data(dev);
+
return bl->current_intensity;
}
--
2.0.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH 18/18] backlight: omap1: add blank line after declarations
2014-08-26 13:02 ` [PATCH 18/18] backlight: omap1: add blank line after declarations Jingoo Han
@ 2014-08-26 16:28 ` Lee Jones
0 siblings, 0 replies; 40+ messages in thread
From: Lee Jones @ 2014-08-26 16:28 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Bryan Wu'
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/omap1_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
> index a0dcd88ac74f..546d94df21d5 100644
> --- a/drivers/video/backlight/omap1_bl.c
> +++ b/drivers/video/backlight/omap1_bl.c
> @@ -120,6 +120,7 @@ static int omapbl_update_status(struct backlight_device *dev)
> static int omapbl_get_intensity(struct backlight_device *dev)
> {
> struct omap_backlight *bl = bl_get_data(dev);
> +
> return bl->current_intensity;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 40+ messages in thread