Re: [PATCH] resync ATI PCI idents into base kernel

Re: [PATCH] resync ATI PCI idents into base kernel

[Greg KH]

On Mon, Mar 07, 2005 at 09:50:19PM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.1982.132.7, 2005/03/07 13:50:19-08:00, alan@lxorguk.ukuu.org.uk
> 
> 	[PATCH] resync ATI PCI idents into base kernel
> 
> 
> 
>  pci_ids.h |   11 +++++++++++
>  1 files changed, 11 insertions(+)
> 
> 
> diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> --- a/include/linux/pci_ids.h	2005-03-07 14:17:11 -08:00
> +++ b/include/linux/pci_ids.h	2005-03-07 14:17:11 -08:00
> @@ -352,10 +352,21 @@
>  #define PCI_DEVICE_ID_ATI_RS300_133	0x5831
>  #define PCI_DEVICE_ID_ATI_RS300_166	0x5832
>  #define PCI_DEVICE_ID_ATI_RS300_200	0x5833
> +#define PCI_DEVICE_ID_ATI_RS350_100     0x7830
> +#define PCI_DEVICE_ID_ATI_RS350_133     0x7831
> +#define PCI_DEVICE_ID_ATI_RS350_166     0x7832
> +#define PCI_DEVICE_ID_ATI_RS350_200     0x7833
> +#define PCI_DEVICE_ID_ATI_RS400_100     0x5a30
> +#define PCI_DEVICE_ID_ATI_RS400_133     0x5a31
> +#define PCI_DEVICE_ID_ATI_RS400_166     0x5a32
> +#define PCI_DEVICE_ID_ATI_RS400_200     0x5a33
> +#define PCI_DEVICE_ID_ATI_RS480         0x5950

Was there a reason you did this without using tabs, like the rest of the
file?

Again, the maintainer chain is well documented...

{sigh}

Oh, no Signed-off-by: line either :(

greg k-h

Re: [PATCH] resync ATI PCI idents into base kernel

[Alan Cox]

> Was there a reason you did this without using tabs, like the rest of the
> file?

No but I'll send Linus an update to fix that now.

> Again, the maintainer chain is well documented...

Really - so does it go to the PCI maintainer, the IDE maintainer or the
DRI maintainer or someone else, or all of them, or in bits to different
ones remembering there are dependancies and I don't use bitcreeper ?

Alan

Re: [PATCH] resync ATI PCI idents into base kernel

[Bartlomiej Zolnierkiewicz]

On Tue, 08 Mar 2005 10:15:30 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > Was there a reason you did this without using tabs, like the rest of the
> > file?
> 
> No but I'll send Linus an update to fix that now.
> 
> > Again, the maintainer chain is well documented...
> 
> Really - so does it go to the PCI maintainer, the IDE maintainer or the
> DRI maintainer or someone else, or all of them, or in bits to different
> ones remembering there are dependancies and I don't use bitcreeper ?

it should go to /dev/null because there are no users of these IDs ;-)

Re: [PATCH] resync ATI PCI idents into base kernel

[Alan Cox]

On Maw, 2005-03-08 at 10:42, Bartlomiej Zolnierkiewicz wrote:
> > Really - so does it go to the PCI maintainer, the IDE maintainer or the
> > DRI maintainer or someone else, or all of them, or in bits to different
> > ones remembering there are dependancies and I don't use bitcreeper ?
> 
> it should go to /dev/null because there are no users of these IDs ;-)

See the problem - and I'm about to send you a patch so you can use the
SI3112 driver with the ATI hardware because the Jeff Garzik one still
fails for some users quite badly (and no I don't know why either).

Alan

Re: [PATCH] resync ATI PCI idents into base kernel

[Christoph Hellwig]

On Tue, Mar 08, 2005 at 10:15:30AM +0000, Alan Cox wrote:
> > Was there a reason you did this without using tabs, like the rest of the
> > file?
> 
> No but I'll send Linus an update to fix that now.
> 
> > Again, the maintainer chain is well documented...
> 
> Really - so does it go to the PCI maintainer, the IDE maintainer or the
> DRI maintainer or someone else, or all of them, or in bits to different
> ones remembering there are dependancies and I don't use bitcreeper ?

If you don't know send it to Andrew.  

Re: [PATCH] resync ATI PCI idents into base kernel

[Alan Cox]

On Maw, 2005-03-08 at 22:33, Christoph Hellwig wrote:
> > Really - so does it go to the PCI maintainer, the IDE maintainer or the
> > DRI maintainer or someone else, or all of them, or in bits to different
> > ones remembering there are dependancies and I don't use bitcreeper ?
> 
> If you don't know send it to Andrew.  

You are completely missing the point.

Re: [PATCH] resync ATI PCI idents into base kernel

[Christoph Hellwig]

On Wed, Mar 09, 2005 at 03:45:43PM +0000, Alan Cox wrote:
> On Maw, 2005-03-08 at 22:33, Christoph Hellwig wrote:
> > > Really - so does it go to the PCI maintainer, the IDE maintainer or the
> > > DRI maintainer or someone else, or all of them, or in bits to different
> > > ones remembering there are dependancies and I don't use bitcreeper ?
> > 
> > If you don't know send it to Andrew.  
> 
> You are completely missing the point.

Which is?  That's you're so special you don't need to care about the
workflow the ordinary humans have created?

Re: [PATCH] resync ATI PCI idents into base kernel

[Alan Cox]

On Mer, 2005-03-09 at 22:00, Christoph Hellwig wrote:
> Which is?  That's you're so special you don't need to care about the
> workflow the ordinary humans have created?

I don't see the connection between your comment and the thread sorry.

If I send it all to Andrew what will happen. Andrew can either break it
into zillions of pieces and everyone will say "But why do we need this"
or apply it. You might want to ask why so many new drivers don't bother
using pci_ids.h, I'd venture to say its a defensive mechanism against
broken process.

Alan