From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: michael@ellerman.id.au, serue@us.ibm.com,
linuxppc64-dev@ozlabs.org, paulus@au1.ibm.com, anton@au1.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.15-mm4 failure on power5
Date: Wed, 18 Jan 2006 08:04:36 +0100 [thread overview]
Message-ID: <20060118070436.GA24378@elte.hu> (raw)
In-Reply-To: <20060117225304.4b6dd045.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> > [ if this indeed is the case then i'll add irqs_off() checks to
> > DEBUG_MUTEXES=y, to ensure that the mutex APIs are never called with
> > interrupts disabled. ]
>
> Yes, I suppose so. But we're already calling might_sleep(), and
> might_sleep() checks for that. Perhaps the might_sleep() check is
> being defeated by the nasty system_running check.
ah ... indeed.
> There's a sad story behind that system_running check in might_sleep().
> Because the kernel early boot is running in an in_atomic() state, a
> great number of bogus might_sleep() warnings come out because of
> various code doing potentially-sleepy things. I ended up adding the
> system_running test, with the changelog "OK, I give up. Kill all the
> might_sleep warnings from the early boot process." Undoing that and
> fixing up the fallout would be a lot of nasty work.
OTOH, x86 was just fine last i checked, and it has alot more complex
bootup code than any of the other architectures (due to the sheer number
of x86 variants).
Ingo
next prev parent reply other threads:[~2006-01-18 7:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 6:35 2.6.15-mm4 failure on power5 Serge E. Hallyn
2006-01-16 7:05 ` Andrew Morton
2006-01-16 13:00 ` Michael Ellerman
2006-01-16 15:37 ` Serge E. Hallyn
2006-01-16 21:52 ` Dave C Boutcher
2006-01-17 1:09 ` Andrew Morton
2006-01-17 8:17 ` Ingo Molnar
2006-01-17 8:47 ` Andrew Morton
2006-01-17 16:52 ` Dave C Boutcher
2006-01-17 16:55 ` Dave C Boutcher
2006-01-18 6:40 ` Nathan Lynch
2006-01-18 7:07 ` Ingo Molnar
2006-01-18 7:53 ` Nathan Lynch
2006-01-18 8:08 ` Nathan Lynch
2006-01-17 12:22 ` Serge E. Hallyn
2006-01-17 13:32 ` Michael Ellerman
2006-01-17 14:00 ` Ingo Molnar
2006-01-18 0:19 ` Michael Ellerman
2006-01-18 3:32 ` Dave C Boutcher
2006-01-18 6:37 ` Ingo Molnar
2006-01-18 6:53 ` Andrew Morton
2006-01-18 7:04 ` Ingo Molnar [this message]
2006-01-18 7:28 ` Nathan Lynch
2006-01-18 7:37 ` Andrew Morton
2006-01-18 8:08 ` Ingo Molnar
2006-01-18 8:24 ` Andrew Morton
2006-01-18 9:02 ` [patch] work around ppc64 bootup bug by making mutex-debugging save/restore irqs Ingo Molnar
2006-01-18 9:18 ` [patch] turn on might_sleep() in early bootup code too Ingo Molnar
2006-01-18 10:35 ` Andrew Morton
2006-01-18 10:43 ` Ingo Molnar
2006-01-18 11:15 ` [patch] make bug messages more consistent Ingo Molnar
2006-01-19 4:39 ` [patch] turn on might_sleep() in early bootup code too Zwane Mwaikambo
2006-01-18 10:46 ` Nick Piggin
2006-01-18 11:07 ` Ingo Molnar
2006-01-18 12:53 ` [patch] add trylock_kernel() Ingo Molnar
2006-01-18 7:38 ` 2.6.15-mm4 failure on power5 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118070436.GA24378@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=anton@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@au1.ibm.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox