From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: ntl@pobox.com, anton@au1.ibm.com, linux-kernel@vger.kernel.org,
michael@ellerman.id.au, linuxppc64-dev@ozlabs.org,
serue@us.ibm.com, paulus@au1.ibm.com, torvalds@osdl.org
Subject: [patch] make bug messages more consistent
Date: Wed, 18 Jan 2006 12:15:40 +0100 [thread overview]
Message-ID: <20060118111540.GA14023@elte.hu> (raw)
In-Reply-To: <20060118104319.GB7885@elte.hu>
while we are changing debugging code. One problem is that we've got a
hodgepodge of bug messages right now, and i frequently miss e.g.
'Badness' messages from the kernel because they simply do not stick out
visually. 'BUG' is much more apparent and also makes it obvious that
there's a kernel bug here. Here's a patch that makes the messages more
consistent:
--
consolidate all kernel bug printouts to begin with the "BUG: " string.
Makes it easier to find them in large bootup logs.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
----
include/asm-generic/bug.h | 4 ++--
kernel/sched.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Index: linux/include/asm-generic/bug.h
===================================================================
--- linux.orig/include/asm-generic/bug.h
+++ linux/include/asm-generic/bug.h
@@ -7,7 +7,7 @@
#ifdef CONFIG_BUG
#ifndef HAVE_ARCH_BUG
#define BUG() do { \
- printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
+ printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __FUNCTION__); \
panic("BUG!"); \
} while (0)
#endif
@@ -19,7 +19,7 @@
#ifndef HAVE_ARCH_WARN_ON
#define WARN_ON(condition) do { \
if (unlikely((condition)!=0)) { \
- printk("Badness in %s at %s:%d\n", __FUNCTION__, __FILE__, __LINE__); \
+ printk("BUG: warning at %s:%d/%s()\n", __FILE__, __LINE__, __FUNCTION__); \
dump_stack(); \
} \
} while (0)
Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -2973,7 +2973,7 @@ asmlinkage void __sched schedule(void)
*/
if (likely(!current->exit_state)) {
if (unlikely(in_atomic())) {
- printk(KERN_ERR "scheduling while atomic: "
+ printk(KERN_ERR "BUG: scheduling while atomic: "
"%s/0x%08x/%d\n",
current->comm, preempt_count(), current->pid);
dump_stack();
@@ -6293,7 +6293,7 @@ void __might_sleep(char *file, int line)
if (time_before(jiffies, prev_jiffy + HZ) && prev_jiffy)
return;
prev_jiffy = jiffies;
- printk(KERN_ERR "Debug: sleeping function called from invalid"
+ printk(KERN_ERR "BUG: sleeping function called from invalid"
" context at %s:%d\n", file, line);
printk("in_atomic():%d, irqs_disabled():%d\n",
in_atomic(), irqs_disabled());
next prev parent reply other threads:[~2006-01-18 11:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 6:35 2.6.15-mm4 failure on power5 Serge E. Hallyn
2006-01-16 7:05 ` Andrew Morton
2006-01-16 13:00 ` Michael Ellerman
2006-01-16 15:37 ` Serge E. Hallyn
2006-01-16 21:52 ` Dave C Boutcher
2006-01-17 1:09 ` Andrew Morton
2006-01-17 8:17 ` Ingo Molnar
2006-01-17 8:47 ` Andrew Morton
2006-01-17 16:52 ` Dave C Boutcher
2006-01-17 16:55 ` Dave C Boutcher
2006-01-18 6:40 ` Nathan Lynch
2006-01-18 7:07 ` Ingo Molnar
2006-01-18 7:53 ` Nathan Lynch
2006-01-18 8:08 ` Nathan Lynch
2006-01-17 12:22 ` Serge E. Hallyn
2006-01-17 13:32 ` Michael Ellerman
2006-01-17 14:00 ` Ingo Molnar
2006-01-18 0:19 ` Michael Ellerman
2006-01-18 3:32 ` Dave C Boutcher
2006-01-18 6:37 ` Ingo Molnar
2006-01-18 6:53 ` Andrew Morton
2006-01-18 7:04 ` Ingo Molnar
2006-01-18 7:28 ` Nathan Lynch
2006-01-18 7:37 ` Andrew Morton
2006-01-18 8:08 ` Ingo Molnar
2006-01-18 8:24 ` Andrew Morton
2006-01-18 9:02 ` [patch] work around ppc64 bootup bug by making mutex-debugging save/restore irqs Ingo Molnar
2006-01-18 9:18 ` [patch] turn on might_sleep() in early bootup code too Ingo Molnar
2006-01-18 10:35 ` Andrew Morton
2006-01-18 10:43 ` Ingo Molnar
2006-01-18 11:15 ` Ingo Molnar [this message]
2006-01-19 4:39 ` Zwane Mwaikambo
2006-01-18 10:46 ` Nick Piggin
2006-01-18 11:07 ` Ingo Molnar
2006-01-18 12:53 ` [patch] add trylock_kernel() Ingo Molnar
2006-01-18 7:38 ` 2.6.15-mm4 failure on power5 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118111540.GA14023@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=anton@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=ntl@pobox.com \
--cc=paulus@au1.ibm.com \
--cc=serue@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox