From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>,
ntl@pobox.com, anton@au1.ibm.com, linux-kernel@vger.kernel.org,
michael@ellerman.id.au, linuxppc64-dev@ozlabs.org,
serue@us.ibm.com, paulus@au1.ibm.com, torvalds@osdl.org
Subject: Re: [patch] turn on might_sleep() in early bootup code too
Date: Wed, 18 Jan 2006 21:46:35 +1100 [thread overview]
Message-ID: <43CE1C8B.3010802@yahoo.com.au> (raw)
In-Reply-To: <20060118023509.50fe2701.akpm@osdl.org>
Andrew Morton wrote:
> Ingo Molnar <mingo@elte.hu> wrote:
>
>> enable might_sleep() checks even in early bootup code (when system_state
>> != SYSTEM_RUNNING). There's also a new config option to turn this off:
>> CONFIG_DEBUG_SPINLOCK_SLEEP_EARLY_BOOTUP_WORKAROUND
>> while most other architectures.
>
>
> I get just the one on ppc64:
>
>
> Debug: sleeping function called from invalid context at include/asm/semaphore.h:62
> in_atomic():1, irqs_disabled():1
> Call Trace:
> [C0000000004EFD20] [C00000000000F660] .show_stack+0x5c/0x1cc (unreliable)
> [C0000000004EFDD0] [C000000000053214] .__might_sleep+0xbc/0xe0
> [C0000000004EFE60] [C000000000413D1C] .lock_kernel+0x50/0xb0
> [C0000000004EFEF0] [C0000000004AC574] .start_kernel+0x1c/0x278
> [C0000000004EFF90] [C0000000000085D4] .hmt_init+0x0/0x2c
>
>
> Your fault ;)
This lock_kernel should never sleep should it? Maybe it could be changed
to lock_kernel_init_locked() or something?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-01-18 10:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 6:35 2.6.15-mm4 failure on power5 Serge E. Hallyn
2006-01-16 7:05 ` Andrew Morton
2006-01-16 13:00 ` Michael Ellerman
2006-01-16 15:37 ` Serge E. Hallyn
2006-01-16 21:52 ` Dave C Boutcher
2006-01-17 1:09 ` Andrew Morton
2006-01-17 8:17 ` Ingo Molnar
2006-01-17 8:47 ` Andrew Morton
2006-01-17 16:52 ` Dave C Boutcher
2006-01-17 16:55 ` Dave C Boutcher
2006-01-18 6:40 ` Nathan Lynch
2006-01-18 7:07 ` Ingo Molnar
2006-01-18 7:53 ` Nathan Lynch
2006-01-18 8:08 ` Nathan Lynch
2006-01-17 12:22 ` Serge E. Hallyn
2006-01-17 13:32 ` Michael Ellerman
2006-01-17 14:00 ` Ingo Molnar
2006-01-18 0:19 ` Michael Ellerman
2006-01-18 3:32 ` Dave C Boutcher
2006-01-18 6:37 ` Ingo Molnar
2006-01-18 6:53 ` Andrew Morton
2006-01-18 7:04 ` Ingo Molnar
2006-01-18 7:28 ` Nathan Lynch
2006-01-18 7:37 ` Andrew Morton
2006-01-18 8:08 ` Ingo Molnar
2006-01-18 8:24 ` Andrew Morton
2006-01-18 9:02 ` [patch] work around ppc64 bootup bug by making mutex-debugging save/restore irqs Ingo Molnar
2006-01-18 9:18 ` [patch] turn on might_sleep() in early bootup code too Ingo Molnar
2006-01-18 10:35 ` Andrew Morton
2006-01-18 10:43 ` Ingo Molnar
2006-01-18 11:15 ` [patch] make bug messages more consistent Ingo Molnar
2006-01-19 4:39 ` [patch] turn on might_sleep() in early bootup code too Zwane Mwaikambo
2006-01-18 10:46 ` Nick Piggin [this message]
2006-01-18 11:07 ` Ingo Molnar
2006-01-18 12:53 ` [patch] add trylock_kernel() Ingo Molnar
2006-01-18 7:38 ` 2.6.15-mm4 failure on power5 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CE1C8B.3010802@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=anton@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=ntl@pobox.com \
--cc=paulus@au1.ibm.com \
--cc=serue@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox