public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] file as directory
Date: Wed, 23 May 2007 10:58:24 +0100	[thread overview]
Message-ID: <20070523095824.GR4095@ftp.linux.org.uk> (raw)
In-Reply-To: <E1HqmkO-0001R4-00@dorka.pomaz.szeredi.hu>

On Wed, May 23, 2007 at 11:03:08AM +0200, Miklos Szeredi wrote:
> I still don't get it where the superblock comes in.  The locking is
> "interesting" in there, yes.  And I haven't completely convinced
> myself it's right, let alone something that won't easily be screwed up
> in the future.  So there's definitely room for thought there.
> 
> But how does it matter if two different paths have the same sb or a
> different sb mounted over them?
 
Because then you get a slew of fun issues with dropping the final reference
to vfsmount vs. lookup on another place.  What hold do you have on that
superblock and when do you switch from "oh, called ->enter() on the same
inode again, return vfsmount over the same superblock" to "need to
initialize that damn superblock, all mounts are gone"?

> The same dentry is mounted over each one.  The contents of the
> directory should only depend on the contents of the underlying inode.
> The path leading up to it is completely irrelevant.

So what kind of exclusion do you have for ->enter()?  None?

  reply	other threads:[~2007-05-23  9:58 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 18:48 [RFC PATCH] file as directory Miklos Szeredi
2007-05-22 22:10 ` Al Viro
2007-05-23  6:36   ` Miklos Szeredi
2007-05-23  7:03     ` Al Viro
2007-05-23  7:19       ` Miklos Szeredi
2007-05-23  7:36         ` Al Viro
2007-05-23  8:05           ` Miklos Szeredi
2007-05-23  8:29             ` Al Viro
2007-05-23  9:03               ` Miklos Szeredi
2007-05-23  9:58                 ` Al Viro [this message]
2007-05-23 10:14                   ` Miklos Szeredi
2007-05-23  9:16             ` Jan Blunck
2007-05-23  9:28               ` Miklos Szeredi
2007-05-23 12:34           ` Trond Myklebust
2007-05-23 12:40             ` Al Viro
2007-05-23  9:21     ` Jan Blunck
2007-05-23  9:35       ` Miklos Szeredi
2007-05-24 12:07     ` Pavel Machek
2007-05-28 14:43       ` Miklos Szeredi
2007-05-22 23:26 ` Shaya Potter
2007-05-23  6:39   ` Miklos Szeredi
2007-05-23  9:51 ` Al Viro
2007-05-23 10:09   ` Miklos Szeredi
2007-05-23 10:24     ` Miklos Szeredi
2007-05-23 10:24     ` Al Viro
2007-05-23 10:40       ` Miklos Szeredi
2007-05-23 11:39         ` Al Viro
2007-05-23 12:16           ` Al Viro
2007-05-23 13:01             ` Miklos Szeredi
2007-05-23 13:51               ` Al Viro
2007-05-23 14:32                 ` Miklos Szeredi
2007-05-23 15:06                   ` Al Viro
2007-05-23 15:25                     ` Miklos Szeredi
2007-05-23 15:37                       ` Al Viro
2007-05-23 15:55                         ` Miklos Szeredi
2007-05-23 13:23           ` Ph. Marek
2007-05-23 13:54             ` Al Viro
2007-05-23 12:01 ` Jan Engelhardt
2007-05-23 13:20 ` Jaroslav Sykora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070523095824.GR4095@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox