From: Al Viro <viro@ftp.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] file as directory
Date: Wed, 23 May 2007 13:16:20 +0100 [thread overview]
Message-ID: <20070523121620.GU4095@ftp.linux.org.uk> (raw)
In-Reply-To: <20070523113925.GT4095@ftp.linux.org.uk>
On Wed, May 23, 2007 at 12:39:25PM +0100, Al Viro wrote:
> Then I do not understand what this mechanism could be used for, other
> than an odd way to twist POSIX behaviour and see how much of the userland
> would survive that. Certainly not useful for your "look into tarball
> as a tree", unless you seriously want to scan the entire damn fs for
> tarballs at mount time and set up a superblock for each. And for per-file
> extended attributes/forks/whatever-you-call-that-abomination it also
> obviously doesn't help, since you lose them for directories.
>
> IOW, what uses do you have in mind? Complete scenario, please...
Ah... After rereading the thread you've mentioned in the very beginning,
I think I understand what you are driving at. However, in that case
* I really don't see why bother with returning vfsmount at all.
dentry alone is enough to create a new vfsmount, all in fs/namei.c.
* the lifetime rules look fscking scary. You call that ->enter()
on nearly every damn lookup. OK, so you'll recreate equivalent vfsmount,
but... That's a lot of allocations/freeing. Can we do some caching and
deal with it on memory pressure?
* invalidation on unlink is still an open problem.
* locking in final mntput() doesn't look nice; we probably need
a new refcounting scheme for vfsmounts to make that work. I have a variant
that might work here (and make life much easier for expiry logics in
automount/shared trees, which is what it had been initially proposed for),
but it still doesn't kill the need to deal with invalidation. And yes,
NFS still needs it (and so do all network filesystems, really). The question
of caching is related to that.
next prev parent reply other threads:[~2007-05-23 12:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 18:48 [RFC PATCH] file as directory Miklos Szeredi
2007-05-22 22:10 ` Al Viro
2007-05-23 6:36 ` Miklos Szeredi
2007-05-23 7:03 ` Al Viro
2007-05-23 7:19 ` Miklos Szeredi
2007-05-23 7:36 ` Al Viro
2007-05-23 8:05 ` Miklos Szeredi
2007-05-23 8:29 ` Al Viro
2007-05-23 9:03 ` Miklos Szeredi
2007-05-23 9:58 ` Al Viro
2007-05-23 10:14 ` Miklos Szeredi
2007-05-23 9:16 ` Jan Blunck
2007-05-23 9:28 ` Miklos Szeredi
2007-05-23 12:34 ` Trond Myklebust
2007-05-23 12:40 ` Al Viro
2007-05-23 9:21 ` Jan Blunck
2007-05-23 9:35 ` Miklos Szeredi
2007-05-24 12:07 ` Pavel Machek
2007-05-28 14:43 ` Miklos Szeredi
2007-05-22 23:26 ` Shaya Potter
2007-05-23 6:39 ` Miklos Szeredi
2007-05-23 9:51 ` Al Viro
2007-05-23 10:09 ` Miklos Szeredi
2007-05-23 10:24 ` Miklos Szeredi
2007-05-23 10:24 ` Al Viro
2007-05-23 10:40 ` Miklos Szeredi
2007-05-23 11:39 ` Al Viro
2007-05-23 12:16 ` Al Viro [this message]
2007-05-23 13:01 ` Miklos Szeredi
2007-05-23 13:51 ` Al Viro
2007-05-23 14:32 ` Miklos Szeredi
2007-05-23 15:06 ` Al Viro
2007-05-23 15:25 ` Miklos Szeredi
2007-05-23 15:37 ` Al Viro
2007-05-23 15:55 ` Miklos Szeredi
2007-05-23 13:23 ` Ph. Marek
2007-05-23 13:54 ` Al Viro
2007-05-23 12:01 ` Jan Engelhardt
2007-05-23 13:20 ` Jaroslav Sykora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070523121620.GU4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox