[PATCH] x86: include: asm: Fix build warning

[PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojevic]

Fix build warnings:

error: implicit declaration of function ‘olpc_board_at_least’
[-Werror=implicit-function-declaration]

 error: implicit declaration of function ‘olpc_board’
[-Werror=implicit-function-declaration]

in files:
drivers/power/olpc_battery.c
drivers/input/mouse/hgpk.c
drivers/staging/olpc_dcon/olpc_dcon.c
arch/x86/platform/olpc/olpc.c
sound/pci/cs5535audio/cs5535audio_olpc.c

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 arch/x86/include/asm/olpc.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/x86/include/asm/olpc.h b/arch/x86/include/asm/olpc.h
index 72f9adf6..8976244 100644
--- a/arch/x86/include/asm/olpc.h
+++ b/arch/x86/include/asm/olpc.h
@@ -72,6 +72,11 @@ extern int olpc_ec_sci_query(u16 *sci_value);
 
 #else
 
+static inline uint32_t olpc_board(uint8_t id)
+{
+	return 0;
+}
+
 static inline int machine_is_olpc(void)
 {
 	return 0;
@@ -82,6 +87,11 @@ static inline int olpc_has_dcon(void)
 	return 0;
 }
 
+static inline int olpc_board_at_least(uint32_t rev)
+{
+	return 0;
+}
+
 static inline void olpc_ec_wakeup_set(u16 value) { }
 static inline void olpc_ec_wakeup_clear(u16 value) { }
 
-- 
1.9.1

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
> Fix build warnings:
> 
> error: implicit declaration of function ‘olpc_board_at_least’
> [-Werror=implicit-function-declaration]
> 
>  error: implicit declaration of function ‘olpc_board’
> [-Werror=implicit-function-declaration]

How exactly do you trigger that?

> in files:
> drivers/power/olpc_battery.c
> drivers/input/mouse/hgpk.c
> drivers/staging/olpc_dcon/olpc_dcon.c
> arch/x86/platform/olpc/olpc.c
> sound/pci/cs5535audio/cs5535audio_olpc.c

AFAICT, those should all depend on CONFIG_OLPC which defines those
functions...

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: [PATCH] x86: include: asm: Fix build warning

[H. Peter Anvin]

On 09/29/2015 10:06 AM, Borislav Petkov wrote:
> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>> Fix build warnings:
>>
>> error: implicit declaration of function ‘olpc_board_at_least’
>> [-Werror=implicit-function-declaration]
>>
>>  error: implicit declaration of function ‘olpc_board’
>> [-Werror=implicit-function-declaration]
> 
> How exactly do you trigger that?
> 
>> in files:
>> drivers/power/olpc_battery.c
>> drivers/input/mouse/hgpk.c
>> drivers/staging/olpc_dcon/olpc_dcon.c
>> arch/x86/platform/olpc/olpc.c
>> sound/pci/cs5535audio/cs5535audio_olpc.c
> 
> AFAICT, those should all depend on CONFIG_OLPC which defines those
> functions...
> 

It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
of the many problems with nonstandard hardware.

	-hpa

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

Hi,

On Tue, Sep 29, 2015 at 7:08 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 09/29/2015 10:06 AM, Borislav Petkov wrote:
>> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>>> Fix build warnings:
>>>
>>> error: implicit declaration of function ‘olpc_board_at_least’
>>> [-Werror=implicit-function-declaration]
>>>
>>>  error: implicit declaration of function ‘olpc_board’
>>> [-Werror=implicit-function-declaration]
>>
>> How exactly do you trigger that?

when building with:
make drivers/staging/oplc_dcon/olpc_dcon.o
I get this warnings.

>>
>>> in files:
>>> drivers/power/olpc_battery.c
>>> drivers/input/mouse/hgpk.c
>>> drivers/staging/olpc_dcon/olpc_dcon.c
>>> arch/x86/platform/olpc/olpc.c
>>> sound/pci/cs5535audio/cs5535audio_olpc.c
>>
>> AFAICT, those should all depend on CONFIG_OLPC which defines those
>> functions...
>>
>
> It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
> of the many problems with nonstandard hardware.
>
>         -hpa
>
>

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> when building with:
> make drivers/staging/oplc_dcon/olpc_dcon.o
> I get this warnings.

Yeah, you can't pick out single files from the source tree and try to
build them and expect that to always work. That olpc_dcon think depends
on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
enabled CONFIG_OLPC first.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
>> when building with:
>> make drivers/staging/oplc_dcon/olpc_dcon.o
>> I get this warnings.
>
> Yeah, you can't pick out single files from the source tree and try to
> build them and expect that to always work. That olpc_dcon think depends
> on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> enabled CONFIG_OLPC first.
>
Ok, thanks!

Ksenija
> --
> Regards/Gruss,
>     Boris.
>
> ECO tip #101: Trim your mails when you reply.

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:19:32PM +0200, Ksenija Stanojević wrote:
> On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov <bp@alien8.de> wrote:
> > On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> >> when building with:
> >> make drivers/staging/oplc_dcon/olpc_dcon.o
> >> I get this warnings.
> >
> > Yeah, you can't pick out single files from the source tree and try to
> > build them and expect that to always work. That olpc_dcon think depends
> > on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> > enabled CONFIG_OLPC first.
> >
> Ok, thanks!

Sure, no probs.

Btw, if you really want to try to fix some bugs, you could try to build
the kernel with

make -j<number-of-cores-on-your-machine> W=n 2>build-warnings.log

where n is 1, 2 or 3 (or any subset of those) and try to analyze them.

Look at the output in build-warnings.log and try to understand why the
compiler is complaining and whether it makes sense.

Some of them might be worth fixing. Most of them are bogus and/or fixing
them would require just too much code changes for no real gain but some
of the warnings do make sense.

Also, you could do

make allmodconfig

before that so that you can build *everything* and catch all warnings.

HTH.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.