From: Jack Allister <jalliste@amazon.com>
To: <usama.arif@bytedance.com>
Cc: <bp@alien8.de>, <corbet@lwn.net>, <dave.hansen@linux.intel.com>,
<hdegoede@redhat.com>, <hpa@zytor.com>, <jalliste@amazon.com>,
<juew@amazon.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<paulmck@kernel.org>, <pdurrant@amazon.com>,
<peterz@infradead.org>, <rafael@kernel.org>,
<rdunlap@infradead.org>, <tglx@linutronix.de>, <tj@kernel.org>,
<x86@kernel.org>, <yanjiewtw@gmail.com>
Subject: Re: [PATCH v5] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Thu, 4 Jan 2024 09:00:22 +0000 [thread overview]
Message-ID: <20240104090022.41499-1-jalliste@amazon.com> (raw)
In-Reply-To: <a57b9e19-3466-bb73-1c88-c19417ac6822@bytedance.com>
> Thanks for the patch. Is auto needed over here? It was pointed in an
> earlier review that it could be an option, but it doesn't seem to serve
> a purpose.
Auto is effectively just the default as if no parameter is passed in here.
In the reply from Dave for he has mentioned that displaying it like this
may actually be clearer.
```
intel_epb= [X86]
auto (default)
```
As we're not implicitly not taking any action for this default case it
doesn't make too much sense to add in a specific strcmp case for auto,
however what I can do is add a comment within the code to explicitly show
that this is effectively a no-op when parsing.
> Maybe add an print in else here to say that unexpected value has been
> encountered for intel_epb if preserve is not seen.
I'd be hesitant to do this as we already have the pr_warn_once during the
intel_epb_restore path when defaulting from perf -> normal.
prev parent reply other threads:[~2024-01-04 9:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:28 [PATCH] x86: intel_epb: Add earlyparam option to keep bias at performance Jack Allister
2023-12-04 17:44 ` Dave Hansen
2023-12-05 9:00 ` Durrant, Paul
2023-12-05 12:00 ` David Woodhouse
2023-12-05 12:12 ` Rafael J. Wysocki
2023-12-05 12:15 ` David Woodhouse
2023-12-05 12:31 ` Rafael J. Wysocki
2023-12-05 12:32 ` David Woodhouse
2023-12-05 12:43 ` Rafael J. Wysocki
2023-12-05 15:19 ` Dave Hansen
2023-12-05 15:27 ` Dave Hansen
2023-12-05 10:23 ` Jack Allister
2023-12-05 12:48 ` Rafael J. Wysocki
2023-12-05 13:13 ` Jack Allister
2023-12-05 13:23 ` [PATCH v3] " Jack Allister
2023-12-05 15:26 ` Dave Hansen
2023-12-05 13:30 ` [PATCH] " Rafael J. Wysocki
2023-12-05 15:14 ` [PATCH v4] " Jack Allister
2023-12-05 16:17 ` Dave Hansen
2024-01-02 14:46 ` Jack Allister
2024-01-02 15:09 ` Dave Hansen
2024-01-03 14:46 ` [PATCH v5] " Jack Allister
2024-01-03 15:17 ` Dave Hansen
2024-01-04 9:05 ` [PATCH v6] " Jack Allister
2024-01-04 9:22 ` Durrant, Paul
2024-01-03 15:18 ` [External] [PATCH v5] " Usama Arif
2024-01-04 9:00 ` Jack Allister [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104090022.41499-1-jalliste@amazon.com \
--to=jalliste@amazon.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=juew@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pdurrant@amazon.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox