public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Jack Allister <jalliste@amazon.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Paul Durrant <pdurrant@amazon.com>, Jue Wang <juew@amazon.com>,
	Usama Arif <usama.arif@bytedance.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>, Tejun Heo <tj@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Yan-Jie Wang <yanjiewtw@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Wed, 3 Jan 2024 07:17:46 -0800	[thread overview]
Message-ID: <ff3a0382-734d-4f46-bd35-ffa1f53a3ac3@intel.com> (raw)
In-Reply-To: <20240103144607.46369-1-jalliste@amazon.com>

On 1/3/24 06:46, Jack Allister wrote:
> +	intel_epb=	[X86]
> +			auto
> +			  Same as not passing a parameter to intel_epb. This will
> +			  ensure that the intel_epb module will restore the energy
> +			  performance bias to "normal" at boot-time. This workaround
> +			  is for buggy BIOSes which may not set this value and cause
> +			  either overheating or excess power usage.
> +			preserve
> +			  At kernel boot-time if the EPB value is read as "performance"
> +			  keep it at this value. This prevents the "performance" -> "normal"
> +			  transition which is a workaround mentioned above.

This ends up describing the nitty-gritty details of the implementation
instead of what users should take away from the options.  Could we up
level this a bit?

How about this?

	intel_epb=	[X86]
			
			auto (default)
				Work around buggy BIOSes to avoid
				excess power usage by forcing
				performance bias to "normal" at boot-
				time.
			
			preserve
				Do not override the existing performance
				bias setting.  Useful if a previous
				kernel or bootloader's setting is more
				desirable than "normal".

It's better formatted and uses the "(default)" tag instead of trying to
explain it in prose.  It also explains when someone might want to use
the override instead of just explaining its function.


  reply	other threads:[~2024-01-03 15:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 17:28 [PATCH] x86: intel_epb: Add earlyparam option to keep bias at performance Jack Allister
2023-12-04 17:44 ` Dave Hansen
2023-12-05  9:00   ` Durrant, Paul
2023-12-05 12:00     ` David Woodhouse
2023-12-05 12:12       ` Rafael J. Wysocki
2023-12-05 12:15         ` David Woodhouse
2023-12-05 12:31           ` Rafael J. Wysocki
2023-12-05 12:32             ` David Woodhouse
2023-12-05 12:43               ` Rafael J. Wysocki
2023-12-05 15:19         ` Dave Hansen
2023-12-05 15:27           ` Dave Hansen
2023-12-05 10:23   ` Jack Allister
2023-12-05 12:48 ` Rafael J. Wysocki
2023-12-05 13:13   ` Jack Allister
2023-12-05 13:23     ` [PATCH v3] " Jack Allister
2023-12-05 15:26       ` Dave Hansen
2023-12-05 13:30     ` [PATCH] " Rafael J. Wysocki
2023-12-05 15:14       ` [PATCH v4] " Jack Allister
2023-12-05 16:17         ` Dave Hansen
2024-01-02 14:46           ` Jack Allister
2024-01-02 15:09             ` Dave Hansen
2024-01-03 14:46               ` [PATCH v5] " Jack Allister
2024-01-03 15:17                 ` Dave Hansen [this message]
2024-01-04  9:05                   ` [PATCH v6] " Jack Allister
2024-01-04  9:22                     ` Durrant, Paul
2024-01-03 15:18                 ` [External] [PATCH v5] " Usama Arif
2024-01-04  9:00                   ` Jack Allister

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff3a0382-734d-4f46-bd35-ffa1f53a3ac3@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jalliste@amazon.com \
    --cc=juew@amazon.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=pdurrant@amazon.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=usama.arif@bytedance.com \
    --cc=x86@kernel.org \
    --cc=yanjiewtw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox