From: Dave Hansen <dave.hansen@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Cc: pdurrant@amazon.co.uk, bp@alien8.de, dave.hansen@linux.intel.com,
hdegoede@redhat.com, hpa@zytor.com, jalliste@amazon.co.uk,
juew@amazon.com, len.brown@intel.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, rafael.j.wysocki@intel.com,
tglx@linutronix.de, usama.arif@bytedance.com, x86@kernel.org
Subject: Re: [PATCH] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Tue, 5 Dec 2023 07:19:44 -0800 [thread overview]
Message-ID: <7070d14f-d35b-4b6a-9038-20dcbb984776@intel.com> (raw)
In-Reply-To: <CAJZ5v0iVvMLK_VcPRJ4sW1eOh0EtfcFvKjH5j1y1GbA0Y6q--Q@mail.gmail.com>
On 12/5/23 04:12, Rafael J. Wysocki wrote:
>> And yes, we *particularly* care in the kexec case because guests experience it as excessive steal time. But it ain't great in the general case either, surely?
> So IMV it would be perfectly fine to add a command line arg to provide
> the initial value of energy_perf_bias for the ones who know what they
> are doing.
Let's say we're on a system where the default is "normal" and the user
actually decides they want "performance"? Is that rational? Should the
command-line be more general in specifying a desired performance level
instead of just flipping the hack on and off?
We could, for instance just support this pair:
intel_epb=auto (default, will hack performance=>normal)
intel_epb=preserve (leave it alone)
for now. That would give us the existing behavior and the override that
folks want for kexec. But it would also leave open the possibility to
do things like this in the future:
intel_epb=normal (always override to normal)
intel_epb=performance (always override to performance)
next prev parent reply other threads:[~2023-12-05 15:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:28 [PATCH] x86: intel_epb: Add earlyparam option to keep bias at performance Jack Allister
2023-12-04 17:44 ` Dave Hansen
2023-12-05 9:00 ` Durrant, Paul
2023-12-05 12:00 ` David Woodhouse
2023-12-05 12:12 ` Rafael J. Wysocki
2023-12-05 12:15 ` David Woodhouse
2023-12-05 12:31 ` Rafael J. Wysocki
2023-12-05 12:32 ` David Woodhouse
2023-12-05 12:43 ` Rafael J. Wysocki
2023-12-05 15:19 ` Dave Hansen [this message]
2023-12-05 15:27 ` Dave Hansen
2023-12-05 10:23 ` Jack Allister
2023-12-05 12:48 ` Rafael J. Wysocki
2023-12-05 13:13 ` Jack Allister
2023-12-05 13:23 ` [PATCH v3] " Jack Allister
2023-12-05 15:26 ` Dave Hansen
2023-12-05 13:30 ` [PATCH] " Rafael J. Wysocki
2023-12-05 15:14 ` [PATCH v4] " Jack Allister
2023-12-05 16:17 ` Dave Hansen
2024-01-02 14:46 ` Jack Allister
2024-01-02 15:09 ` Dave Hansen
2024-01-03 14:46 ` [PATCH v5] " Jack Allister
2024-01-03 15:17 ` Dave Hansen
2024-01-04 9:05 ` [PATCH v6] " Jack Allister
2024-01-04 9:22 ` Durrant, Paul
2024-01-03 15:18 ` [External] [PATCH v5] " Usama Arif
2024-01-04 9:00 ` Jack Allister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7070d14f-d35b-4b6a-9038-20dcbb984776@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=jalliste@amazon.co.uk \
--cc=juew@amazon.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pdurrant@amazon.co.uk \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox