From: Jack Allister <jalliste@amazon.com>
To: <dave.hansen@intel.com>
Cc: <bp@alien8.de>, <dave.hansen@linux.intel.com>,
<hdegoede@redhat.com>, <hpa@zytor.com>, <jalliste@amazon.com>,
<juew@amazon.com>, <len.brown@intel.com>,
<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<pdurrant@amazon.com>, <peterz@infradead.org>,
<rafael.j.wysocki@intel.com>, <rafael@kernel.org>,
<tglx@linutronix.de>, <usama.arif@bytedance.com>,
<x86@kernel.org>
Subject: Re: [PATCH v4] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Tue, 2 Jan 2024 14:46:46 +0000 [thread overview]
Message-ID: <20240102144646.44355-1-jalliste@amazon.com> (raw)
In-Reply-To: <bcd1b113-94b7-41a9-a3f6-fde1dd54fc74@intel.com>
> Jack, I'd really appreciate if you could please slow down.
I'm sorry about this, I'm still extremely unfamiliar with the open-sourcing conventions/
workflow when working with mailing lists & the upstreaming to the Linux kernel. I have
taken this feedback & have started to look through the maintainer tips & docs for
guidance.
Also sorry for the delay in actual response here too, general work responsibilities & the
holiday period has had an affect here.
Before I go ahead with posting up a revision 5 with all of your queries/suggestions I do
have a few questions I'd just like to clarify.
> We could, for instance just support this pair:
> intel_epb=auto (default, will hack performance=>normal)
> intel_epb=preserve (leave it alone)
With the suggestion above you mentioned implementing this, if this was to be implemented
do you think keeping it `intel_epb_restore_default` as a bool is still worth it? e.g:
```
static __init int intel_epb_no_override_setup(char *str)
{
if (!str)
return 0;
if (!strcmp(str, "preserve"))
intel_epb_no_override = true;
```
Or do you think it would be worth actually removing `intel_epb_no_override` and creating
a module variable `intel_epb_restore_default` which is an enum of the performance values.
Doing so would then allow for expansability in the future which you had already alluded to
e.g setting to other values such as EPB_INDEX_BALANCE_POWERSAVE/PERFORMANCE.
next prev parent reply other threads:[~2024-01-02 14:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:28 [PATCH] x86: intel_epb: Add earlyparam option to keep bias at performance Jack Allister
2023-12-04 17:44 ` Dave Hansen
2023-12-05 9:00 ` Durrant, Paul
2023-12-05 12:00 ` David Woodhouse
2023-12-05 12:12 ` Rafael J. Wysocki
2023-12-05 12:15 ` David Woodhouse
2023-12-05 12:31 ` Rafael J. Wysocki
2023-12-05 12:32 ` David Woodhouse
2023-12-05 12:43 ` Rafael J. Wysocki
2023-12-05 15:19 ` Dave Hansen
2023-12-05 15:27 ` Dave Hansen
2023-12-05 10:23 ` Jack Allister
2023-12-05 12:48 ` Rafael J. Wysocki
2023-12-05 13:13 ` Jack Allister
2023-12-05 13:23 ` [PATCH v3] " Jack Allister
2023-12-05 15:26 ` Dave Hansen
2023-12-05 13:30 ` [PATCH] " Rafael J. Wysocki
2023-12-05 15:14 ` [PATCH v4] " Jack Allister
2023-12-05 16:17 ` Dave Hansen
2024-01-02 14:46 ` Jack Allister [this message]
2024-01-02 15:09 ` Dave Hansen
2024-01-03 14:46 ` [PATCH v5] " Jack Allister
2024-01-03 15:17 ` Dave Hansen
2024-01-04 9:05 ` [PATCH v6] " Jack Allister
2024-01-04 9:22 ` Durrant, Paul
2024-01-03 15:18 ` [External] [PATCH v5] " Usama Arif
2024-01-04 9:00 ` Jack Allister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102144646.44355-1-jalliste@amazon.com \
--to=jalliste@amazon.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=juew@amazon.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pdurrant@amazon.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox