From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org,
mark.rutland@arm.com, torvalds@linuxfoundation.org
Subject: [RFC 4/8] bug: Allow architectures to provide __WARN_printf()
Date: Mon, 02 Jun 2025 16:42:05 +0200 [thread overview]
Message-ID: <20250602144755.697777039@infradead.org> (raw)
In-Reply-To: 20250602144201.301974933@infradead.org
Instead of providing __WARN_FLAGS(), allow an architecture to provide
__WARN_printf(), which allows for optimizing WARN(), rather than
WARN_ON().
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/asm-generic/bug.h | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -94,14 +94,7 @@ void warn_slowpath_fmt(const char *file,
const char *fmt, ...);
extern __printf(1, 2) void __warn_printk(const char *fmt, ...);
-#ifndef __WARN_FLAGS
-#define __WARN() __WARN_printf(TAINT_WARN, NULL)
-#define __WARN_printf(taint, arg...) do { \
- instrumentation_begin(); \
- warn_slowpath_fmt(__FILE__, __LINE__, taint, arg); \
- instrumentation_end(); \
- } while (0)
-#else
+#if defined(__WARN_FLAGS) && !defined(__WARN_printf)
#define __WARN() __WARN_FLAGS(BUGFLAG_TAINT(TAINT_WARN))
#define __WARN_printf(taint, arg...) do { \
instrumentation_begin(); \
@@ -118,6 +111,18 @@ extern __printf(1, 2) void __warn_printk
})
#endif
+#ifndef __WARN_printf
+#define __WARN_printf(taint, arg...) do { \
+ instrumentation_begin(); \
+ warn_slowpath_fmt(__FILE__, __LINE__, taint, arg); \
+ instrumentation_end(); \
+ } while (0)
+#endif
+
+#ifndef __WARN
+#define __WARN() __WARN_printf(TAINT_WARN, NULL)
+#endif
+
/* used internally by panic.c */
#ifndef WARN_ON
next prev parent reply other threads:[~2025-06-02 14:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 14:42 [RFC 0/8] x86: Mad WARN() hackery Peter Zijlstra
2025-06-02 14:42 ` [RFC 1/8] x86: Provide assembly __bug_table helpers Peter Zijlstra
2025-06-02 14:42 ` [RFC 2/8] bug: Add BUGFLAG_FORMAT infrastructure Peter Zijlstra
2025-06-02 14:42 ` [RFC 3/8] bug: Clean up CONFIG_GENERIC_BUG_RELATIVE_POINTERS Peter Zijlstra
2025-06-02 14:42 ` Peter Zijlstra [this message]
2025-06-02 14:42 ` [RFC 5/8] x86_64/bug: Add BUG_FORMAT basics Peter Zijlstra
2025-06-02 14:42 ` [RFC 6/8] x86_64/bug: Implement __WARN_printf() Peter Zijlstra
2025-06-02 15:02 ` Linus Torvalds
2025-06-02 15:49 ` Peter Zijlstra
2025-06-02 16:38 ` Linus Torvalds
2025-06-02 18:09 ` Peter Zijlstra
2025-06-02 20:04 ` Josh Poimboeuf
2025-06-02 20:16 ` Josh Poimboeuf
2025-06-02 20:33 ` Andrew Cooper
2025-06-02 21:57 ` Peter Zijlstra
2025-06-02 22:01 ` Peter Zijlstra
2025-06-02 23:10 ` Linus Torvalds
2025-06-03 13:04 ` Peter Zijlstra
2025-06-03 22:23 ` David Laight
2025-06-02 14:42 ` [RFC 7/8] x86/bug: Implement WARN_ONCE() Peter Zijlstra
2025-06-02 14:42 ` [RFC 8/8] x86: Clean up default rethunk warning Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602144755.697777039@infradead.org \
--to=peterz@infradead.org \
--cc=acarmina@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=torvalds@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox