public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org,
	mark.rutland@arm.com, torvalds@linuxfoundation.org
Subject: [RFC 7/8] x86/bug: Implement WARN_ONCE()
Date: Mon, 02 Jun 2025 16:42:08 +0200	[thread overview]
Message-ID: <20250602144756.054408110@infradead.org> (raw)
In-Reply-To: 20250602144201.301974933@infradead.org

Implement WARN_ONCE like WARN using BUGFLAG_ONCE.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/include/asm/bug.h |   28 ++++++++++++++++++++++++++++
 include/asm-generic/bug.h  |    2 ++
 2 files changed, 30 insertions(+)

--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -221,6 +221,34 @@ do {									\
 #define __WARN_printf(taint, fmt, arg...) \
 	CONCATENATE(__WARN_printf_, WARN_ARGS(arg))(BUGFLAG_TAINT(taint), fmt, ## arg)
 
+#define __WONCE_printf_0(flags, format) \
+	__WARN_printf_0(flags|BUGFLAG_ONCE, format)
+
+#define __WONCE_printf_1(flags, format, arg1) \
+	__WARN_printf_1(flags|BUGFLAG_ONCE, format, arg1)
+
+#define __WONCE_printf_2(flags, format, arg1, arg2) \
+	__WARN_printf_2(flags|BUGFLAG_ONCE, format, arg1, arg2)
+
+#define __WONCE_printf_3(flags, format, arg1, arg2, arg3) \
+	__WARN_printf_3(flags|BUGFLAG_ONCE, format, arg1, arg2, arg3)
+
+#define __WONCE_printf_n(flags, format, arg...) \
+	if (__ONCE_LITE_IF(true)) __WARN_printf_n(flags, format, arg)
+
+#define _WARN_ONCE(cond, format, arg...) ({				\
+	int __ret_warn_on = !!(cond);					\
+	if (unlikely(__ret_warn_on)) {					\
+		CONCATENATE(__WONCE_printf_, WARN_ARGS(arg))(0, format, ## arg); \
+	}								\
+	__ret_warn_on;							\
+})
+
+/*
+ * Make sure WARN_ONCE() arguments get expanded before trying to count them.
+ */
+#define WARN_ONCE(cond, format...) _WARN_ONCE(cond, format)
+
 #endif /* HAVE_ARCH_BUG_FORMAT */
 
 #include <asm-generic/bug.h>
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -155,8 +155,10 @@ extern __printf(1, 2) void __warn_printk
 	DO_ONCE_LITE_IF(condition, WARN_ON, 1)
 #endif
 
+#ifndef WARN_ONCE
 #define WARN_ONCE(condition, format...)				\
 	DO_ONCE_LITE_IF(condition, WARN, 1, format)
+#endif
 
 #define WARN_TAINT_ONCE(condition, taint, format...)		\
 	DO_ONCE_LITE_IF(condition, WARN_TAINT, 1, taint, format)



  parent reply	other threads:[~2025-06-02 14:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 14:42 [RFC 0/8] x86: Mad WARN() hackery Peter Zijlstra
2025-06-02 14:42 ` [RFC 1/8] x86: Provide assembly __bug_table helpers Peter Zijlstra
2025-06-02 14:42 ` [RFC 2/8] bug: Add BUGFLAG_FORMAT infrastructure Peter Zijlstra
2025-06-02 14:42 ` [RFC 3/8] bug: Clean up CONFIG_GENERIC_BUG_RELATIVE_POINTERS Peter Zijlstra
2025-06-02 14:42 ` [RFC 4/8] bug: Allow architectures to provide __WARN_printf() Peter Zijlstra
2025-06-02 14:42 ` [RFC 5/8] x86_64/bug: Add BUG_FORMAT basics Peter Zijlstra
2025-06-02 14:42 ` [RFC 6/8] x86_64/bug: Implement __WARN_printf() Peter Zijlstra
2025-06-02 15:02   ` Linus Torvalds
2025-06-02 15:49     ` Peter Zijlstra
2025-06-02 16:38       ` Linus Torvalds
2025-06-02 18:09         ` Peter Zijlstra
2025-06-02 20:04           ` Josh Poimboeuf
2025-06-02 20:16           ` Josh Poimboeuf
2025-06-02 20:33             ` Andrew Cooper
2025-06-02 21:57         ` Peter Zijlstra
2025-06-02 22:01           ` Peter Zijlstra
2025-06-02 23:10           ` Linus Torvalds
2025-06-03 13:04             ` Peter Zijlstra
2025-06-03 22:23               ` David Laight
2025-06-02 14:42 ` Peter Zijlstra [this message]
2025-06-02 14:42 ` [RFC 8/8] x86: Clean up default rethunk warning Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602144756.054408110@infradead.org \
    --to=peterz@infradead.org \
    --cc=acarmina@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=torvalds@linuxfoundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox