From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org,
acarmina@redhat.com, jpoimboe@kernel.org, mark.rutland@arm.com
Subject: Re: [RFC 6/8] x86_64/bug: Implement __WARN_printf()
Date: Mon, 2 Jun 2025 23:57:25 +0200 [thread overview]
Message-ID: <20250602215725.GA39782@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHk-=wiYHv2duN1Aj3E5UD3zH=z6A9YpGJ1Mxj_CWL7_FRMKgw@mail.gmail.com>
On Mon, Jun 02, 2025 at 09:38:09AM -0700, Linus Torvalds wrote:
> And no, I'm not ok with only using 'objdump' and friends to look at
> assembly generation. I want to be able to do
>
> make xyz.s
>
> and look at code generation without throwing up.
So if I stuff the asm macro in a global asm() block then GCC ends up
looking like so:
.set warn_imm, 0
warn_add_reg var=warn_imm reg=%rcx # tmp215
.set warn_imm, (warn_imm << 4)
warn_add_reg var=warn_imm reg=%rdx # tmp212
1: ud1 warn_imm(%ecx),%rax # tmp210
.pushsection .discard.annotate_insn,"M",@progbits,8
.long 1b - .
.long 8
.popsection
.pushsection __bug_table, "aw" ; 123: .long 1b - . ; .long .LC76 - . ; .long .LC0 - . ; .word 8710 ; .word 2321 ; .org 123b + 6 + 4 + 6 ; .popsection #,,,
However, clangd is 'helpful' and fully expands the asm macro for the .s
file :-(
next prev parent reply other threads:[~2025-06-02 21:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 14:42 [RFC 0/8] x86: Mad WARN() hackery Peter Zijlstra
2025-06-02 14:42 ` [RFC 1/8] x86: Provide assembly __bug_table helpers Peter Zijlstra
2025-06-02 14:42 ` [RFC 2/8] bug: Add BUGFLAG_FORMAT infrastructure Peter Zijlstra
2025-06-02 14:42 ` [RFC 3/8] bug: Clean up CONFIG_GENERIC_BUG_RELATIVE_POINTERS Peter Zijlstra
2025-06-02 14:42 ` [RFC 4/8] bug: Allow architectures to provide __WARN_printf() Peter Zijlstra
2025-06-02 14:42 ` [RFC 5/8] x86_64/bug: Add BUG_FORMAT basics Peter Zijlstra
2025-06-02 14:42 ` [RFC 6/8] x86_64/bug: Implement __WARN_printf() Peter Zijlstra
2025-06-02 15:02 ` Linus Torvalds
2025-06-02 15:49 ` Peter Zijlstra
2025-06-02 16:38 ` Linus Torvalds
2025-06-02 18:09 ` Peter Zijlstra
2025-06-02 20:04 ` Josh Poimboeuf
2025-06-02 20:16 ` Josh Poimboeuf
2025-06-02 20:33 ` Andrew Cooper
2025-06-02 21:57 ` Peter Zijlstra [this message]
2025-06-02 22:01 ` Peter Zijlstra
2025-06-02 23:10 ` Linus Torvalds
2025-06-03 13:04 ` Peter Zijlstra
2025-06-03 22:23 ` David Laight
2025-06-02 14:42 ` [RFC 7/8] x86/bug: Implement WARN_ONCE() Peter Zijlstra
2025-06-02 14:42 ` [RFC 8/8] x86: Clean up default rethunk warning Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602215725.GA39782@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acarmina@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=torvalds@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox