* [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
@ 2026-07-12 14:19 Dylan Liu
2026-07-12 14:25 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Dylan Liu @ 2026-07-12 14:19 UTC (permalink / raw)
Cc: Dylan Liu, Nuno Sá, Michael Hennerich, Jonathan Cameron,
David Lechner, Andy Shevchenko, Greg Kroah-Hartman, linux,
linux-iio, linux-staging, linux-kernel
staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
Fix multiple checkpatch.pl warnings complaining about CamelCase
variable and function names.
In order to comply with standard Linux coding style and IIO ABI
conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
in the adt7316 driver to lowercase snake_case.
Note that this patch changes the sysfs ABI for this driver, as
the device attributes exposed to userspace are now lowercase
(e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
necessary to bring the staging driver in line with the official
IIO ABI.
Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
---
drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
1 file changed, 114 insertions(+), 114 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 59fb3bd26bc1..845d79591128 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
adt7316_store_da_high_resolution,
0);
-static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
+static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -677,7 +677,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
!!(chip->config3 & ADT7516_AIN_IN_VREF));
}
-static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
+static ssize_t adt7316_store_ain_internal_vref(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -704,12 +704,12 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
- adt7316_show_AIN_internal_Vref,
- adt7316_store_AIN_internal_Vref,
+static IIO_DEVICE_ATTR(ain_internal_vref, 0644,
+ adt7316_show_ain_internal_vref,
+ adt7316_store_ain_internal_vref,
0);
-static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,
+static ssize_t adt7316_show_enable_prop_daca(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -720,7 +720,7 @@ static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,
!!(chip->config3 & ADT7316_EN_IN_TEMP_PROP_DACA));
}
-static ssize_t adt7316_store_enable_prop_DACA(struct device *dev,
+static ssize_t adt7316_store_enable_prop_daca(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -743,12 +743,12 @@ static ssize_t adt7316_store_enable_prop_DACA(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(enable_proportion_DACA, 0644,
- adt7316_show_enable_prop_DACA,
- adt7316_store_enable_prop_DACA,
+static IIO_DEVICE_ATTR(enable_proportion_daca, 0644,
+ adt7316_show_enable_prop_daca,
+ adt7316_store_enable_prop_daca,
0);
-static ssize_t adt7316_show_enable_prop_DACB(struct device *dev,
+static ssize_t adt7316_show_enable_prop_dacb(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -759,7 +759,7 @@ static ssize_t adt7316_show_enable_prop_DACB(struct device *dev,
!!(chip->config3 & ADT7316_EN_EX_TEMP_PROP_DACB));
}
-static ssize_t adt7316_store_enable_prop_DACB(struct device *dev,
+static ssize_t adt7316_store_enable_prop_dacb(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -782,12 +782,12 @@ static ssize_t adt7316_store_enable_prop_DACB(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(enable_proportion_DACB, 0644,
- adt7316_show_enable_prop_DACB,
- adt7316_store_enable_prop_DACB,
+static IIO_DEVICE_ATTR(enable_proportion_dacb, 0644,
+ adt7316_show_enable_prop_dacb,
+ adt7316_store_enable_prop_dacb,
0);
-static ssize_t adt7316_show_DAC_2Vref_ch_mask(struct device *dev,
+static ssize_t adt7316_show_dac_2vref_ch_mask(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -798,7 +798,7 @@ static ssize_t adt7316_show_DAC_2Vref_ch_mask(struct device *dev,
chip->dac_config & ADT7316_DA_2VREF_CH_MASK);
}
-static ssize_t adt7316_store_DAC_2Vref_ch_mask(struct device *dev,
+static ssize_t adt7316_store_dac_2vref_ch_mask(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -825,12 +825,12 @@ static ssize_t adt7316_store_DAC_2Vref_ch_mask(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(DAC_2Vref_channels_mask, 0644,
- adt7316_show_DAC_2Vref_ch_mask,
- adt7316_store_DAC_2Vref_ch_mask,
+static IIO_DEVICE_ATTR(dac_2vref_channels_mask, 0644,
+ adt7316_show_dac_2vref_ch_mask,
+ adt7316_store_dac_2vref_ch_mask,
0);
-static ssize_t adt7316_show_DAC_update_mode(struct device *dev,
+static ssize_t adt7316_show_dac_update_mode(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -855,7 +855,7 @@ static ssize_t adt7316_show_DAC_update_mode(struct device *dev,
}
}
-static ssize_t adt7316_store_DAC_update_mode(struct device *dev,
+static ssize_t adt7316_store_dac_update_mode(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -885,12 +885,12 @@ static ssize_t adt7316_store_DAC_update_mode(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(DAC_update_mode, 0644,
- adt7316_show_DAC_update_mode,
- adt7316_store_DAC_update_mode,
+static IIO_DEVICE_ATTR(dac_update_mode, 0644,
+ adt7316_show_dac_update_mode,
+ adt7316_store_dac_update_mode,
0);
-static ssize_t adt7316_show_all_DAC_update_modes(struct device *dev,
+static ssize_t adt7316_show_all_dac_update_modes(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -905,10 +905,10 @@ static ssize_t adt7316_show_all_DAC_update_modes(struct device *dev,
return sysfs_emit(buf, "manual\n");
}
-static IIO_DEVICE_ATTR(all_DAC_update_modes, 0444,
- adt7316_show_all_DAC_update_modes, NULL, 0);
+static IIO_DEVICE_ATTR(all_dac_update_modes, 0444,
+ adt7316_show_all_dac_update_modes, NULL, 0);
-static ssize_t adt7316_store_update_DAC(struct device *dev,
+static ssize_t adt7316_store_update_dac(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -943,12 +943,12 @@ static ssize_t adt7316_store_update_DAC(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(update_DAC, 0644,
+static IIO_DEVICE_ATTR(update_dac, 0644,
NULL,
- adt7316_store_update_DAC,
+ adt7316_store_update_dac,
0);
-static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
+static ssize_t adt7316_show_da_ab_vref_bypass(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -959,7 +959,7 @@ static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_AB));
}
-static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
+static ssize_t adt7316_store_da_ab_vref_bypass(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -982,12 +982,12 @@ static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(DA_AB_Vref_bypass, 0644,
- adt7316_show_DA_AB_Vref_bypass,
- adt7316_store_DA_AB_Vref_bypass,
+static IIO_DEVICE_ATTR(da_ab_vref_bypass, 0644,
+ adt7316_show_da_ab_vref_bypass,
+ adt7316_store_da_ab_vref_bypass,
0);
-static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
+static ssize_t adt7316_show_da_cd_vref_bypass(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -998,7 +998,7 @@ static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_CD));
}
-static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
+static ssize_t adt7316_store_da_cd_vref_bypass(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1021,12 +1021,12 @@ static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(DA_CD_Vref_bypass, 0644,
- adt7316_show_DA_CD_Vref_bypass,
- adt7316_store_DA_CD_Vref_bypass,
+static IIO_DEVICE_ATTR(da_cd_vref_bypass, 0644,
+ adt7316_show_da_cd_vref_bypass,
+ adt7316_store_da_cd_vref_bypass,
0);
-static ssize_t adt7316_show_DAC_internal_Vref(struct device *dev,
+static ssize_t adt7316_show_dac_internal_vref(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1041,7 +1041,7 @@ static ssize_t adt7316_show_DAC_internal_Vref(struct device *dev,
!!(chip->ldac_config & ADT7316_DAC_IN_VREF));
}
-static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
+static ssize_t adt7316_store_dac_internal_vref(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1082,9 +1082,9 @@ static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
return len;
}
-static IIO_DEVICE_ATTR(DAC_internal_Vref, 0644,
- adt7316_show_DAC_internal_Vref,
- adt7316_store_DAC_internal_Vref,
+static IIO_DEVICE_ATTR(dac_internal_vref, 0644,
+ adt7316_show_dac_internal_vref,
+ adt7316_store_dac_internal_vref,
0);
static ssize_t adt7316_show_ad(struct adt7316_chip_info *chip,
@@ -1162,7 +1162,7 @@ static ssize_t adt7316_show_ad(struct adt7316_chip_info *chip,
(data & ADT7316_T_VALUE_FLOAT_MASK) * 25);
}
-static ssize_t adt7316_show_VDD(struct device *dev,
+static ssize_t adt7316_show_vdd(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1171,7 +1171,7 @@ static ssize_t adt7316_show_VDD(struct device *dev,
return adt7316_show_ad(chip, ADT7316_AD_SINGLE_CH_VDD, buf);
}
-static IIO_DEVICE_ATTR(VDD, 0444, adt7316_show_VDD, NULL, 0);
+static IIO_DEVICE_ATTR(vdd, 0444, adt7316_show_vdd, NULL, 0);
static ssize_t adt7316_show_in_temp(struct device *dev,
struct device_attribute *attr,
@@ -1185,7 +1185,7 @@ static ssize_t adt7316_show_in_temp(struct device *dev,
static IIO_DEVICE_ATTR(in_temp, 0444, adt7316_show_in_temp, NULL, 0);
-static ssize_t adt7316_show_ex_temp_AIN1(struct device *dev,
+static ssize_t adt7316_show_ex_temp_ain1(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1195,11 +1195,11 @@ static ssize_t adt7316_show_ex_temp_AIN1(struct device *dev,
return adt7316_show_ad(chip, ADT7316_AD_SINGLE_CH_EX, buf);
}
-static IIO_DEVICE_ATTR(ex_temp_AIN1, 0444, adt7316_show_ex_temp_AIN1,
+static IIO_DEVICE_ATTR(ex_temp_ain1, 0444, adt7316_show_ex_temp_ain1,
NULL, 0);
-static IIO_DEVICE_ATTR(ex_temp, 0444, adt7316_show_ex_temp_AIN1, NULL, 0);
+static IIO_DEVICE_ATTR(ex_temp, 0444, adt7316_show_ex_temp_ain1, NULL, 0);
-static ssize_t adt7316_show_AIN2(struct device *dev,
+static ssize_t adt7316_show_ain2(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1208,9 +1208,9 @@ static ssize_t adt7316_show_AIN2(struct device *dev,
return adt7316_show_ad(chip, ADT7516_AD_SINGLE_CH_AIN2, buf);
}
-static IIO_DEVICE_ATTR(AIN2, 0444, adt7316_show_AIN2, NULL, 0);
+static IIO_DEVICE_ATTR(ain2, 0444, adt7316_show_ain2, NULL, 0);
-static ssize_t adt7316_show_AIN3(struct device *dev,
+static ssize_t adt7316_show_ain3(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1219,9 +1219,9 @@ static ssize_t adt7316_show_AIN3(struct device *dev,
return adt7316_show_ad(chip, ADT7516_AD_SINGLE_CH_AIN3, buf);
}
-static IIO_DEVICE_ATTR(AIN3, 0444, adt7316_show_AIN3, NULL, 0);
+static IIO_DEVICE_ATTR(ain3, 0444, adt7316_show_ain3, NULL, 0);
-static ssize_t adt7316_show_AIN4(struct device *dev,
+static ssize_t adt7316_show_ain4(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1230,7 +1230,7 @@ static ssize_t adt7316_show_AIN4(struct device *dev,
return adt7316_show_ad(chip, ADT7516_AD_SINGLE_CH_AIN4, buf);
}
-static IIO_DEVICE_ATTR(AIN4, 0444, adt7316_show_AIN4, NULL, 0);
+static IIO_DEVICE_ATTR(ain4, 0444, adt7316_show_ain4, NULL, 0);
static ssize_t adt7316_show_temp_offset(struct adt7316_chip_info *chip,
int offset_addr, char *buf)
@@ -1381,7 +1381,7 @@ static IIO_DEVICE_ATTR(ex_analog_temp_offset, 0644,
adt7316_show_ex_analog_temp_offset,
adt7316_store_ex_analog_temp_offset, 0);
-static ssize_t adt7316_show_DAC(struct adt7316_chip_info *chip,
+static ssize_t adt7316_show_dac(struct adt7316_chip_info *chip,
int channel, char *buf)
{
u16 data = 0;
@@ -1418,7 +1418,7 @@ static ssize_t adt7316_show_DAC(struct adt7316_chip_info *chip,
return sysfs_emit(buf, "%d\n", data);
}
-static ssize_t adt7316_store_DAC(struct adt7316_chip_info *chip,
+static ssize_t adt7316_store_dac(struct adt7316_chip_info *chip,
int channel, const char *buf, size_t len)
{
u8 msb, lsb, lsb_reg, offset;
@@ -1459,17 +1459,17 @@ static ssize_t adt7316_store_DAC(struct adt7316_chip_info *chip,
return len;
}
-static ssize_t adt7316_show_DAC_A(struct device *dev,
+static ssize_t adt7316_show_dac_a(struct device *dev,
struct device_attribute *attr,
char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_show_DAC(chip, 0, buf);
+ return adt7316_show_dac(chip, 0, buf);
}
-static ssize_t adt7316_store_DAC_A(struct device *dev,
+static ssize_t adt7316_store_dac_a(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1477,23 +1477,23 @@ static ssize_t adt7316_store_DAC_A(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_store_DAC(chip, 0, buf, len);
+ return adt7316_store_dac(chip, 0, buf, len);
}
-static IIO_DEVICE_ATTR(DAC_A, 0644, adt7316_show_DAC_A,
- adt7316_store_DAC_A, 0);
+static IIO_DEVICE_ATTR(dac_a, 0644, adt7316_show_dac_a,
+ adt7316_store_dac_a, 0);
-static ssize_t adt7316_show_DAC_B(struct device *dev,
+static ssize_t adt7316_show_dac_b(struct device *dev,
struct device_attribute *attr,
char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_show_DAC(chip, 1, buf);
+ return adt7316_show_dac(chip, 1, buf);
}
-static ssize_t adt7316_store_DAC_B(struct device *dev,
+static ssize_t adt7316_store_dac_b(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1501,23 +1501,23 @@ static ssize_t adt7316_store_DAC_B(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_store_DAC(chip, 1, buf, len);
+ return adt7316_store_dac(chip, 1, buf, len);
}
-static IIO_DEVICE_ATTR(DAC_B, 0644, adt7316_show_DAC_B,
- adt7316_store_DAC_B, 0);
+static IIO_DEVICE_ATTR(dac_b, 0644, adt7316_show_dac_b,
+ adt7316_store_dac_b, 0);
-static ssize_t adt7316_show_DAC_C(struct device *dev,
+static ssize_t adt7316_show_dac_c(struct device *dev,
struct device_attribute *attr,
char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_show_DAC(chip, 2, buf);
+ return adt7316_show_dac(chip, 2, buf);
}
-static ssize_t adt7316_store_DAC_C(struct device *dev,
+static ssize_t adt7316_store_dac_c(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1525,23 +1525,23 @@ static ssize_t adt7316_store_DAC_C(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_store_DAC(chip, 2, buf, len);
+ return adt7316_store_dac(chip, 2, buf, len);
}
-static IIO_DEVICE_ATTR(DAC_C, 0644, adt7316_show_DAC_C,
- adt7316_store_DAC_C, 0);
+static IIO_DEVICE_ATTR(dac_c, 0644, adt7316_show_dac_c,
+ adt7316_store_dac_c, 0);
-static ssize_t adt7316_show_DAC_D(struct device *dev,
+static ssize_t adt7316_show_dac_d(struct device *dev,
struct device_attribute *attr,
char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_show_DAC(chip, 3, buf);
+ return adt7316_show_dac(chip, 3, buf);
}
-static ssize_t adt7316_store_DAC_D(struct device *dev,
+static ssize_t adt7316_store_dac_d(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1549,11 +1549,11 @@ static ssize_t adt7316_store_DAC_D(struct device *dev,
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
- return adt7316_store_DAC(chip, 3, buf, len);
+ return adt7316_store_dac(chip, 3, buf, len);
}
-static IIO_DEVICE_ATTR(DAC_D, 0644, adt7316_show_DAC_D,
- adt7316_store_DAC_D, 0);
+static IIO_DEVICE_ATTR(dac_d, 0644, adt7316_show_dac_d,
+ adt7316_store_dac_d, 0);
static ssize_t adt7316_show_device_id(struct device *dev,
struct device_attribute *attr,
@@ -1642,26 +1642,26 @@ static struct attribute *adt7316_attributes[] = {
&iio_dev_attr_powerdown.dev_attr.attr,
&iio_dev_attr_fast_ad_clock.dev_attr.attr,
&iio_dev_attr_da_high_resolution.dev_attr.attr,
- &iio_dev_attr_enable_proportion_DACA.dev_attr.attr,
- &iio_dev_attr_enable_proportion_DACB.dev_attr.attr,
- &iio_dev_attr_DAC_2Vref_channels_mask.dev_attr.attr,
- &iio_dev_attr_DAC_update_mode.dev_attr.attr,
- &iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
- &iio_dev_attr_update_DAC.dev_attr.attr,
- &iio_dev_attr_DA_AB_Vref_bypass.dev_attr.attr,
- &iio_dev_attr_DA_CD_Vref_bypass.dev_attr.attr,
- &iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
- &iio_dev_attr_VDD.dev_attr.attr,
+ &iio_dev_attr_enable_proportion_daca.dev_attr.attr,
+ &iio_dev_attr_enable_proportion_dacb.dev_attr.attr,
+ &iio_dev_attr_dac_2vref_channels_mask.dev_attr.attr,
+ &iio_dev_attr_dac_update_mode.dev_attr.attr,
+ &iio_dev_attr_all_dac_update_modes.dev_attr.attr,
+ &iio_dev_attr_update_dac.dev_attr.attr,
+ &iio_dev_attr_da_ab_vref_bypass.dev_attr.attr,
+ &iio_dev_attr_da_cd_vref_bypass.dev_attr.attr,
+ &iio_dev_attr_dac_internal_vref.dev_attr.attr,
+ &iio_dev_attr_vdd.dev_attr.attr,
&iio_dev_attr_in_temp.dev_attr.attr,
&iio_dev_attr_ex_temp.dev_attr.attr,
&iio_dev_attr_in_temp_offset.dev_attr.attr,
&iio_dev_attr_ex_temp_offset.dev_attr.attr,
&iio_dev_attr_in_analog_temp_offset.dev_attr.attr,
&iio_dev_attr_ex_analog_temp_offset.dev_attr.attr,
- &iio_dev_attr_DAC_A.dev_attr.attr,
- &iio_dev_attr_DAC_B.dev_attr.attr,
- &iio_dev_attr_DAC_C.dev_attr.attr,
- &iio_dev_attr_DAC_D.dev_attr.attr,
+ &iio_dev_attr_dac_a.dev_attr.attr,
+ &iio_dev_attr_dac_b.dev_attr.attr,
+ &iio_dev_attr_dac_c.dev_attr.attr,
+ &iio_dev_attr_dac_d.dev_attr.attr,
&iio_dev_attr_device_id.dev_attr.attr,
&iio_dev_attr_manufactorer_id.dev_attr.attr,
&iio_dev_attr_device_rev.dev_attr.attr,
@@ -1684,29 +1684,29 @@ static struct attribute *adt7516_attributes[] = {
&iio_dev_attr_enable_smbus_timeout.dev_attr.attr,
&iio_dev_attr_powerdown.dev_attr.attr,
&iio_dev_attr_fast_ad_clock.dev_attr.attr,
- &iio_dev_attr_AIN_internal_Vref.dev_attr.attr,
+ &iio_dev_attr_ain_internal_vref.dev_attr.attr,
&iio_dev_attr_da_high_resolution.dev_attr.attr,
- &iio_dev_attr_enable_proportion_DACA.dev_attr.attr,
- &iio_dev_attr_enable_proportion_DACB.dev_attr.attr,
- &iio_dev_attr_DAC_2Vref_channels_mask.dev_attr.attr,
- &iio_dev_attr_DAC_update_mode.dev_attr.attr,
- &iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
- &iio_dev_attr_update_DAC.dev_attr.attr,
- &iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
- &iio_dev_attr_VDD.dev_attr.attr,
+ &iio_dev_attr_enable_proportion_daca.dev_attr.attr,
+ &iio_dev_attr_enable_proportion_dacb.dev_attr.attr,
+ &iio_dev_attr_dac_2vref_channels_mask.dev_attr.attr,
+ &iio_dev_attr_dac_update_mode.dev_attr.attr,
+ &iio_dev_attr_all_dac_update_modes.dev_attr.attr,
+ &iio_dev_attr_update_dac.dev_attr.attr,
+ &iio_dev_attr_dac_internal_vref.dev_attr.attr,
+ &iio_dev_attr_vdd.dev_attr.attr,
&iio_dev_attr_in_temp.dev_attr.attr,
- &iio_dev_attr_ex_temp_AIN1.dev_attr.attr,
- &iio_dev_attr_AIN2.dev_attr.attr,
- &iio_dev_attr_AIN3.dev_attr.attr,
- &iio_dev_attr_AIN4.dev_attr.attr,
+ &iio_dev_attr_ex_temp_ain1.dev_attr.attr,
+ &iio_dev_attr_ain2.dev_attr.attr,
+ &iio_dev_attr_ain3.dev_attr.attr,
+ &iio_dev_attr_ain4.dev_attr.attr,
&iio_dev_attr_in_temp_offset.dev_attr.attr,
&iio_dev_attr_ex_temp_offset.dev_attr.attr,
&iio_dev_attr_in_analog_temp_offset.dev_attr.attr,
&iio_dev_attr_ex_analog_temp_offset.dev_attr.attr,
- &iio_dev_attr_DAC_A.dev_attr.attr,
- &iio_dev_attr_DAC_B.dev_attr.attr,
- &iio_dev_attr_DAC_C.dev_attr.attr,
- &iio_dev_attr_DAC_D.dev_attr.attr,
+ &iio_dev_attr_dac_a.dev_attr.attr,
+ &iio_dev_attr_dac_b.dev_attr.attr,
+ &iio_dev_attr_dac_c.dev_attr.attr,
+ &iio_dev_attr_dac_d.dev_attr.attr,
&iio_dev_attr_device_id.dev_attr.attr,
&iio_dev_attr_manufactorer_id.dev_attr.attr,
&iio_dev_attr_device_rev.dev_attr.attr,
--
2.54.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 14:19 [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com> Dylan Liu
@ 2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-13 7:42 ` Dan Carpenter
2 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2026-07-12 14:25 UTC (permalink / raw)
To: Dylan Liu
Cc: Dylan Liu, Nuno Sá, Michael Hennerich, Jonathan Cameron,
David Lechner, Andy Shevchenko, linux, linux-iio, linux-staging,
linux-kernel
On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
>
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
>
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
>
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
>
> Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
> 1 file changed, 114 insertions(+), 114 deletions(-)
Very odd subject line :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 14:19 [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com> Dylan Liu
2026-07-12 14:25 ` Greg Kroah-Hartman
@ 2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:56 ` 回复： " dylanliu050903
2026-07-13 7:42 ` Dan Carpenter
2 siblings, 1 reply; 9+ messages in thread
From: Greg Kroah-Hartman @ 2026-07-12 14:25 UTC (permalink / raw)
To: Dylan Liu
Cc: Dylan Liu, Nuno Sá, Michael Hennerich, Jonathan Cameron,
David Lechner, Andy Shevchenko, linux, linux-iio, linux-staging,
linux-kernel
On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
>
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
>
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
>
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
>
> Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
> 1 file changed, 114 insertions(+), 114 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..845d79591128 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> adt7316_store_da_high_resolution,
> 0);
>
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> @@ -677,7 +677,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> !!(chip->config3 & ADT7516_AIN_IN_VREF));
> }
>
> -static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_store_ain_internal_vref(struct device *dev,
> struct device_attribute *attr,
> const char *buf,
> size_t len)
> @@ -704,12 +704,12 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
> return len;
> }
>
> -static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
> - adt7316_show_AIN_internal_Vref,
> - adt7316_store_AIN_internal_Vref,
> +static IIO_DEVICE_ATTR(ain_internal_vref, 0644,
> + adt7316_show_ain_internal_vref,
> + adt7316_store_ain_internal_vref,
> 0);
You just changed the user/kernel api, right? Are you sure this is ok to
do?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread* 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 14:25 ` Greg Kroah-Hartman
@ 2026-07-12 14:56 ` dylanliu050903
2026-07-12 15:05 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: dylanliu050903 @ 2026-07-12 14:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Dylan Liu, Nuno Sá, Michael Hennerich, Jonathan Cameron,
David Lechner, Andy Shevchenko, linux, linux-iio, linux-staging,
linux-kernel
使用 Proton Mail 安全邮箱发送。
2026年7月12日 星期日 下午 10:27，Greg Kroah-Hartman <gregkh@linuxfoundation.org> 来信：
> You just changed the user/kernel api, right? Are you sure this is ok to
> do?
>
> thanks,
>
> greg k-h
>
Hi Greg,
I apologize for the oversight; being new to this, I am still learning the ropes and appreciate your patience.
You are absolutely right. I acknowledge that changing the sysfs names directly impacts userspace and violates the "never break userspace" rule. I will take a step back and adopt a more conservative approach: I plan to keep the original attribute names as they are to ensure backward compatibility while introducing the new snake_case names as aliases.
Would this be an acceptable way to move forward, or would you prefer I handle this cleanup in a different way?
Thanks,
Dylan Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 14:56 ` 回复： " dylanliu050903
@ 2026-07-12 15:05 ` Andy Shevchenko
2026-07-12 15:41 ` 回复： " dylanliu050903
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2026-07-12 15:05 UTC (permalink / raw)
To: dylanliu050903
Cc: Greg Kroah-Hartman, Dylan Liu, Nuno Sá, Michael Hennerich,
Jonathan Cameron, David Lechner, Andy Shevchenko, linux,
linux-iio, linux-staging, linux-kernel
On Sun, Jul 12, 2026 at 02:56:40PM +0000, dylanliu050903 wrote:
> 使用 Proton Mail 安全邮箱发送。
> 2026年7月12日 星期日 下午 10:27，Greg Kroah-Hartman <gregkh@linuxfoundation.org> 来信：
> > You just changed the user/kernel api, right? Are you sure this is ok to
> > do?
>
> I apologize for the oversight; being new to this, I am still learning the
> ropes and appreciate your patience.
>
> You are absolutely right. I acknowledge that changing the sysfs names
> directly impacts userspace and violates the "never break userspace" rule. I
> will take a step back and adopt a more conservative approach: I plan to keep
> the original attribute names as they are to ensure backward compatibility
> while introducing the new snake_case names as aliases.
>
> Would this be an acceptable way to move forward, or would you prefer I handle
> this cleanup in a different way?
You also should stop sending HTML mails.
The driver is in staging and most likely more work is needed. As for this ABI
change, it's possible but it needs to be aligned with IIO maintainers and
reviewers first to understand why the original driver has it and what will be
needed to fulfil the same / similar if driver becomes part of IIO.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* 回复： Re: 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 15:05 ` Andy Shevchenko
@ 2026-07-12 15:41 ` dylanliu050903
2026-07-12 16:46 ` Joshua Crofts
0 siblings, 1 reply; 9+ messages in thread
From: dylanliu050903 @ 2026-07-12 15:41 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Greg Kroah-Hartman, Dylan Liu, Nuno Sá, Michael Hennerich,
Jonathan Cameron, David Lechner, Andy Shevchenko, linux,
linux-iio, linux-staging, linux-kernel
使用 Proton Mail 安全邮箱发送。
2026年7月12日 星期日 下午 11:05，Andy Shevchenko <andriy.shevchenko@intel.com> 来信：
> On Sun, Jul 12, 2026 at 02:56:40PM +0000, dylanliu050903 wrote:
> > 使用 Proton Mail 安全邮箱发送。
> > 2026年7月12日 星期日 下午 10:27，Greg Kroah-Hartman <gregkh@linuxfoundation.org> 来信：
> > > You just changed the user/kernel api, right? Are you sure this is ok to
> > > do?
> >
> > I apologize for the oversight; being new to this, I am still learning the
> > ropes and appreciate your patience.
> >
> > You are absolutely right. I acknowledge that changing the sysfs names
> > directly impacts userspace and violates the "never break userspace" rule. I
> > will take a step back and adopt a more conservative approach: I plan to keep
> > the original attribute names as they are to ensure backward compatibility
> > while introducing the new snake_case names as aliases.
> >
> > Would this be an acceptable way to move forward, or would you prefer I handle
> > this cleanup in a different way?
>
> You also should stop sending HTML mails.
>
> The driver is in staging and most likely more work is needed. As for this ABI
> change, it's possible but it needs to be aligned with IIO maintainers and
> reviewers first to understand why the original driver has it and what will be
> needed to fulfil the same / similar if driver becomes part of IIO.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy,
First, I apologize for the HTML email earlier. I have fixed my email client settings.I was using the ProtonMail web client instead of `git send-email`, which unexpectedly defaulted to HTML.
Regarding the ABI change: I made a classic beginner mistake. I changed it purely because the `checkpatch.pl` script threw a warning suggesting it should be in snake_case. I blindly followed the script's advice without realizing that I was modifying a user/kernel ABI.
I now understand that ABI stability (and aligning with IIO maintainers for any necessary staging transitions) absolutely takes precedence over resolving style warnings.
Please drop this patch. I will be much more careful with checkpatch warnings involving exposed interfaces in the future.I will also dive deeper into the codebase to ensure my future commits provide real value.
Thank you for your time and the guidance!
Best regards,
Dylan Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 回复： Re: 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 15:41 ` 回复： " dylanliu050903
@ 2026-07-12 16:46 ` Joshua Crofts
2026-07-13 0:59 ` Jonathan Cameron
0 siblings, 1 reply; 9+ messages in thread
From: Joshua Crofts @ 2026-07-12 16:46 UTC (permalink / raw)
To: dylanliu050903
Cc: Andy Shevchenko, Greg Kroah-Hartman, Dylan Liu, Nuno Sá,
Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, linux, linux-iio, linux-staging, linux-kernel
On Sun, 12 Jul 2026 15:41:54 +0000
dylanliu050903 <dylanliu050903@protonmail.com> wrote:
> Hi Andy,
>
> First, I apologize for the HTML email earlier. I have fixed my email client settings.I was using the ProtonMail web client instead of `git send-email`, which unexpectedly defaulted to HTML.
>
> Regarding the ABI change: I made a classic beginner mistake. I changed it purely because the `checkpatch.pl` script threw a warning suggesting it should be in snake_case. I blindly followed the script's advice without realizing that I was modifying a user/kernel ABI.
>
> I now understand that ABI stability (and aligning with IIO maintainers for any necessary staging transitions) absolutely takes precedence over resolving style warnings.
>
> Please drop this patch. I will be much more careful with checkpatch warnings involving exposed interfaces in the future.I will also dive deeper into the codebase to ensure my future commits provide real value.
>
> Thank you for your time and the guidance!
>
> Best regards,
> Dylan Liu
>
Hi Dylan,
Please wrap your email body to 72 characters per line, as you would
with a commit message. It's easier to read.
Thanks!
--
Kind regards
CJD
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 回复： Re: 回复： Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 16:46 ` Joshua Crofts
@ 2026-07-13 0:59 ` Jonathan Cameron
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2026-07-13 0:59 UTC (permalink / raw)
To: Joshua Crofts
Cc: dylanliu050903, Andy Shevchenko, Greg Kroah-Hartman, Dylan Liu,
Nuno Sá, Michael Hennerich, David Lechner, Andy Shevchenko,
linux, linux-iio, linux-staging, linux-kernel
On Sun, 12 Jul 2026 18:46:02 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Sun, 12 Jul 2026 15:41:54 +0000
> dylanliu050903 <dylanliu050903@protonmail.com> wrote:
> > Hi Andy,
> >
> > First, I apologize for the HTML email earlier. I have fixed my email client settings.I was using the ProtonMail web client instead of `git send-email`, which unexpectedly defaulted to HTML.
> >
> > Regarding the ABI change: I made a classic beginner mistake. I changed it purely because the `checkpatch.pl` script threw a warning suggesting it should be in snake_case. I blindly followed the script's advice without realizing that I was modifying a user/kernel ABI.
> >
> > I now understand that ABI stability (and aligning with IIO maintainers for any necessary staging transitions) absolutely takes precedence over resolving style warnings.
> >
> > Please drop this patch. I will be much more careful with checkpatch warnings involving exposed interfaces in the future.I will also dive deeper into the codebase to ensure my future commits provide real value.
> >
> > Thank you for your time and the guidance!
> >
> > Best regards,
> > Dylan Liu
> >
>
> Hi Dylan,
>
> Please wrap your email body to 72 characters per line, as you would
> with a commit message. It's easier to read.
>
> Thanks!
For any of the drivers in staging it is worth taking a look at lore.kernel.org
and seeing what has been proposed in the past. IIRC, this one has been the subject
of more than one attempt to clean it up. The userspace ABI is a long way with
compliant with IIO ABI. The challenge with sorting that out is that the changes
are invasive so you'd need to figure out how to test them.
Jonathan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
2026-07-12 14:19 [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com> Dylan Liu
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:25 ` Greg Kroah-Hartman
@ 2026-07-13 7:42 ` Dan Carpenter
2 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2026-07-13 7:42 UTC (permalink / raw)
To: Dylan Liu
Cc: Dylan Liu, Nuno Sá, Michael Hennerich, Jonathan Cameron,
David Lechner, Andy Shevchenko, Greg Kroah-Hartman, linux,
linux-iio, linux-staging, linux-kernel
On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
>
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
>
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
>
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
>
> Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
> 1 file changed, 114 insertions(+), 114 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..845d79591128 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> adt7316_store_da_high_resolution,
> 0);
>
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
These are scientific notation. It's like making someone's
name lowercase to satisfy checkpatch. The one rule is more important
than the other rule.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-07-13 7:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-12 14:19 [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@protonmail.com> Dylan Liu
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:25 ` Greg Kroah-Hartman
2026-07-12 14:56 ` 回复： " dylanliu050903
2026-07-12 15:05 ` Andy Shevchenko
2026-07-12 15:41 ` 回复： " dylanliu050903
2026-07-12 16:46 ` Joshua Crofts
2026-07-13 0:59 ` Jonathan Cameron
2026-07-13 7:42 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox