* [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
@ 2020-11-12 3:21 Chris Packham
2020-11-12 8:02 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Chris Packham @ 2020-11-12 3:21 UTC (permalink / raw)
To: akpm, rppt, thomas.petazzoni, arnd, jason; +Cc: linux-kernel, Chris Packham
make coccicheck complains:
./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
It took some staring but I don't think there is a problem because the
file global `mbus_state` is passed mvebu_mbus_common_init() as the
`mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
are the same thing. But this is confusing for anyone reading the code
and one less complaint from coccicheck would be nice so lets fix it.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
I haven't included
Fixes: fddddb52a6c4 ("bus: introduce an Marvell EBU MBus driver")
because that commit is quite old and it's probably not worth bothering
the stable trees with what is essentially a no-op.
drivers/bus/mvebu-mbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 2519ceede64b..dd9e7343a5e3 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -1111,7 +1111,7 @@ static int __init mvebu_mbus_common_init(struct mvebu_mbus_state *mbus,
mbus->sdramwins_base = ioremap(sdramwins_phys_base, sdramwins_size);
if (!mbus->sdramwins_base) {
- iounmap(mbus_state.mbuswins_base);
+ iounmap(mbus->mbuswins_base);
return -ENOMEM;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
2020-11-12 3:21 [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap() Chris Packham
@ 2020-11-12 8:02 ` Thomas Petazzoni
2021-01-26 1:48 ` Chris Packham
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2020-11-12 8:02 UTC (permalink / raw)
To: Chris Packham; +Cc: akpm, rppt, thomas.petazzoni, arnd, jason, linux-kernel
On Thu, 12 Nov 2020 16:21:49 +1300
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> make coccicheck complains:
>
> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
>
> It took some staring but I don't think there is a problem because the
> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> are the same thing. But this is confusing for anyone reading the code
> and one less complaint from coccicheck would be nice so lets fix it.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
2020-11-12 8:02 ` Thomas Petazzoni
@ 2021-01-26 1:48 ` Chris Packham
2021-01-26 8:05 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Chris Packham @ 2021-01-26 1:48 UTC (permalink / raw)
To: Thomas Petazzoni, akpm@linux-foundation.org, rppt@kernel.org
Cc: arnd@arndb.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org
Hi All,
On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> On Thu, 12 Nov 2020 16:21:49 +1300
> Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>
>> make coccicheck complains:
>>
>> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
>>
>> It took some staring but I don't think there is a problem because the
>> file global `mbus_state` is passed mvebu_mbus_common_init() as the
>> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
>> are the same thing. But this is confusing for anyone reading the code
>> and one less complaint from coccicheck would be nice so lets fix it.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Just going through some old branches. This doesn't seem to have been
picked up. Have I missed a maintainer?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
2021-01-26 1:48 ` Chris Packham
@ 2021-01-26 8:05 ` Thomas Petazzoni
[not found] ` <87r1m3speo.fsf@BL-laptop>
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2021-01-26 8:05 UTC (permalink / raw)
To: Chris Packham
Cc: akpm@linux-foundation.org, rppt@kernel.org, arnd@arndb.de,
jason@lakedaemon.net, linux-kernel@vger.kernel.org,
Grégory Clement
On Tue, 26 Jan 2021 01:48:23 +0000
Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
> Hi All,
>
> On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> > On Thu, 12 Nov 2020 16:21:49 +1300
> > Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> >
> >> make coccicheck complains:
> >>
> >> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
> >>
> >> It took some staring but I don't think there is a problem because the
> >> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> >> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> >> are the same thing. But this is confusing for anyone reading the code
> >> and one less complaint from coccicheck would be nice so lets fix it.
> >>
> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> Just going through some old branches. This doesn't seem to have been
> picked up. Have I missed a maintainer?
+Gregory Clement in Cc. Greg, the original patch from Chris is touching
drivers/bus/mvebu-mbus.c, so I think you should be taking that patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-29 17:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 3:21 [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap() Chris Packham
2020-11-12 8:02 ` Thomas Petazzoni
2021-01-26 1:48 ` Chris Packham
2021-01-26 8:05 ` Thomas Petazzoni
[not found] ` <87r1m3speo.fsf@BL-laptop>
2021-01-29 16:28 ` Thomas Petazzoni
2021-01-29 16:59 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox