* Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
2026-04-20 3:05 [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration Yuho Choi
@ 2026-04-20 8:25 ` Andy Shevchenko
2026-04-20 10:03 ` Greg Kroah-Hartman
2026-04-20 22:08 ` Ethan Tidmore
2 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-04-20 8:25 UTC (permalink / raw)
To: Yuho Choi
Cc: Greg Kroah-Hartman, linux-staging, Hans de Goede, Michael Straube,
Minu Jin, Ingo Molnar, Ethan Tidmore, William Hansen-Baird,
linux-kernel, Myeonghun Pak, Ijae Kim, Taegyu Kim
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
You are kidding me...
> drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> 1 file changed, 1 deletion(-)
^^^^^^^^
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
2026-04-20 3:05 [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration Yuho Choi
2026-04-20 8:25 ` Andy Shevchenko
@ 2026-04-20 10:03 ` Greg Kroah-Hartman
2026-04-20 22:08 ` Ethan Tidmore
2 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2026-04-20 10:03 UTC (permalink / raw)
To: Yuho Choi
Cc: linux-staging, Hans de Goede, Michael Straube, Andy Shevchenko,
Minu Jin, Ingo Molnar, Ethan Tidmore, William Hansen-Baird,
linux-kernel, Myeonghun Pak, Ijae Kim, Taegyu Kim
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
>
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f0..cf5698dda91fc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> precvpriv->rx_drop++;
> } else if (retval == _SUCCESS) {
> #ifdef DBG_RX_DUMP_EAP
> - u8 bDumpRxPkt;
If you trace this back, why is this variable being used at all? Look at
how it is being used, and please explain the logic here.
Personally, I think this can be deleted entirely, but please verify
this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
2026-04-20 3:05 [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration Yuho Choi
2026-04-20 8:25 ` Andy Shevchenko
2026-04-20 10:03 ` Greg Kroah-Hartman
@ 2026-04-20 22:08 ` Ethan Tidmore
2026-04-20 23:00 ` 최유호
2 siblings, 1 reply; 5+ messages in thread
From: Ethan Tidmore @ 2026-04-20 22:08 UTC (permalink / raw)
To: Yuho Choi, Greg Kroah-Hartman, linux-staging
Cc: Hans de Goede, Michael Straube, Andy Shevchenko, Minu Jin,
Ingo Molnar, Ethan Tidmore, William Hansen-Baird, linux-kernel,
Myeonghun Pak, Ijae Kim, Taegyu Kim
On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
>
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Could you explain why there are so many SOB here for such a simple
change?
Thanks,
ET
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f0..cf5698dda91fc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> precvpriv->rx_drop++;
> } else if (retval == _SUCCESS) {
> #ifdef DBG_RX_DUMP_EAP
> - u8 bDumpRxPkt;
> u16 eth_type;
>
> /* dump eapol */
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
2026-04-20 22:08 ` Ethan Tidmore
@ 2026-04-20 23:00 ` 최유호
0 siblings, 0 replies; 5+ messages in thread
From: 최유호 @ 2026-04-20 23:00 UTC (permalink / raw)
To: Ethan Tidmore
Cc: Greg Kroah-Hartman, linux-staging, Hans de Goede, Michael Straube,
Andy Shevchenko, Minu Jin, Ingo Molnar, William Hansen-Baird,
linux-kernel, Myeonghun Pak, Ijae Kim, Taegyu Kim
Dear Greg, Andy, Ethan,
Thanks for the feedback.
This patch came from an ongoing research project with my fellow
researchers, and I included
the SOBs to reflect that collaboration. After reviewing the Linux
patch submission conventions
again, I agree that these tags should be limited to people who
directly contributed to the
specific patch itself. For this patch, that attribution was too broad.
I will be more careful about
that in future submissions.
I also understand the concern about the patch itself. I will trace the
logic more carefully.
Best regards,
Yuho Choi
On Mon, 20 Apr 2026 at 18:08, Ethan Tidmore <ethantidmore06@gmail.com> wrote:
>
> On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote:
> > DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> > shadowing the existing function-local variable. Drop the inner declaration
> > and reuse the existing variable to avoid unnecessary shadowing.
> >
> > Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> > Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> > Co-developed-by: Ijae Kim <ae878000@gmail.com>
> > Signed-off-by: Ijae Kim <ae878000@gmail.com>
> > Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> > Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> > Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
>
> Could you explain why there are so many SOB here for such a simple
> change?
>
> Thanks,
>
> ET
>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > index 337671b1211f0..cf5698dda91fc 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> > precvpriv->rx_drop++;
> > } else if (retval == _SUCCESS) {
> > #ifdef DBG_RX_DUMP_EAP
> > - u8 bDumpRxPkt;
> > u16 eth_type;
> >
> > /* dump eapol */
>
^ permalink raw reply [flat|nested] 5+ messages in thread