[RFC PATCH 0/4] mwifiex: add support for iw61x

[RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

This series adds support for the iw61x chips to the mwifiex driver.
There are a few things to address, hence the RFC status. See the commit
messages for details. The series is based on wireless-next/main.

I am sending this now since people requested it here [1], but as it's
out now feel free to leave your comments to the issues mentioned (or
others I haven't mentioned ;)

[1] https://lore.kernel.org/all/20240809094533.1660-1-yu-hao.lin@nxp.com/

Sascha


Sascha Hauer (4):
  wifi: mwifiex: release firmware at remove time
  wifi: mwifiex: handle VDLL
  wifi: mwifiex: wait longer for SDIO card status
  mwifiex: add iw61x support

 drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
 drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
 drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
 drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
 drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
 .../net/wireless/marvell/mwifiex/sta_event.c  |  4 +
 .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
 include/linux/mmc/sdio_ids.h                  |  3 +
 9 files changed, 205 insertions(+), 5 deletions(-)

-- 
2.39.2

[PATCH 1/4] wifi: mwifiex: release firmware at remove time

[Sascha Hauer]

With VDLL support the device will request parts of the firmware during
runtime, so instead of releasing the firmware immediately after initial
firmware upload, release it during device deregistration.

FIXME: I am not sure if we run into trouble with the firmware framework
when we don't release the firmware. We might have to copy it over to
some private buffer instead of just keeping it around.

FIXME: we might want to limit the release firmware at remove time to the
devices that actually need it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/wireless/marvell/mwifiex/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 96d1f6039fbca..5d02277d35293 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -695,10 +695,6 @@ static int _mwifiex_fw_dpc(const struct firmware *firmware, void *context)
 		release_firmware(adapter->cal_data);
 		adapter->cal_data = NULL;
 	}
-	if (adapter->firmware) {
-		release_firmware(adapter->firmware);
-		adapter->firmware = NULL;
-	}
 	if (init_failed) {
 		if (adapter->irq_wakeup >= 0)
 			device_init_wakeup(adapter->dev, false);
@@ -1836,6 +1832,11 @@ int mwifiex_remove_card(struct mwifiex_adapter *adapter)
 		    "info: unregister device\n");
 	if (adapter->if_ops.unregister_dev)
 		adapter->if_ops.unregister_dev(adapter);
+	if (adapter->firmware) {
+		release_firmware(adapter->firmware);
+		adapter->firmware = NULL;
+	}
+
 	/* Free adapter structure */
 	mwifiex_dbg(adapter, INFO,
 		    "info: free adapter\n");
-- 
2.39.2

[PATCH 2/4] wifi: mwifiex: handle VDLL

[Sascha Hauer]

Some adapters send events to the Kernel requesting VDLL images. When we
receive such an event we have to upload parts of the firmware image to
the device.

When the firmware requests a VDLL image then we have to bypass the
pending command queue and have to send it immediately. Failing to do
so will cause every other command sent from the queue to timeout.

There is this check currently in mwifiex_download_vdll_block():

	if (adapter->cmd_sent) {
		mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n", __func__);
		return -EBUSY;
	}

The downstream driver has this check as well. However, the downstream
driver tries to defer sending the VDLL command when this happens. It
sets a variable in the private driver struct where the main process
picks it up later.  I am not sure if this can work, because when
adapter->cmd_sent is true then it's already too late, we already missed
to send the VDLL image before the next command. In my tests I never saw
the above trigger, but this surely a place to have a closer look at.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
 drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
 .../net/wireless/marvell/mwifiex/sta_event.c  |  4 +
 .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
 5 files changed, 114 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index 7894102f03eb0..b2535ad458d72 100644
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -1714,3 +1714,89 @@ int mwifiex_ret_wakeup_reason(struct mwifiex_private *priv,
 
 	return 0;
 }
+
+static int mwifiex_download_vdll_block(struct mwifiex_adapter *adapter, u32 offset,
+				       u16 block_len)
+{
+	int ret;
+	struct host_cmd_ds_gen *cmd_hdr = NULL;
+	u16 msg_len = block_len + sizeof(*cmd_hdr);
+	struct sk_buff *skb;
+	u32 fw_offset;
+
+	block_len = min(block_len, adapter->vdll_len - offset);
+
+	if (offset > adapter->vdll_len)
+		return -EINVAL;
+
+	if (adapter->cmd_sent) {
+		mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n", __func__);
+		return -EBUSY;
+	}
+
+	skb = dev_alloc_skb(msg_len + MWIFIEX_TYPE_LEN);
+	if (!skb) {
+		mwifiex_dbg(adapter, ERROR,
+				"SLEEP_CFM: dev_alloc_skb failed\n");
+		return -ENOMEM;
+	}
+
+	skb_put(skb, msg_len);
+
+	cmd_hdr = (void *)skb->data;
+	cmd_hdr->command = cpu_to_le16(HostCmd_CMD_VDLL);
+	cmd_hdr->seq_num = cpu_to_le16(0xFF00);
+	cmd_hdr->size = cpu_to_le16(msg_len);
+
+	fw_offset = adapter->firmware->size - adapter->vdll_len + offset;
+	memcpy(skb->data + sizeof(*cmd_hdr), adapter->firmware->data + fw_offset, block_len);
+
+	skb_push(skb, adapter->intf_hdr_len);
+
+	ret = adapter->if_ops.host_to_card(adapter, MWIFIEX_TYPE_VDLL, skb, NULL);
+	if (ret < 0)
+		mwifiex_dbg(adapter, MSG, "DNLD_VDLL: Host to Card Failed\n");
+
+	dev_kfree_skb_any(skb);
+
+	return ret;
+
+}
+
+int mwifiex_process_vdll_event(struct mwifiex_private *priv, struct sk_buff *event_skb)
+{
+	int status = 0;
+	struct mwifiex_vdll_ind *ind;
+	struct mwifiex_adapter *adapter = priv->adapter;
+
+	ind = (struct mwifiex_vdll_ind *)(event_skb->data + sizeof(u32));
+
+	switch (le16_to_cpu(ind->type)) {
+	case VDLL_IND_TYPE_REQ:
+		mwifiex_download_vdll_block(adapter, le32_to_cpu(ind->offset),
+					    le16_to_cpu(ind->block_len));
+		break;
+	case VDLL_IND_TYPE_OFFSET:
+		adapter->vdll_len = le32_to_cpu(ind->offset);
+		mwifiex_dbg(adapter, MSG, "VDLL_IND (OFFSET): offset=0x%x\n",
+			    adapter->vdll_len);
+		break;
+	case VDLL_IND_TYPE_ERR_SIG:
+		mwifiex_dbg(adapter, MSG, "VDLL_IND (SIG ERR).\n");
+		break;
+	case VDLL_IND_TYPE_ERR_ID:
+		mwifiex_dbg(adapter, MSG, "VDLL_IND (ID ERR).\n");
+		break;
+	case VDLL_IND_TYPE_SEC_ERR_ID:
+		mwifiex_dbg(adapter, MSG, "VDLL_IND (SECURE ERR).\n");
+		break;
+	case VDLL_IND_TYPE_INTF_RESET:
+		mwifiex_dbg(adapter, MSG, "VDLL_IND (INTF_RESET)\n");
+		break;
+	default:
+		mwifiex_dbg(adapter, MSG, "unknown vdll ind type=%d\n", ind->type);
+		break;
+	}
+
+	return status;
+}
diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
index e91def0afa14d..f8312f7ba9ac9 100644
--- a/drivers/net/wireless/marvell/mwifiex/fw.h
+++ b/drivers/net/wireless/marvell/mwifiex/fw.h
@@ -406,6 +406,7 @@ enum MWIFIEX_802_11_PRIVACY_FILTER {
 #define HostCmd_CMD_FW_DUMP_EVENT		      0x0125
 #define HostCmd_CMD_SDIO_SP_RX_AGGR_CFG               0x0223
 #define HostCmd_CMD_STA_CONFIGURE		      0x023f
+#define HostCmd_CMD_VDLL			      0x0240
 #define HostCmd_CMD_CHAN_REGION_CFG		      0x0242
 #define HostCmd_CMD_PACKET_AGGR_CTRL		      0x0251
 #define HostCmd_CMD_ADD_NEW_STATION		      0x025f
@@ -584,6 +585,7 @@ enum mwifiex_channel_flags {
 #define EVENT_FW_DUMP_INFO		0x00000073
 #define EVENT_TX_STATUS_REPORT		0x00000074
 #define EVENT_BT_COEX_WLAN_PARA_CHANGE	0X00000076
+#define EVENT_VDLL_IND			0x00000081
 
 #define EVENT_ID_MASK                   0xffff
 #define BSS_NUM_MASK                    0xf
@@ -2449,4 +2451,18 @@ struct hw_spec_max_conn {
 	u8 max_sta_conn;
 } __packed;
 
+#define VDLL_IND_TYPE_REQ		0 /* req host side download vdll block */
+#define VDLL_IND_TYPE_OFFSET		1 /* notify vdll start offset in firmware image */
+#define VDLL_IND_TYPE_ERR_SIG		2 /* notify vdll download error: signature error */
+#define VDLL_IND_TYPE_ERR_ID		3 /* notify vdll download error: ID error */
+#define VDLL_IND_TYPE_SEC_ERR_ID	4 /* notify vdll download error: Secure error */
+#define VDLL_IND_TYPE_INTF_RESET	5 /* req host side interface reset */
+
+struct mwifiex_vdll_ind {
+	__le16 type;
+	__le16 vdllId;
+	__le32 offset;
+	__le16 block_len;
+} __packed;
+
 #endif /* !_MWIFIEX_FW_H_ */
diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
index 529863edd7a25..8b7edde32bb5d 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.h
+++ b/drivers/net/wireless/marvell/mwifiex/main.h
@@ -132,6 +132,7 @@ enum {
 #define MWIFIEX_TYPE_DATA				0
 #define MWIFIEX_TYPE_AGGR_DATA				10
 #define MWIFIEX_TYPE_EVENT				3
+#define MWIFIEX_TYPE_VDLL				4
 
 #define MAX_BITMAP_RATES_SIZE			18
 
@@ -1045,6 +1046,8 @@ struct mwifiex_adapter {
 	struct delayed_work devdump_work;
 
 	bool ignore_btcoex_events;
+
+	u32 vdll_len;
 };
 
 void mwifiex_process_tx_queue(struct mwifiex_adapter *adapter);
@@ -1256,6 +1259,7 @@ int mwifiex_cmd_802_11_bg_scan_config(struct mwifiex_private *priv,
 				      struct host_cmd_ds_command *cmd,
 				      void *data_buf);
 int mwifiex_stop_bg_scan(struct mwifiex_private *priv);
+int mwifiex_process_vdll_event(struct mwifiex_private *priv, struct sk_buff *event_skb);
 
 /*
  * This function checks if the queuing is RA based or not.
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c
index b5f3821a6a8f2..d142e70a7f0e1 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_event.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c
@@ -1088,6 +1088,10 @@ int mwifiex_process_sta_event(struct mwifiex_private *priv)
 		mwifiex_dbg(adapter, EVENT, "event: firmware debug info\n");
 		mwifiex_fw_dump_info_event(priv, adapter->event_skb);
 		break;
+	case EVENT_VDLL_IND:
+		mwifiex_dbg(adapter, EVENT, "event: VDLL event\n");
+		mwifiex_process_vdll_event(priv, adapter->event_skb);
+		break;
 	/* Debugging event; not used, but let's not print an ERROR for it. */
 	case EVENT_UNKNOWN_DEBUG:
 		mwifiex_dbg(adapter, EVENT, "event: debug\n");
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
index 58ef5020a46a7..80a9c433db64a 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
@@ -317,6 +317,10 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
 		memset(&priv->roc_cfg, 0x00, sizeof(struct mwifiex_roc_cfg));
 		break;
 
+	case EVENT_VDLL_IND:
+		mwifiex_dbg(adapter, EVENT, "event: handle VDLL event...\n");
+		mwifiex_process_vdll_event(priv, adapter->event_skb);
+		break;
 	default:
 		mwifiex_dbg(adapter, EVENT,
 			    "event: unknown event id: %#x\n", eventcause);
-- 
2.39.2

[PATCH 3/4] wifi: mwifiex: wait longer for SDIO card status

[Sascha Hauer]

The IW61x needs longer than the currently used MAX_POLL_TRIES for some
operations. Increase the value to 10000 * 10us = 100000us as done in the
downstream driver as well.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 490ffd981164d..cbcb5674b8036 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1265,7 +1265,7 @@ mwifiex_sdio_poll_card_status(struct mwifiex_adapter *adapter, u8 bits)
 	u32 tries;
 	u8 cs;
 
-	for (tries = 0; tries < MAX_POLL_TRIES; tries++) {
+	for (tries = 0; tries < 10000; tries++) {
 		if (mwifiex_read_reg(adapter, card->reg->poll_reg, &cs))
 			break;
 		else if ((cs & bits) == bits)
-- 
2.39.2

[PATCH 4/4] mwifiex: add iw61x support

[Sascha Hauer]

This adds iw61x aka SD9177 support to the mwifiex driver. It is named
SD9177 in the downstream driver, I deliberately chose the NXP name in
the driver.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/wireless/marvell/mwifiex/sdio.c | 79 +++++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/sdio.h |  3 +
 include/linux/mmc/sdio_ids.h                |  3 +
 3 files changed, 85 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index cbcb5674b8036..7b4045a40df57 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -318,6 +318,62 @@ static const struct mwifiex_sdio_card_reg mwifiex_reg_sd89xx = {
 				 0x68, 0x69, 0x6a},
 };
 
+static const struct mwifiex_sdio_card_reg mwifiex_reg_iw612 = {
+	.start_rd_port = 0,
+	.start_wr_port = 0,
+	.base_0_reg = 0xF8,
+	.base_1_reg = 0xF9,
+	.poll_reg = 0x5C,
+	.host_int_enable = UP_LD_HOST_INT_MASK | DN_LD_HOST_INT_MASK |
+			CMD_PORT_UPLD_INT_MASK | CMD_PORT_DNLD_INT_MASK,
+	.host_int_rsr_reg = 0x4,
+	.host_int_status_reg = 0x0C,
+	.host_int_mask_reg = 0x08,
+	.host_strap_reg = 0xF4,
+	.host_strap_mask = 0x01,
+	.host_strap_value = 0x01,
+	.status_reg_0 = 0xE8,
+	.status_reg_1 = 0xE9,
+	.sdio_int_mask = 0xff,
+	.data_port_mask = 0xffffffff,
+	.io_port_0_reg = 0xE4,
+	.io_port_1_reg = 0xE5,
+	.io_port_2_reg = 0xE6,
+	.max_mp_regs = 196,
+	.rd_bitmap_l = 0x10,
+	.rd_bitmap_u = 0x11,
+	.rd_bitmap_1l = 0x12,
+	.rd_bitmap_1u = 0x13,
+	.wr_bitmap_l = 0x14,
+	.wr_bitmap_u = 0x15,
+	.wr_bitmap_1l = 0x16,
+	.wr_bitmap_1u = 0x17,
+	.rd_len_p0_l = 0x18,
+	.rd_len_p0_u = 0x19,
+	.card_misc_cfg_reg = 0xd8,
+	.card_cfg_2_1_reg = 0xd9,
+	.cmd_rd_len_0 = 0xc0,
+	.cmd_rd_len_1 = 0xc1,
+	.cmd_rd_len_2 = 0xc2,
+	.cmd_rd_len_3 = 0xc3,
+	.cmd_cfg_0 = 0xc4,
+	.cmd_cfg_1 = 0xc5,
+	.cmd_cfg_2 = 0xc6,
+	.cmd_cfg_3 = 0xc7,
+	.fw_dump_host_ready = 0xcc,
+	.fw_dump_ctrl = 0xf0,
+	.fw_dump_start = 0xf1,
+	.fw_dump_end = 0xf8,
+	.func1_dump_reg_start = 0x10,
+	.func1_dump_reg_end = 0x17,
+	.func1_scratch_reg = 0xe8,
+	.func1_spec_reg_num = 13,
+	.func1_spec_reg_table = {0x08, 0x58, 0x5C, 0x5D,
+				 0x60, 0x61, 0x62, 0x64,
+				 0x65, 0x66, 0x68, 0x69,
+				 0x6a},
+};
+
 static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 = {
 	.firmware = SD8786_DEFAULT_FW_NAME,
 	.reg = &mwifiex_reg_sd87xx,
@@ -441,6 +497,25 @@ static const struct mwifiex_sdio_device mwifiex_sdio_sd8997 = {
 	.host_mlme = false,
 };
 
+static const struct mwifiex_sdio_device mwifiex_sdio_iw612 = {
+	.firmware = IW612_DEFAULT_FW_NAME,
+	.firmware_sdiouart = IW612_SDIOUART_FW_NAME,
+	.reg = &mwifiex_reg_iw612,
+	.max_ports = 32,
+	.mp_agg_pkt_limit = 16,
+	.tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K,
+	.mp_tx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_MAX,
+	.mp_rx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_MAX,
+	.supports_sdio_new_mode = true,
+	.has_control_mask = false,
+	.can_dump_fw = true,
+	.fw_dump_enh = true,
+	.can_auto_tdls = false,
+	.can_ext_scan = true,
+	.fw_ready_extra_delay = false,
+	.host_mlme = true,
+};
+
 static const struct mwifiex_sdio_device mwifiex_sdio_sd8887 = {
 	.firmware = SD8887_DEFAULT_FW_NAME,
 	.reg = &mwifiex_reg_sd8887,
@@ -974,6 +1049,8 @@ static const struct sdio_device_id mwifiex_ids[] = {
 		.driver_data = (unsigned long)&mwifiex_sdio_sd8987},
 	{SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, SDIO_DEVICE_ID_MARVELL_8997_WLAN),
 		.driver_data = (unsigned long)&mwifiex_sdio_sd8997},
+	{SDIO_DEVICE(SDIO_VENDOR_ID_NXP, SDIO_DEVICE_ID_NXP_IW612_WLAN),
+		.driver_data = (unsigned long)&mwifiex_sdio_iw612},
 	{},
 };
 
@@ -3212,3 +3289,5 @@ MODULE_FIRMWARE(SD8978_SDIOUART_FW_NAME);
 MODULE_FIRMWARE(SD8987_DEFAULT_FW_NAME);
 MODULE_FIRMWARE(SD8997_DEFAULT_FW_NAME);
 MODULE_FIRMWARE(SD8997_SDIOUART_FW_NAME);
+MODULE_FIRMWARE(IW612_DEFAULT_FW_NAME);
+MODULE_FIRMWARE(IW612_SDIOUART_FW_NAME);
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h b/drivers/net/wireless/marvell/mwifiex/sdio.h
index 65d142286c46e..97759456314b0 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.h
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.h
@@ -29,6 +29,9 @@
 #define SD8987_DEFAULT_FW_NAME "mrvl/sd8987_uapsta.bin"
 #define SD8997_DEFAULT_FW_NAME "mrvl/sdsd8997_combo_v4.bin"
 #define SD8997_SDIOUART_FW_NAME "mrvl/sdiouart8997_combo_v4.bin"
+#define IW612_DEFAULT_FW_NAME "nxp/sdsd_nw61x.bin"
+#define IW612_SDIOUART_FW_NAME "nxp/sd_w61x.bin"
+
 
 #define BLOCK_MODE	1
 #define BYTE_MODE	0
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index 7cddfdac2f576..a421c58abd331 100644
--- a/include/linux/mmc/sdio_ids.h
+++ b/include/linux/mmc/sdio_ids.h
@@ -115,6 +115,9 @@
 #define SDIO_VENDOR_ID_MICROCHIP_WILC		0x0296
 #define SDIO_DEVICE_ID_MICROCHIP_WILC1000	0x5347
 
+#define SDIO_VENDOR_ID_NXP			0x0471
+#define SDIO_DEVICE_ID_NXP_IW612_WLAN		0x0205
+
 #define SDIO_VENDOR_ID_REALTEK			0x024c
 #define SDIO_DEVICE_ID_REALTEK_RTW8723BS	0xb723
 #define SDIO_DEVICE_ID_REALTEK_RTW8821BS	0xb821
-- 
2.39.2

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, August 26, 2024 3:27 PM
> To: Francesco Dolcini <francesco@dolcini.it>
> Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> <s.hauer@pengutronix.de>
> Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> This series adds support for the iw61x chips to the mwifiex driver.
> There are a few things to address, hence the RFC status. See the commit
> messages for details. The series is based on wireless-next/main.
>
> I am sending this now since people requested it here [1], but as it's out now
> feel free to leave your comments to the issues mentioned (or others I haven't
> mentioned ;)
>
> [1]
> https://lore.kern/
> el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
>
> Sascha
>
>
> Sascha Hauer (4):
>   wifi: mwifiex: release firmware at remove time
>   wifi: mwifiex: handle VDLL
>   wifi: mwifiex: wait longer for SDIO card status
>   mwifiex: add iw61x support
>
>  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++
>  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
>  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
>  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
>  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
>  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
>  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
>  include/linux/mmc/sdio_ids.h                  |  3 +
>  9 files changed, 205 insertions(+), 5 deletions(-)
>
> --
> 2.39.2

Did you test STA or AP mode on DFS channel?

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Francesco Dolcini]

On Mon, Aug 26, 2024 at 07:57:39AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, August 26, 2024 3:27 PM
> > To: Francesco Dolcini <francesco@dolcini.it>
> > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> > <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > <s.hauer@pengutronix.de>
> > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> >
> > This series adds support for the iw61x chips to the mwifiex driver.
> > There are a few things to address, hence the RFC status. See the commit
> > messages for details. The series is based on wireless-next/main.
...
> Did you test STA or AP mode on DFS channel?

From what I know even IW416 is not working correctly on DFS channels.

Francesco

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Monday, August 26, 2024 4:09 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>; Francesco Dolcini
> <francesco@dolcini.it>; Calvin Owens <calvin@wbinvd.org>; Brian Norris
> <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>;
> linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Mon, Aug 26, 2024 at 07:57:39AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Monday, August 26, 2024 3:27 PM
> > > To: Francesco Dolcini <francesco@dolcini.it>
> > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> > > <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > > <s.hauer@pengutronix.de>
> > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > >
> > > This series adds support for the iw61x chips to the mwifiex driver.
> > > There are a few things to address, hence the RFC status. See the
> > > commit messages for details. The series is based on wireless-next/main.
> ...
> > Did you test STA or AP mode on DFS channel?
> 
> From what I know even IW416 is not working correctly on DFS channels.
> 
> Francesco

Yes. AP DFS mode has issue when radar detection happened. Patch to fix this issue will
be submitted later.

However, if AP DFS mode without radar detection, it can work. But if VDLL porting is not correct,
command timeout will happen when AP DFS mode is running.

Another way is try to use client mode to connect to external AP running on DFS channel.

David

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, August 26, 2024 3:27 PM
> To: Francesco Dolcini <francesco@dolcini.it>
> Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> <s.hauer@pengutronix.de>
> Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> This series adds support for the iw61x chips to the mwifiex driver.
> There are a few things to address, hence the RFC status. See the commit
> messages for details. The series is based on wireless-next/main.
>
> I am sending this now since people requested it here [1], but as it's out now
> feel free to leave your comments to the issues mentioned (or others I haven't
> mentioned ;)
>
> [1]
> https://lore.kern/
> el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
>
> Sascha
>
>
> Sascha Hauer (4):
>   wifi: mwifiex: release firmware at remove time
>   wifi: mwifiex: handle VDLL
>   wifi: mwifiex: wait longer for SDIO card status
>   mwifiex: add iw61x support
>
>  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++
>  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
>  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
>  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
>  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
>  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
>  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
>  include/linux/mmc/sdio_ids.h                  |  3 +
>  9 files changed, 205 insertions(+), 5 deletions(-)
>
> --
> 2.39.2

I think you ported VDLL related code from nxpwifi and you also traced our private/downstream MXM driver.
If this is the case, I think you should know nxpwifi already cleaned up the porting VDLL code from MXM driver.
I check your patch quickly. You ported the new SDIO data type (MWIFIEX_TYPE_VDLL) from nxpwifi, but you
did not port the code to support this new data type from nxpwifi. In other word, you did not test your
patch before submission (same as some of your patches).

Another thing is that this new SDIO data type should be handled carefully with other existed SDIO data type.

Nxpwifi only supports new SDIO mode, so the modification to support NXPWIFI_TYPE_VDLL can be clean and
simple. If you want to port the code to Mwifiex, there is no one-to-one modification of the code.

Another important thing is that you should consider if your modifications will affect existed devices or not.
You need to check if you should check firmware version or chip type before adding some code.

BTW, no matter if you add the code with or without checking of firmware version or chip type, you should test
your modifications for IW61x and at least one legacy device if the code is added to Mwifiex.

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, August 26, 2024 3:27 PM
> > To: Francesco Dolcini <francesco@dolcini.it>
> > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> > <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > <s.hauer@pengutronix.de>
> > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> >
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> >
> >
> > This series adds support for the iw61x chips to the mwifiex driver.
> > There are a few things to address, hence the RFC status. See the commit
> > messages for details. The series is based on wireless-next/main.
> >
> > I am sending this now since people requested it here [1], but as it's out now
> > feel free to leave your comments to the issues mentioned (or others I haven't
> > mentioned ;)
> >
> > [1]
> > https://lore.kern/
> > el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> >
> > Sascha
> >
> >
> > Sascha Hauer (4):
> >   wifi: mwifiex: release firmware at remove time
> >   wifi: mwifiex: handle VDLL
> >   wifi: mwifiex: wait longer for SDIO card status
> >   mwifiex: add iw61x support
> >
> >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++
> >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
> >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> >  include/linux/mmc/sdio_ids.h                  |  3 +
> >  9 files changed, 205 insertions(+), 5 deletions(-)
> >
> > --
> > 2.39.2
> 
> I think you ported VDLL related code from nxpwifi and you also traced
> our private/downstream MXM driver.

I ported it from this repository:

https://github.com/nxp-imx/mwifiex-iw612.git

Is that the one you are referring to as MXM driver?

> If this is the case, I think you should know nxpwifi already cleaned
> up the porting VDLL code from MXM driver.
> I check your patch quickly. You ported the new SDIO data type
> (MWIFIEX_TYPE_VDLL) from nxpwifi, but you
> did not port the code to support this new data type from nxpwifi. In
> other word, you did not test your
> patch before submission (same as some of your patches).

I did test it. It works with the iw61x as well as older chips. There are
likely details I haven't tested, but it generally works. If there are
details I should test additionally please let me know.

> 
> Another thing is that this new SDIO data type should be handled
> carefully with other existed SDIO data type.
> 
> Nxpwifi only supports new SDIO mode, so the modification to support
> NXPWIFI_TYPE_VDLL can be clean and simple. If you want to port the
> code to Mwifiex, there is no one-to-one modification of the code.
> 
> Another important thing is that you should consider if your
> modifications will affect existed devices or not.
> You need to check if you should check firmware version or chip type
> before adding some code.

The VDLL code I added for the iw61x only reacts to the EVENT_VDLL_IND
event. So as long as a firmware doesn't send such an event nothing is
changed with this patch, and I haven't seen an older chip sending a VDLL
event.

> 
> BTW, no matter if you add the code with or without checking of
> firmware version or chip type, you should test
> your modifications for IW61x and at least one legacy device if the
> code is added to Mwifiex.

I did.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, September 2, 2024 2:41 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Monday, August 26, 2024 3:27 PM
> > > To: Francesco Dolcini <francesco@dolcini.it>
> > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> > > <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > > <s.hauer@pengutronix.de>
> > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > This series adds support for the iw61x chips to the mwifiex driver.
> > > There are a few things to address, hence the RFC status. See the
> > > commit messages for details. The series is based on wireless-next/main.
> > >
> > > I am sending this now since people requested it here [1], but as
> > > it's out now feel free to leave your comments to the issues
> > > mentioned (or others I haven't mentioned ;)
> > >
> > > [1]
> > > https://lo/
> > >
> re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C6125c51da3704fe10
> a5
> > >
> a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> 08560
> > >
> 383160951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> 2luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jfQ6FQimPpwr
> nwUo
> > > OCEhmpSadtrb15ymGiif%2B1UCdG0%3D&reserved=0
> > >
> el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > >
> %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > >
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > >
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> > >
> > > Sascha
> > >
> > >
> > > Sascha Hauer (4):
> > >   wifi: mwifiex: release firmware at remove time
> > >   wifi: mwifiex: handle VDLL
> > >   wifi: mwifiex: wait longer for SDIO card status
> > >   mwifiex: add iw61x support
> > >
> > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> +++++++++++++++++++
> > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
> > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > >
> > > --
> > > 2.39.2
> >
> > I think you ported VDLL related code from nxpwifi and you also traced
> > our private/downstream MXM driver.
>
> I ported it from this repository:
>
> https://github.co/
> m%2Fnxp-imx%2Fmwifiex-iw612.git&data=05%7C02%7Cyu-hao.lin%40nxp.co
> m%7C6125c51da3704fe10a5a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638608560383172495%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C0%7C%7C%7C&sdata=5TgI0r4u2I9Pi1FATJx32Ubn7ufmbYsBR1XkpQLAIyQ
> %3D&reserved=0
>
> Is that the one you are referring to as MXM driver?
>

Yes.

> > If this is the case, I think you should know nxpwifi already cleaned
> > up the porting VDLL code from MXM driver.
> > I check your patch quickly. You ported the new SDIO data type
> > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you did not port the code to
> > support this new data type from nxpwifi. In other word, you did not
> > test your patch before submission (same as some of your patches).
>
> I did test it. It works with the iw61x as well as older chips. There are likely
> details I haven't tested, but it generally works. If there are details I should test
> additionally please let me know.
>
> >
> > Another thing is that this new SDIO data type should be handled
> > carefully with other existed SDIO data type.
> >
> > Nxpwifi only supports new SDIO mode, so the modification to support
> > NXPWIFI_TYPE_VDLL can be clean and simple. If you want to port the
> > code to Mwifiex, there is no one-to-one modification of the code.
> >
> > Another important thing is that you should consider if your
> > modifications will affect existed devices or not.
> > You need to check if you should check firmware version or chip type
> > before adding some code.
>
> The VDLL code I added for the iw61x only reacts to the EVENT_VDLL_IND
> event. So as long as a firmware doesn't send such an event nothing is changed
> with this patch, and I haven't seen an older chip sending a VDLL event.
>

How about IW61x? As I mentioned before, if you test IW61x on DFS channel, command timeout will happen.
Without correct VDLL porting, you will encounter command timeout in some other test cases. But testing
on DFS channel will be easier to reproduce the issue.

BTW, it is not a trivial job to port the support of VDLL data path from MXM driver to Mwifiex.

David

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: David Lin
> Sent: Monday, September 2, 2024 2:54 PM
> To: 'Sascha Hauer' <s.hauer@pengutronix.de>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, September 2, 2024 2:41 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> >
> > Caution: This is an external email. Please take care when clicking
> > links or opening attachments. When in doubt, report the message using
> > the 'Report this email' button
> >
> >
> > On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Sent: Monday, August 26, 2024 3:27 PM
> > > > To: Francesco Dolcini <francesco@dolcini.it>
> > > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David
> > > > Lin <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > > > <s.hauer@pengutronix.de>
> > > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > This series adds support for the iw61x chips to the mwifiex driver.
> > > > There are a few things to address, hence the RFC status. See the
> > > > commit messages for details. The series is based on wireless-next/main.
> > > >
> > > > I am sending this now since people requested it here [1], but as
> > > > it's out now feel free to leave your comments to the issues
> > > > mentioned (or others I haven't mentioned ;)
> > > >
> > > > [1]
> > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > > lo
> > > >
> >
> re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C6125c51da3704fe10
> > a5
> > > >
> >
> a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > 08560
> > > >
> >
> 383160951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > 2luMz
> > > >
> >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jfQ6FQimPpwr
> > nwUo
> > > > OCEhmpSadtrb15ymGiif%2B1UCdG0%3D&reserved=0
> > > >
> >
> el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > > >
> >
> %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > > >
> >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > > >
> >
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > > >
> >
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> > > >
> > > > Sascha
> > > >
> > > >
> > > > Sascha Hauer (4):
> > > >   wifi: mwifiex: release firmware at remove time
> > > >   wifi: mwifiex: handle VDLL
> > > >   wifi: mwifiex: wait longer for SDIO card status
> > > >   mwifiex: add iw61x support
> > > >
> > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > +++++++++++++++++++
> > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> ++++++++++++++++-
> > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > >
> > > > --
> > > > 2.39.2
> > >
> > > I think you ported VDLL related code from nxpwifi and you also
> > > traced our private/downstream MXM driver.
> >
> > I ported it from this repository:
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.co
> >
> m%2Fnxp-imx%2Fmwifiex-iw612.git&data=05%7C02%7Cyu-hao.lin%40nxp.co
> >
> m%7C6125c51da3704fe10a5a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5
> >
> c301635%7C0%7C0%7C638608560383172495%7CUnknown%7CTWFpbGZsb3d
> >
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> >
> D%7C0%7C%7C%7C&sdata=5TgI0r4u2I9Pi1FATJx32Ubn7ufmbYsBR1XkpQLAIyQ
> > %3D&reserved=0
> >
> > Is that the one you are referring to as MXM driver?
> >
> 
> Yes.
> 
> > > If this is the case, I think you should know nxpwifi already cleaned
> > > up the porting VDLL code from MXM driver.
> > > I check your patch quickly. You ported the new SDIO data type
> > > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you did not port the code to
> > > support this new data type from nxpwifi. In other word, you did not
> > > test your patch before submission (same as some of your patches).
> >
> > I did test it. It works with the iw61x as well as older chips. There
> > are likely details I haven't tested, but it generally works. If there
> > are details I should test additionally please let me know.
> >
> > >
> > > Another thing is that this new SDIO data type should be handled
> > > carefully with other existed SDIO data type.
> > >
> > > Nxpwifi only supports new SDIO mode, so the modification to support
> > > NXPWIFI_TYPE_VDLL can be clean and simple. If you want to port the
> > > code to Mwifiex, there is no one-to-one modification of the code.
> > >
> > > Another important thing is that you should consider if your
> > > modifications will affect existed devices or not.
> > > You need to check if you should check firmware version or chip type
> > > before adding some code.
> >
> > The VDLL code I added for the iw61x only reacts to the EVENT_VDLL_IND
> > event. So as long as a firmware doesn't send such an event nothing is
> > changed with this patch, and I haven't seen an older chip sending a VDLL
> event.
> >
> 
> How about IW61x? As I mentioned before, if you test IW61x on DFS channel,
> command timeout will happen.
> Without correct VDLL porting, you will encounter command timeout in some
> other test cases. But testing on DFS channel will be easier to reproduce the
> issue.
> 
> BTW, it is not a trivial job to port the support of VDLL data path from MXM
> driver to Mwifiex.
> 
> David

Another terrible thing is that driver can't load updated firmware of IW61x without correct VDLL porting.
Firmware will request VDLL after firmware is downloaded for updated version.
Because VDLL type for SDIO data path is working with existed SDIO data type. Some code are used to
let this new SDIO data type can work with existed SDIO data types. If missing of these code, the porting
will have issues too.

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Mon, Sep 02, 2024 at 06:54:07AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, September 2, 2024 2:41 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> >
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> >
> >
> > On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Sent: Monday, August 26, 2024 3:27 PM
> > > > To: Francesco Dolcini <francesco@dolcini.it>
> > > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David Lin
> > > > <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer
> > > > <s.hauer@pengutronix.de>
> > > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > This series adds support for the iw61x chips to the mwifiex driver.
> > > > There are a few things to address, hence the RFC status. See the
> > > > commit messages for details. The series is based on wireless-next/main.
> > > >
> > > > I am sending this now since people requested it here [1], but as
> > > > it's out now feel free to leave your comments to the issues
> > > > mentioned (or others I haven't mentioned ;)
> > > >
> > > > [1]
> > > > https://lo/
> > > >
> > re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C6125c51da3704fe10
> > a5
> > > >
> > a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > 08560
> > > >
> > 383160951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > 2luMz
> > > >
> > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jfQ6FQimPpwr
> > nwUo
> > > > OCEhmpSadtrb15ymGiif%2B1UCdG0%3D&reserved=0
> > > >
> > el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > > >
> > %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > > >
> > C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > > >
> > 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > > >
> > TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> > > >
> > > > Sascha
> > > >
> > > >
> > > > Sascha Hauer (4):
> > > >   wifi: mwifiex: release firmware at remove time
> > > >   wifi: mwifiex: handle VDLL
> > > >   wifi: mwifiex: wait longer for SDIO card status
> > > >   mwifiex: add iw61x support
> > > >
> > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > +++++++++++++++++++
> > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81 ++++++++++++++++-
> > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > >
> > > > --
> > > > 2.39.2
> > >
> > > I think you ported VDLL related code from nxpwifi and you also traced
> > > our private/downstream MXM driver.
> >
> > I ported it from this repository:
> >
> > https://github.co/
> > m%2Fnxp-imx%2Fmwifiex-iw612.git&data=05%7C02%7Cyu-hao.lin%40nxp.co
> > m%7C6125c51da3704fe10a5a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5
> > c301635%7C0%7C0%7C638608560383172495%7CUnknown%7CTWFpbGZsb3d
> > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > D%7C0%7C%7C%7C&sdata=5TgI0r4u2I9Pi1FATJx32Ubn7ufmbYsBR1XkpQLAIyQ
> > %3D&reserved=0
> >
> > Is that the one you are referring to as MXM driver?
> >
> 
> Yes.
> 
> > > If this is the case, I think you should know nxpwifi already cleaned
> > > up the porting VDLL code from MXM driver.
> > > I check your patch quickly. You ported the new SDIO data type
> > > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you did not port the code to
> > > support this new data type from nxpwifi. In other word, you did not
> > > test your patch before submission (same as some of your patches).
> >
> > I did test it. It works with the iw61x as well as older chips. There are likely
> > details I haven't tested, but it generally works. If there are details I should test
> > additionally please let me know.
> >
> > >
> > > Another thing is that this new SDIO data type should be handled
> > > carefully with other existed SDIO data type.
> > >
> > > Nxpwifi only supports new SDIO mode, so the modification to support
> > > NXPWIFI_TYPE_VDLL can be clean and simple. If you want to port the
> > > code to Mwifiex, there is no one-to-one modification of the code.
> > >
> > > Another important thing is that you should consider if your
> > > modifications will affect existed devices or not.
> > > You need to check if you should check firmware version or chip type
> > > before adding some code.
> >
> > The VDLL code I added for the iw61x only reacts to the EVENT_VDLL_IND
> > event. So as long as a firmware doesn't send such an event nothing is changed
> > with this patch, and I haven't seen an older chip sending a VDLL event.
> >
> 
> How about IW61x? As I mentioned before, if you test IW61x on DFS
> channel, command timeout will happen.  Without correct VDLL porting,
> you will encounter command timeout in some other test cases. But
> testing on DFS channel will be easier to reproduce the issue.

The VDLL support in the downstream driver supports a case when a VDLL
event comes in while a command is being sent. I catched this with this
test:

	if (adapter->cmd_sent) {
		mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n", __func__);
		return -EBUSY;
	}

The downstream driver defers handling of the VDLL event to the main
process in this case. I haven't implemented this case in my patch
because I wasn't able to trigger it, but is this the case you are
referring to?

> 
> BTW, it is not a trivial job to port the support of VDLL data path
> from MXM driver to Mwifiex.

Nothing is trivial with WiFi, these drivers are complex beasts. Be
careful with such arguments though, because duplicating the code into
two drivers makes the situation even more complex.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, September 2, 2024 3:46 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Mon, Sep 02, 2024 at 06:54:07AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Monday, September 2, 2024 2:41 PM
> > > To: David Lin <yu-hao.lin@nxp.com>
> > > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > > Sent: Monday, August 26, 2024 3:27 PM
> > > > > To: Francesco Dolcini <francesco@dolcini.it>
> > > > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David
> > > > > Lin <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha
> > > > > Hauer <s.hauer@pengutronix.de>
> > > > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > > >
> > > > > Caution: This is an external email. Please take care when
> > > > > clicking links or opening attachments. When in doubt, report the
> > > > > message using the 'Report this email' button
> > > > >
> > > > >
> > > > > This series adds support for the iw61x chips to the mwifiex driver.
> > > > > There are a few things to address, hence the RFC status. See the
> > > > > commit messages for details. The series is based on
> wireless-next/main.
> > > > >
> > > > > I am sending this now since people requested it here [1], but as
> > > > > it's out now feel free to leave your comments to the issues
> > > > > mentioned (or others I haven't mentioned ;)
> > > > >
> > > > > [1]
> > > > > https://lo/
> > > > >
> > >
> re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C6125c51da3704fe10
> > > a5
> > > > >
> > >
> a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > > 08560
> > > > >
> > >
> 383160951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > > 2luMz
> > > > >
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jfQ6FQimPpwr
> > > nwUo
> > > > > OCEhmpSadtrb15ymGiif%2B1UCdG0%3D&reserved=0
> > > > >
> > >
> el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > > > >
> > >
> %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > > > >
> > >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > > > >
> > >
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > > > >
> > >
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > > > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> > > > >
> > > > > Sascha
> > > > >
> > > > >
> > > > > Sascha Hauer (4):
> > > > >   wifi: mwifiex: release firmware at remove time
> > > > >   wifi: mwifiex: handle VDLL
> > > > >   wifi: mwifiex: wait longer for SDIO card status
> > > > >   mwifiex: add iw61x support
> > > > >
> > > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > > +++++++++++++++++++
> > > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> ++++++++++++++++-
> > > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > > >
> > > > > --
> > > > > 2.39.2
> > > >
> > > > I think you ported VDLL related code from nxpwifi and you also
> > > > traced our private/downstream MXM driver.
> > >
> > > I ported it from this repository:
> > >
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> > >
> thub.co%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C9f55bf357ece47645
> 0b
> > >
> 708dccb234dae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> 08599
> > >
> 700151625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> 2luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=OLf3OfFX7R%
> 2BT3V
> > > gWtcsqlls%2FI3ceY8r3bewwYy8bAes%3D&reserved=0
> > >
> m%2Fnxp-imx%2Fmwifiex-iw612.git&data=05%7C02%7Cyu-hao.lin%40nxp.co
> > >
> m%7C6125c51da3704fe10a5a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5
> > >
> c301635%7C0%7C0%7C638608560383172495%7CUnknown%7CTWFpbGZsb3d
> > >
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > >
> D%7C0%7C%7C%7C&sdata=5TgI0r4u2I9Pi1FATJx32Ubn7ufmbYsBR1XkpQLAIyQ
> > > %3D&reserved=0
> > >
> > > Is that the one you are referring to as MXM driver?
> > >
> >
> > Yes.
> >
> > > > If this is the case, I think you should know nxpwifi already
> > > > cleaned up the porting VDLL code from MXM driver.
> > > > I check your patch quickly. You ported the new SDIO data type
> > > > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you did not port the code to
> > > > support this new data type from nxpwifi. In other word, you did
> > > > not test your patch before submission (same as some of your patches).
> > >
> > > I did test it. It works with the iw61x as well as older chips. There
> > > are likely details I haven't tested, but it generally works. If
> > > there are details I should test additionally please let me know.
> > >
> > > >
> > > > Another thing is that this new SDIO data type should be handled
> > > > carefully with other existed SDIO data type.
> > > >
> > > > Nxpwifi only supports new SDIO mode, so the modification to
> > > > support NXPWIFI_TYPE_VDLL can be clean and simple. If you want to
> > > > port the code to Mwifiex, there is no one-to-one modification of the
> code.
> > > >
> > > > Another important thing is that you should consider if your
> > > > modifications will affect existed devices or not.
> > > > You need to check if you should check firmware version or chip
> > > > type before adding some code.
> > >
> > > The VDLL code I added for the iw61x only reacts to the
> > > EVENT_VDLL_IND event. So as long as a firmware doesn't send such an
> > > event nothing is changed with this patch, and I haven't seen an older chip
> sending a VDLL event.
> > >
> >
> > How about IW61x? As I mentioned before, if you test IW61x on DFS
> > channel, command timeout will happen.  Without correct VDLL porting,
> > you will encounter command timeout in some other test cases. But
> > testing on DFS channel will be easier to reproduce the issue.
> 
> The VDLL support in the downstream driver supports a case when a VDLL
> event comes in while a command is being sent. I catched this with this
> test:
> 
>         if (adapter->cmd_sent) {
>                 mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n",
> __func__);
>                 return -EBUSY;
>         }
> 
> The downstream driver defers handling of the VDLL event to the main process
> in this case. I haven't implemented this case in my patch because I wasn't able
> to trigger it, but is this the case you are referring to?
> 

Not only this code segment. In fact, you did not add VDLL data patch support to sdio.c.
If you try to add the code and do test, you will know what is missing in your code.

> >
> > BTW, it is not a trivial job to port the support of VDLL data path
> > from MXM driver to Mwifiex.
> 
> Nothing is trivial with WiFi, these drivers are complex beasts. Be careful with
> such arguments though, because duplicating the code into two drivers makes
> the situation even more complex.
> 
> Sascha

We will only support IW61x in nxpwifi. VDLL related code and future code for 11ax
won't be added to Mwifiex. Other difficult things are NEW API which are only for new version
of firmware. I think you did not aware of that now.

David 

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Mon, Sep 02, 2024 at 08:00:58AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, September 2, 2024 3:46 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > 
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> > 
> > 
> > On Mon, Sep 02, 2024 at 06:54:07AM +0000, David Lin wrote:
> > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Sent: Monday, September 2, 2024 2:41 PM
> > > > To: David Lin <yu-hao.lin@nxp.com>
> > > > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > > > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > > > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote:
> > > > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > > > Sent: Monday, August 26, 2024 3:27 PM
> > > > > > To: Francesco Dolcini <francesco@dolcini.it>
> > > > > > Cc: Calvin Owens <calvin@wbinvd.org>; Brian Norris
> > > > > > <briannorris@chromium.org>; Kalle Valo <kvalo@kernel.org>; David
> > > > > > Lin <yu-hao.lin@nxp.com>; linux-wireless@vger.kernel.org;
> > > > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha
> > > > > > Hauer <s.hauer@pengutronix.de>
> > > > > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > > > >
> > > > > > Caution: This is an external email. Please take care when
> > > > > > clicking links or opening attachments. When in doubt, report the
> > > > > > message using the 'Report this email' button
> > > > > >
> > > > > >
> > > > > > This series adds support for the iw61x chips to the mwifiex driver.
> > > > > > There are a few things to address, hence the RFC status. See the
> > > > > > commit messages for details. The series is based on
> > wireless-next/main.
> > > > > >
> > > > > > I am sending this now since people requested it here [1], but as
> > > > > > it's out now feel free to leave your comments to the issues
> > > > > > mentioned (or others I haven't mentioned ;)
> > > > > >
> > > > > > [1]
> > > > > > https://lo/
> > > > > >
> > > >
> > re.kern%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C6125c51da3704fe10
> > > > a5
> > > > > >
> > > >
> > a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > > > 08560
> > > > > >
> > > >
> > 383160951%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > > > 2luMz
> > > > > >
> > > >
> > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=jfQ6FQimPpwr
> > > > nwUo
> > > > > > OCEhmpSadtrb15ymGiif%2B1UCdG0%3D&reserved=0
> > > > > >
> > > >
> > el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05
> > > > > >
> > > >
> > %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7
> > > > > >
> > > >
> > C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119%
> > > > > >
> > > >
> > 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> > > > > >
> > > >
> > TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri
> > > > > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > > >
> > > > > > Sascha Hauer (4):
> > > > > >   wifi: mwifiex: release firmware at remove time
> > > > > >   wifi: mwifiex: handle VDLL
> > > > > >   wifi: mwifiex: wait longer for SDIO card status
> > > > > >   mwifiex: add iw61x support
> > > > > >
> > > > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > > > +++++++++++++++++++
> > > > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> > ++++++++++++++++-
> > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.39.2
> > > > >
> > > > > I think you ported VDLL related code from nxpwifi and you also
> > > > > traced our private/downstream MXM driver.
> > > >
> > > > I ported it from this repository:
> > > >
> > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> > > >
> > thub.co%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C9f55bf357ece47645
> > 0b
> > > >
> > 708dccb234dae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386
> > 08599
> > > >
> > 700151625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > 2luMz
> > > >
> > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=OLf3OfFX7R%
> > 2BT3V
> > > > gWtcsqlls%2FI3ceY8r3bewwYy8bAes%3D&reserved=0
> > > >
> > m%2Fnxp-imx%2Fmwifiex-iw612.git&data=05%7C02%7Cyu-hao.lin%40nxp.co
> > > >
> > m%7C6125c51da3704fe10a5a08dccb1a24ef%7C686ea1d3bc2b4c6fa92cd99c5
> > > >
> > c301635%7C0%7C0%7C638608560383172495%7CUnknown%7CTWFpbGZsb3d
> > > >
> > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > > >
> > D%7C0%7C%7C%7C&sdata=5TgI0r4u2I9Pi1FATJx32Ubn7ufmbYsBR1XkpQLAIyQ
> > > > %3D&reserved=0
> > > >
> > > > Is that the one you are referring to as MXM driver?
> > > >
> > >
> > > Yes.
> > >
> > > > > If this is the case, I think you should know nxpwifi already
> > > > > cleaned up the porting VDLL code from MXM driver.
> > > > > I check your patch quickly. You ported the new SDIO data type
> > > > > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you did not port the code to
> > > > > support this new data type from nxpwifi. In other word, you did
> > > > > not test your patch before submission (same as some of your patches).
> > > >
> > > > I did test it. It works with the iw61x as well as older chips. There
> > > > are likely details I haven't tested, but it generally works. If
> > > > there are details I should test additionally please let me know.
> > > >
> > > > >
> > > > > Another thing is that this new SDIO data type should be handled
> > > > > carefully with other existed SDIO data type.
> > > > >
> > > > > Nxpwifi only supports new SDIO mode, so the modification to
> > > > > support NXPWIFI_TYPE_VDLL can be clean and simple. If you want to
> > > > > port the code to Mwifiex, there is no one-to-one modification of the
> > code.
> > > > >
> > > > > Another important thing is that you should consider if your
> > > > > modifications will affect existed devices or not.
> > > > > You need to check if you should check firmware version or chip
> > > > > type before adding some code.
> > > >
> > > > The VDLL code I added for the iw61x only reacts to the
> > > > EVENT_VDLL_IND event. So as long as a firmware doesn't send such an
> > > > event nothing is changed with this patch, and I haven't seen an older chip
> > sending a VDLL event.
> > > >
> > >
> > > How about IW61x? As I mentioned before, if you test IW61x on DFS
> > > channel, command timeout will happen.  Without correct VDLL porting,
> > > you will encounter command timeout in some other test cases. But
> > > testing on DFS channel will be easier to reproduce the issue.
> > 
> > The VDLL support in the downstream driver supports a case when a VDLL
> > event comes in while a command is being sent. I catched this with this
> > test:
> > 
> >         if (adapter->cmd_sent) {
> >                 mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n",
> > __func__);
> >                 return -EBUSY;
> >         }
> > 
> > The downstream driver defers handling of the VDLL event to the main process
> > in this case. I haven't implemented this case in my patch because I wasn't able
> > to trigger it, but is this the case you are referring to?
> > 
> 
> Not only this code segment. In fact, you did not add VDLL data patch support to sdio.c.
> If you try to add the code and do test, you will know what is missing in your code.

Could you point me to the code you mean?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, September 2, 2024 9:11 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> > > > > > >
> > > > > > > Sascha
> > > > > > >
> > > > > > >
> > > > > > > Sascha Hauer (4):
> > > > > > >   wifi: mwifiex: release firmware at remove time
> > > > > > >   wifi: mwifiex: handle VDLL
> > > > > > >   wifi: mwifiex: wait longer for SDIO card status
> > > > > > >   mwifiex: add iw61x support
> > > > > > >
> > > > > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > > > > +++++++++++++++++++
> > > > > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > > > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > > > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> > > ++++++++++++++++-
> > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > > > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > > > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > > > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > > > > >
> > > > > > > --
> > > The VDLL support in the downstream driver supports a case when a
> > > VDLL event comes in while a command is being sent. I catched this
> > > with this
> > > test:
> > >
> > >         if (adapter->cmd_sent) {
> > >                 mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n",
> > > __func__);
> > >                 return -EBUSY;
> > >         }
> > >
> > > The downstream driver defers handling of the VDLL event to the main
> > > process in this case. I haven't implemented this case in my patch
> > > because I wasn't able to trigger it, but is this the case you are referring to?
> > >
> >
> > Not only this code segment. In fact, you did not add VDLL data patch support
> to sdio.c.
> > If you try to add the code and do test, you will know what is missing in your
> code.
> 
> Could you point me to the code you mean?
> 
> Sascha
> 

I only know the porting VDLL code in nxpwifi.

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Tue, Sep 03, 2024 at 01:51:46AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, September 2, 2024 9:11 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > 
> > > > > > > >
> > > > > > > > Sascha
> > > > > > > >
> > > > > > > >
> > > > > > > > Sascha Hauer (4):
> > > > > > > >   wifi: mwifiex: release firmware at remove time
> > > > > > > >   wifi: mwifiex: handle VDLL
> > > > > > > >   wifi: mwifiex: wait longer for SDIO card status
> > > > > > > >   mwifiex: add iw61x support
> > > > > > > >
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > > > > > +++++++++++++++++++
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> > > > ++++++++++++++++-
> > > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > > > > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > > > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > > > > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > > > > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > > > > > >
> > > > > > > > --
> > > > The VDLL support in the downstream driver supports a case when a
> > > > VDLL event comes in while a command is being sent. I catched this
> > > > with this
> > > > test:
> > > >
> > > >         if (adapter->cmd_sent) {
> > > >                 mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n",
> > > > __func__);
> > > >                 return -EBUSY;
> > > >         }
> > > >
> > > > The downstream driver defers handling of the VDLL event to the main
> > > > process in this case. I haven't implemented this case in my patch
> > > > because I wasn't able to trigger it, but is this the case you are referring to?
> > > >
> > >
> > > Not only this code segment. In fact, you did not add VDLL data patch support
> > to sdio.c.
> > > If you try to add the code and do test, you will know what is missing in your
> > code.
> > 
> > Could you point me to the code you mean?
> > 
> > Sascha
> > 
> 
> I only know the porting VDLL code in nxpwifi.

Yes, and I asked for a pointer to that code, some function name, or
file/line or whatever, because I looked at the nxpwifi driver and don't
know what you mean with "VDLL data patch support" in sdio.c.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Tuesday, September 3, 2024 2:33 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Tue, Sep 03, 2024 at 01:51:46AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Monday, September 2, 2024 9:11 PM
> > > To: David Lin <yu-hao.lin@nxp.com>
> > > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > >
> > > > > > > > >
> > > > > > > > > Sascha
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Sascha Hauer (4):
> > > > > > > > >   wifi: mwifiex: release firmware at remove time
> > > > > > > > >   wifi: mwifiex: handle VDLL
> > > > > > > > >   wifi: mwifiex: wait longer for SDIO card status
> > > > > > > > >   mwifiex: add iw61x support
> > > > > > > > >
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86
> > > > > > > +++++++++++++++++++
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/fw.h     | 16 ++++
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/main.c   |  9 +-
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/main.h   |  4 +
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.c   | 81
> > > > > ++++++++++++++++-
> > > > > > > > >  drivers/net/wireless/marvell/mwifiex/sdio.h   |  3 +
> > > > > > > > >  .../net/wireless/marvell/mwifiex/sta_event.c  |  4
> > > > > > > > > +  .../net/wireless/marvell/mwifiex/uap_event.c  |  4 +
> > > > > > > > >  include/linux/mmc/sdio_ids.h                  |  3 +
> > > > > > > > >  9 files changed, 205 insertions(+), 5 deletions(-)
> > > > > > > > >
> > > > > > > > > --
> > > > > The VDLL support in the downstream driver supports a case when a
> > > > > VDLL event comes in while a command is being sent. I catched
> > > > > this with this
> > > > > test:
> > > > >
> > > > >         if (adapter->cmd_sent) {
> > > > >                 mwifiex_dbg(adapter, MSG, "%s: adapter is
> > > > > busy\n", __func__);
> > > > >                 return -EBUSY;
> > > > >         }
> > > > >
> > > > > The downstream driver defers handling of the VDLL event to the
> > > > > main process in this case. I haven't implemented this case in my
> > > > > patch because I wasn't able to trigger it, but is this the case you are
> referring to?
> > > > >
> > > >
> > > > Not only this code segment. In fact, you did not add VDLL data
> > > > patch support
> > > to sdio.c.
> > > > If you try to add the code and do test, you will know what is
> > > > missing in your
> > > code.
> > >
> > > Could you point me to the code you mean?
> > >
> > > Sascha
> > >
> >
> > I only know the porting VDLL code in nxpwifi.
> 
> Yes, and I asked for a pointer to that code, some function name, or file/line or
> whatever, because I looked at the nxpwifi driver and don't know what you
> mean with "VDLL data patch support" in sdio.c.
> 
> Sascha
> 

It is better for you to check MXM driver. It is the same as Mwifiex which support all SDIO modes.

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > Not only this code segment. In fact, you did not add VDLL data
> > > > > patch support
> > > > to sdio.c.
> > > > > If you try to add the code and do test, you will know what is
> > > > > missing in your
> > > > code.
> > > >
> > > > Could you point me to the code you mean?
> > > >
> > > > Sascha
> > > >
> > >
> > > I only know the porting VDLL code in nxpwifi.
> > 
> > Yes, and I asked for a pointer to that code, some function name, or file/line or
> > whatever, because I looked at the nxpwifi driver and don't know what you
> > mean with "VDLL data patch support" in sdio.c.
> > 
> > Sascha
> > 
> 
> It is better for you to check MXM driver. It is the same as Mwifiex which support all SDIO modes.

Now I am confused. You said:

> In fact, you did not add VDLL data patch support to sdio.c

I was under the assumption that the nxpwifi driver that you specifically
posted for the iw61x chipset should contain this code. Isn't that the
case?

BTW did you really mean "VDLL data patch" or did you mean "VDLL data path"?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Tuesday, September 3, 2024 3:30 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > > Not only this code segment. In fact, you did not add VDLL data
> > > > > > patch support
> > > > > to sdio.c.
> > > > > > If you try to add the code and do test, you will know what is
> > > > > > missing in your
> > > > > code.
> > > > >
> > > > > Could you point me to the code you mean?
> > > > >
> > > > > Sascha
> > > > >
> > > >
> > > > I only know the porting VDLL code in nxpwifi.
> > >
> > > Yes, and I asked for a pointer to that code, some function name, or
> > > file/line or whatever, because I looked at the nxpwifi driver and
> > > don't know what you mean with "VDLL data patch support" in sdio.c.
> > >
> > > Sascha
> > >
> >
> > It is better for you to check MXM driver. It is the same as Mwifiex which
> support all SDIO modes.
> 
> Now I am confused. You said:
> 
> > In fact, you did not add VDLL data patch support to sdio.c
> 
> I was under the assumption that the nxpwifi driver that you specifically posted
> for the iw61x chipset should contain this code. Isn't that the case?
> 
> BTW did you really mean "VDLL data patch" or did you mean "VDLL data
> path"?
> 

Sorry VDLL data path.
You did not add the code to support this new SDIO data type in your patch.

Please check MXM driver which supports all SDIO modes.

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Tue, Sep 03, 2024 at 07:35:59AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Tuesday, September 3, 2024 3:30 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > 
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> > 
> > 
> > On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > > > Not only this code segment. In fact, you did not add VDLL data
> > > > > > > patch support
> > > > > > to sdio.c.
> > > > > > > If you try to add the code and do test, you will know what is
> > > > > > > missing in your
> > > > > > code.
> > > > > >
> > > > > > Could you point me to the code you mean?
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > >
> > > > > I only know the porting VDLL code in nxpwifi.
> > > >
> > > > Yes, and I asked for a pointer to that code, some function name, or
> > > > file/line or whatever, because I looked at the nxpwifi driver and
> > > > don't know what you mean with "VDLL data patch support" in sdio.c.
> > > >
> > > > Sascha
> > > >
> > >
> > > It is better for you to check MXM driver. It is the same as Mwifiex which
> > support all SDIO modes.
> > 
> > Now I am confused. You said:
> > 
> > > In fact, you did not add VDLL data patch support to sdio.c
> > 
> > I was under the assumption that the nxpwifi driver that you specifically posted
> > for the iw61x chipset should contain this code. Isn't that the case?
> > 
> > BTW did you really mean "VDLL data patch" or did you mean "VDLL data
> > path"?
> > 
> 
> Sorry VDLL data path.
> You did not add the code to support this new SDIO data type in your patch.
> 
> Please check MXM driver which supports all SDIO modes.

But why? The nxpwifi driver is much closer to the mwifiex driver and
much better readable, so I would rather pick the missing pieces from
there.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[David Lin]

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Tuesday, September 3, 2024 3:52 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Tue, Sep 03, 2024 at 07:35:59AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Tuesday, September 3, 2024 3:30 PM
> > > To: David Lin <yu-hao.lin@nxp.com>
> > > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > > > > Not only this code segment. In fact, you did not add VDLL
> > > > > > > > data patch support
> > > > > > > to sdio.c.
> > > > > > > > If you try to add the code and do test, you will know what
> > > > > > > > is missing in your
> > > > > > > code.
> > > > > > >
> > > > > > > Could you point me to the code you mean?
> > > > > > >
> > > > > > > Sascha
> > > > > > >
> > > > > >
> > > > > > I only know the porting VDLL code in nxpwifi.
> > > > >
> > > > > Yes, and I asked for a pointer to that code, some function name,
> > > > > or file/line or whatever, because I looked at the nxpwifi driver
> > > > > and don't know what you mean with "VDLL data patch support" in
> sdio.c.
> > > > >
> > > > > Sascha
> > > > >
> > > >
> > > > It is better for you to check MXM driver. It is the same as
> > > > Mwifiex which
> > > support all SDIO modes.
> > >
> > > Now I am confused. You said:
> > >
> > > > In fact, you did not add VDLL data patch support to sdio.c
> > >
> > > I was under the assumption that the nxpwifi driver that you
> > > specifically posted for the iw61x chipset should contain this code. Isn't that
> the case?
> > >
> > > BTW did you really mean "VDLL data patch" or did you mean "VDLL data
> > > path"?
> > >
> >
> > Sorry VDLL data path.
> > You did not add the code to support this new SDIO data type in your patch.
> >
> > Please check MXM driver which supports all SDIO modes.
> 
> But why? The nxpwifi driver is much closer to the mwifiex driver and much
> better readable, so I would rather pick the missing pieces from there.
> 
> Sascha
> 

Nxpwifi only supports SDIO new mode. MXM and Mwifiex supports normal and new SDIO modes.

David

Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

[Sascha Hauer]

On Tue, Sep 03, 2024 at 07:57:51AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Tuesday, September 3, 2024 3:52 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > 
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> > 
> > 
> > On Tue, Sep 03, 2024 at 07:35:59AM +0000, David Lin wrote:
> > > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Sent: Tuesday, September 3, 2024 3:30 PM
> > > > To: David Lin <yu-hao.lin@nxp.com>
> > > > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > > > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle
> > > > Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments. When in doubt, report the message
> > > > using the 'Report this email' button
> > > >
> > > >
> > > > On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > > > > > Not only this code segment. In fact, you did not add VDLL
> > > > > > > > > data patch support
> > > > > > > > to sdio.c.
> > > > > > > > > If you try to add the code and do test, you will know what
> > > > > > > > > is missing in your
> > > > > > > > code.
> > > > > > > >
> > > > > > > > Could you point me to the code you mean?
> > > > > > > >
> > > > > > > > Sascha
> > > > > > > >
> > > > > > >
> > > > > > > I only know the porting VDLL code in nxpwifi.
> > > > > >
> > > > > > Yes, and I asked for a pointer to that code, some function name,
> > > > > > or file/line or whatever, because I looked at the nxpwifi driver
> > > > > > and don't know what you mean with "VDLL data patch support" in
> > sdio.c.
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > >
> > > > > It is better for you to check MXM driver. It is the same as
> > > > > Mwifiex which
> > > > support all SDIO modes.
> > > >
> > > > Now I am confused. You said:
> > > >
> > > > > In fact, you did not add VDLL data patch support to sdio.c
> > > >
> > > > I was under the assumption that the nxpwifi driver that you
> > > > specifically posted for the iw61x chipset should contain this code. Isn't that
> > the case?
> > > >
> > > > BTW did you really mean "VDLL data patch" or did you mean "VDLL data
> > > > path"?
> > > >
> > >
> > > Sorry VDLL data path.
> > > You did not add the code to support this new SDIO data type in your patch.
> > >
> > > Please check MXM driver which supports all SDIO modes.
> > 
> > But why? The nxpwifi driver is much closer to the mwifiex driver and much
> > better readable, so I would rather pick the missing pieces from there.
> > 
> > Sascha
> > 
> 
> Nxpwifi only supports SDIO new mode. MXM and Mwifiex supports normal and new SDIO modes.

By SDIO new mode I assume that you mean the supports_sdio_new_mode
variable in the mwifiex driver. This is used when a chip supports it
The iw61x supports this new mode and the iw61x also is the only chip which
needs the VDLL code. So would I have to add something to the "normal"
SDIO mode?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |