* Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() [not found] <20260501204313.127616-1-mike.marciniszyn@gmail.com> @ 2026-05-07 18:10 ` Dmitry Ilvokhin 2026-05-07 19:12 ` Mike Marciniszyn 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Ilvokhin @ 2026-05-07 18:10 UTC (permalink / raw) To: mike.marciniszyn Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Alex Deucher, Javier Martinez Canillas, Andrew Lunn, dri-devel, linux-kernel, Mike Marciniszyn, stable On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote: > From: Mike Marciniszyn <mmarcini@meta.com> > > When CONFIG_DRM_FBDEV_EMULATION is not defined this error results > when building amdgpu_display.c with CONFIG_DRM_AMDGPU: > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and > later do not support implicit function > declarations [-Wimplicit-function-declaration] > > 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { > > Cc: stable@vger.kernel.org > Signed-off-by: Mike Marciniszyn <mmarcini@meta.com> Just hit the same problem, thanks for the fix. Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() 2026-05-07 18:10 ` [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() Dmitry Ilvokhin @ 2026-05-07 19:12 ` Mike Marciniszyn 2026-05-08 12:55 ` Dmitry Ilvokhin 0 siblings, 1 reply; 3+ messages in thread From: Mike Marciniszyn @ 2026-05-07 19:12 UTC (permalink / raw) To: Dmitry Ilvokhin Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Alex Deucher, Javier Martinez Canillas, Andrew Lunn, dri-devel, linux-kernel, Mike Marciniszyn, Jakub Kicinski On Thu, May 07, 2026 at 06:10:12PM +0000, Dmitry Ilvokhin wrote: > On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote: > > From: Mike Marciniszyn <mmarcini@meta.com> > > > > When CONFIG_DRM_FBDEV_EMULATION is not defined this error results > > when building amdgpu_display.c with CONFIG_DRM_AMDGPU: > > > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and > > later do not support implicit function > > declarations [-Wimplicit-function-declaration] > > > > 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Mike Marciniszyn <mmarcini@meta.com> > > Just hit the same problem, thanks for the fix. > > Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com> Thanks, but actually there was already a fix. Take a look at linux.git/master: commit 927011b65a875302d08709bbe82eaf4d0d96c5d5 Author: Yury Norov <ynorov@nvidia.com> Date: Mon Apr 27 22:49:41 2026 -0400 drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n I encountered this in net-next, but the above has yet to be put into net-next. Mike ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() 2026-05-07 19:12 ` Mike Marciniszyn @ 2026-05-08 12:55 ` Dmitry Ilvokhin 0 siblings, 0 replies; 3+ messages in thread From: Dmitry Ilvokhin @ 2026-05-08 12:55 UTC (permalink / raw) To: Mike Marciniszyn Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Alex Deucher, Javier Martinez Canillas, Andrew Lunn, dri-devel, linux-kernel, Mike Marciniszyn, Jakub Kicinski On Thu, May 07, 2026 at 03:12:02PM -0400, Mike Marciniszyn wrote: > On Thu, May 07, 2026 at 06:10:12PM +0000, Dmitry Ilvokhin wrote: > > On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote: > > > From: Mike Marciniszyn <mmarcini@meta.com> > > > > > > When CONFIG_DRM_FBDEV_EMULATION is not defined this error results > > > when building amdgpu_display.c with CONFIG_DRM_AMDGPU: > > > > > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and > > > later do not support implicit function > > > declarations [-Wimplicit-function-declaration] > > > > > > 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { > > > > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Mike Marciniszyn <mmarcini@meta.com> > > > > Just hit the same problem, thanks for the fix. > > > > Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com> > > Thanks, but actually there was already a fix. > > Take a look at linux.git/master: > > commit 927011b65a875302d08709bbe82eaf4d0d96c5d5 > Author: Yury Norov <ynorov@nvidia.com> > Date: Mon Apr 27 22:49:41 2026 -0400 > > drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n > > I encountered this in net-next, but the above has yet to be put into net-next. > > Mike Indeed. Thanks, Mike. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-08 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260501204313.127616-1-mike.marciniszyn@gmail.com>
2026-05-07 18:10 ` [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() Dmitry Ilvokhin
2026-05-07 19:12 ` Mike Marciniszyn
2026-05-08 12:55 ` Dmitry Ilvokhin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox