* [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
@ 2017-02-18 18:36 simran singhal
2017-02-18 19:12 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: simran singhal @ 2017-02-18 18:36 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, outreachy-kernel
Extra parentheses were causing checkpatch issues
and were removed.
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index cded0f4..1391c91 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
- pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
+ pCapELE = (struct ht_capab_ele *)&posHTCap[4];
*len = 30 + 2;
} else {
pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
- memset((void *)(&(pHTInfo->SelfHTCap)), 0,
+ memset((void *)(&pHTInfo->SelfHTCap), 0,
sizeof(pHTInfo->SelfHTCap));
- memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
+ memset((void *)(&pHTInfo->SelfHTInfo), 0,
sizeof(pHTInfo->SelfHTInfo));
- memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
sizeof(pHTInfo->PeerHTCapBuf));
- memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
sizeof(pHTInfo->PeerHTInfoBuf));
pHTInfo->bSwBwInProgress = false;
@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->IOTRaFunc = 0;
{
- u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
+ u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
RegHTSuppRateSets[0] = 0xFF;
RegHTSuppRateSets[1] = 0xFF;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
2017-02-18 18:36 [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal
@ 2017-02-18 19:12 ` Julia Lawall
2017-02-18 19:21 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2017-02-18 19:12 UTC (permalink / raw)
To: simran singhal; +Cc: gregkh, devel, linux-kernel, outreachy-kernel
On Sun, 19 Feb 2017, simran singhal wrote:
> Extra parentheses were causing checkpatch issues
> and were removed.
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index cded0f4..1391c91 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
> u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
>
> memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
> - pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
> + pCapELE = (struct ht_capab_ele *)&posHTCap[4];
> *len = 30 + 2;
> } else {
> pCapELE = (struct ht_capab_ele *)posHTCap;
> @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
>
> - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> + memset((void *)(&pHTInfo->SelfHTCap), 0,
You don't need the parens around the argument of the cast either.
julia
> sizeof(pHTInfo->SelfHTCap));
> - memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
> + memset((void *)(&pHTInfo->SelfHTInfo), 0,
> sizeof(pHTInfo->SelfHTInfo));
> - memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
> + memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
> sizeof(pHTInfo->PeerHTCapBuf));
> - memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
> + memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
> sizeof(pHTInfo->PeerHTInfoBuf));
>
> pHTInfo->bSwBwInProgress = false;
> @@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> pHTInfo->IOTRaFunc = 0;
>
> {
> - u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
> + u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
>
> RegHTSuppRateSets[0] = 0xFF;
> RegHTSuppRateSets[1] = 0xFF;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218183648.GA2680%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
2017-02-18 19:12 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-18 19:21 ` Joe Perches
2017-02-18 19:46 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-02-18 19:21 UTC (permalink / raw)
To: Julia Lawall, simran singhal
Cc: gregkh, devel, linux-kernel, outreachy-kernel
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> On Sun, 19 Feb 2017, simran singhal wrote:
> > Extra parentheses were causing checkpatch issues
> > and were removed.
[]
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
[]
> > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >
> > - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > + memset((void *)(&pHTInfo->SelfHTCap), 0,
>
> You don't need the parens around the argument of the cast either.
Nor need the cast at all.
memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
etc...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
2017-02-18 19:21 ` Joe Perches
@ 2017-02-18 19:46 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-02-18 19:46 UTC (permalink / raw)
To: Joe Perches; +Cc: simran singhal, gregkh, devel, linux-kernel, outreachy-kernel
On Sat, 18 Feb 2017, Joe Perches wrote:
> On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> > On Sun, 19 Feb 2017, simran singhal wrote:
> > > Extra parentheses were causing checkpatch issues
> > > and were removed.
> []
> > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> []
> > > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> > > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> > > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> > >
> > > - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > > + memset((void *)(&pHTInfo->SelfHTCap), 0,
> >
> > You don't need the parens around the argument of the cast either.
>
> Nor need the cast at all.
>
> memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
>
> etc...
Indeed. Thanks!
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-18 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-18 18:36 [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal
2017-02-18 19:12 ` [Outreachy kernel] " Julia Lawall
2017-02-18 19:21 ` Joe Perches
2017-02-18 19:46 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox