From: "Marek Behún" <marek.behun@nic.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gustav Ekelund <gustaek@axis.com>,
Gustav Ekelund <gustav.ekelund@axis.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@axis.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Reset mv88e6393x watchdog register
Date: Tue, 28 Mar 2023 16:47:42 +0200 [thread overview]
Message-ID: <20230328144742.vty3cpmgmsdyjiia@kandell> (raw)
In-Reply-To: <be2b5084-9cab-4cc7-ba50-a53dd71dfea5@lunn.ch>
On Tue, Mar 28, 2023 at 03:45:51PM +0200, Andrew Lunn wrote:
> On Tue, Mar 28, 2023 at 03:34:03PM +0200, Gustav Ekelund wrote:
>
> > 1) Marvell has confirmed that 6393x (Amethyst) differs from 6390 (Peridot)
> > with quote: “I tried this on my board and see G2 offset 0x1B index 12 bit 0
> > does not clear, I also tried doing a SWReset and the bit is still 1. I did
> > try the same on a Peridot board and it clears as advertised.”
> >
> > 2) Marvell are not aware of any other stuck bits, but has confirmed that the
> > WD event bits are not cleared on SW reset which is indeed contradictory to
> > what the data sheet suggests.
>
> Hi Gustav
>
> Please expand the commit message with a summary of this
> information. It answers the questions both Marek and i have been
> asking, so deserves to be in the commit message.
>
> Andrew
Maybe also add a comment next to the code writing to the register, that
this is due to an yet unreleased erratum on 6393x.
Marek
next prev parent reply other threads:[~2023-03-28 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:55 [PATCH net] net: dsa: mv88e6xxx: Reset mv88e6393x watchdog register Gustav Ekelund
2023-03-28 12:06 ` Marek Behún
2023-03-28 12:30 ` Andrew Lunn
2023-03-28 12:47 ` Marek Behún
2023-03-28 13:34 ` Gustav Ekelund
2023-03-28 13:45 ` Andrew Lunn
2023-03-28 14:47 ` Marek Behún [this message]
2023-03-30 13:29 ` Gustav Ekelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328144742.vty3cpmgmsdyjiia@kandell \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gustaek@axis.com \
--cc=gustav.ekelund@axis.com \
--cc=kernel@axis.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox