RE: [PATCH net-next 04/11] igb: prepare for RSS key get/set support

[Takashi Kozu <takkozu@amazon.com>]

On 7/1/2026 2:02 PM, Tony Nguyen wrote:
> > From: Takashi Kozu <takkozu@amazon.com>
> ...
> 
> Hi Takashi-san,
> 
> Sashiko flags this for the power management path.
> 
> "
> Will the new ASSERT_RTNL() in igb_write_rss_key() trigger a false-positive
> kernel warning during runtime power management resume?
> When the device undergoes runtime PM suspend and then wakes up,
> igb_runtime_resume() is called. This passes rpm=true to __igb_resume(),
> which
> explicitly skips acquiring the rtnl_lock() to avoid deadlocks.
> __igb_resume() then calls __igb_open(), which cascades to igb_configure(),
> igb_setup_mrqc(), and finally igb_write_rss_key(). Because the lock is
> intentionally not held on this path, the ASSERT_RTNL() will fail and
> trigger a
> WARN_ONCE.
> Is it possible to remove this assertion or adjust it to account for the
> runtime PM resume path?
> "
> 
> Kohei-san's version in igc did not have this and it does share similar
> flows with igc. I'm not sure if you added this for a specific reason but
> would you be able to send a follow up patch to adjust or remove this?
> 
> Thanks,
> Tony

Thanks for the suggestion. Sent a follow-up patch as requested:

https://lore.kernel.org/all/20260711133239.29270-2-takkozu@amazon.com/

Thanks,
Takashi