From: Wang Zhan <wang.zhan@smartx.com>
To: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, keyong.sun@smartx.com,
Wang Zhan <wang.zhan@smartx.com>,
Ilya Maximets <i.maximets@ovn.org>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
dev@openvswitch.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Jason Wang <jasowangio@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alice Mikityanska <alice@isovalent.com>
Subject: Re: [PATCH net-next v2 2/4] net: gso: support bounded TCP segmentation
Date: Fri, 25 Sep 2026 15:45:25 +0800 [thread overview]
Message-ID: <20260925074525.91040-1-wang.zhan@smartx.com> (raw)
In-Reply-To: <611ec0af-8e4c-495d-9300-6dc9b5d616a1@redhat.com>
On Thu, 24 Sep 2026 16:09:39 +0200 Paolo Abeni wrote:
> I'm wondering if this patch is needed at all. Can't the special gso caller
> set skb_shinfo(skb)->gso_size to ~64K and adjust the gso bits in the shared
> info afterwards?
That would work, and it keeps the logic in one place without a new cb field,
but I don't think it's better than the current approach.
It would need skb_unclone() before writing skb_shinfo(), and a repeat of the
if (partial_segs) logic from skb_segment(). For DF=0 we would also have to
recompute ip.id in validate_xmit_skb(), or keep that case on the existing
full-segmentation path.
next prev parent reply other threads:[~2026-09-25 7:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 8:46 [PATCH net-next v2 0/4] net: resegment oversized TCP GSO skbs Wang Zhan
2026-09-18 8:46 ` [PATCH net-next v2 1/4] net: core: factor out the GSO device limit check Wang Zhan
2026-09-18 8:46 ` [PATCH net-next v2 2/4] net: gso: support bounded TCP segmentation Wang Zhan
2026-09-19 15:35 ` Willem de Bruijn
2026-09-20 13:12 ` Wang Zhan
2026-09-21 20:36 ` Willem de Bruijn
2026-09-23 9:45 ` Wang Zhan
2026-09-23 16:42 ` Willem de Bruijn
2026-09-24 9:03 ` Wang Zhan
2026-09-21 21:07 ` Willem de Bruijn
2026-09-23 10:38 ` Wang Zhan
2026-09-23 16:44 ` Willem de Bruijn
2026-09-24 9:27 ` Wang Zhan
2026-09-21 20:50 ` netdev-bot+sashiko
2026-09-23 16:50 ` Willem de Bruijn
2026-09-24 9:09 ` Wang Zhan
2026-09-24 10:53 ` David Laight
2026-09-24 12:15 ` Wang Zhan
2026-09-24 14:09 ` Paolo Abeni
2026-09-25 7:45 ` Wang Zhan [this message]
2026-09-18 8:46 ` [PATCH net-next v2 3/4] net: core: resegment oversized TCP GSO skbs Wang Zhan
2026-09-19 15:37 ` Willem de Bruijn
2026-09-20 13:31 ` Wang Zhan
2026-09-24 14:02 ` Paolo Abeni
2026-09-21 20:50 ` netdev-bot+sashiko
2026-09-18 8:46 ` [PATCH net-next v2 4/4] net: net_test: add tests for bounded GSO segmentation Wang Zhan
2026-09-21 20:50 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925074525.91040-1-wang.zhan@smartx.com \
--to=wang.zhan@smartx.com \
--cc=aconole@redhat.com \
--cc=alice@isovalent.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jasowangio@gmail.com \
--cc=keyong.sun@smartx.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox