* Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls
From: Rick Jones @ 2007-08-10 23:15 UTC (permalink / raw)
To: David Miller; +Cc: greearb, jeff, auke-jan.h.kok, netdev, linux-kernel
In-Reply-To: <20070810.154601.98709831.davem@davemloft.net>
David Miller wrote:
> From: Ben Greear <greearb@candelatech.com>
> Date: Fri, 10 Aug 2007 15:40:02 -0700
>
>
>>For GSO on output, is there a generic fallback for any driver that
>>does not specifically implement GSO?
>
>
> Absolutely, in fact that's mainly what it's there for.
>
> I don't think there is any issue. The knob is there via
> ethtool for people who really want to disable it.
Just to be paranoid (who me?) we are then at a point where what happened
a couple months ago with forwarding between 10G and IPoIB won't happen
again - where things failed because a 10G NIC had LRO enabled by default?
rick jones
^ permalink raw reply
* RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
From: Linus Torvalds @ 2007-08-10 23:09 UTC (permalink / raw)
To: Luck, Tony
Cc: Chris Snook, Andreas Schwab, linux-kernel, linux-arch, netdev,
akpm, ak, heiko.carstens, davem, schwidefsky, wensong, horms,
wjiang, cfriesen, zlynx, rpjday, jesper.juhl
In-Reply-To: <617E1C2C70743745A92448908E030B2A0224C8D7@scsmsx411.amr.corp.intel.com>
On Fri, 10 Aug 2007, Luck, Tony wrote:
>
> Here are the functions in which they occur in the object file. You
> may have to chase down some inlining to find the function that
> actually uses atomic_*().
Could you just make the "atomic_read()" and "atomic_set()" functions be
inline functions instead?
That way you get nice compiler warnings when you pass the wrong kind of
object around. So
static void atomic_set(atomic_t *p, int value)
{
*(volatile int *)&p->value = value;
}
static int atomic_read(atomic_t *p)
{
return *(volatile int *)&p->value;
}
etc...
Linus
^ permalink raw reply
* Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code
From: Neil Horman @ 2007-08-10 23:01 UTC (permalink / raw)
To: David Miller; +Cc: vladislav.yasevich, netdev, lksctp-developers
In-Reply-To: <20070810.150625.105430969.davem@davemloft.net>
On Fri, Aug 10, 2007 at 03:06:25PM -0700, David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> Date: Fri, 10 Aug 2007 16:46:03 -0400
>
> > This patch introduces autotuning to the sctp buffer management code
> > similar to the TCP. The buffer space can be grown if the advertised
> > receive window still has room. This might happen if small message
> > sizes are used, which is common in telecom environmens.
> > New tunables are introduced that provide limits to buffer growth
> > and memory pressure is entered if to much buffer spaces is used.
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> Applied, thanks Vlad.
>
> Can you in the future fix up whitespace issues like this:
>
> Adds trailing whitespace.
> diff:21:
> Space in indent is followed by a tab.
> diff:27: int amt;
> Space in indent is followed by a tab.
> diff:48: amt = asoc->base.sk->sk_sndbuf - amt;
> Space in indent is followed by a tab.
> diff:55: return amt;
>
> I know where the "Space in indent" cases come from, you apply the
> patch to merge it into a current tree, you get rejects, then you edit
> in the foo.rej hunks by hand into the code but forget to remove the
> extra leading whitespace characters.
>
> :-)
Thanks for applying this Dave, but something seems to have occured during your
application. The commitdiff:
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.24.git;a=commitdiff;h=e20e5d698dcccd2e84ee2e1e482b0b203f885c00
only shows applications to socket.c, while the patch that vlad sent you changed
much more than that. Not sure If I'm seeing something thats transient, but I
wanted to bring it to your attention in the event that something has in fact
gone awry.
Thanks & Regards to you both
Neil
--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@tuxdriver.com
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
^ permalink raw reply
* RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
From: Luck, Tony @ 2007-08-10 22:59 UTC (permalink / raw)
To: Chris Snook
Cc: Andreas Schwab, linux-kernel, linux-arch, torvalds, netdev, akpm,
ak, heiko.carstens, davem, schwidefsky, wensong, horms, wjiang,
cfriesen, zlynx, rpjday, jesper.juhl
In-Reply-To: <46BCE9F8.4060009@redhat.com>
> Possibly. Either that or we've uncovered some latent bugs. Maybe a
> combination of the two. Can you list those 19 changes so we can
evaluate them?
Here are the functions in which they occur in the object file. You
may have to chase down some inlining to find the function that
actually uses atomic_*().
freeque
do_msgrcv
sk_free
sock_wfree
sock_rfree
sock_kmalloc
sock_kfree_s
sock_setsockopt
skb_release_data
__sk_stream_mem_reclaim
sk_tream_mem_schedule
sk_stream_rfree
sk_attach_filter
ip_frag_destroy * 2
ip_frag_queue * 2
ip_frag_reasm * 2
-Tony
^ permalink raw reply
* Re: [NET]: Share correct feature code between bridging and bonding
From: David Miller @ 2007-08-10 22:48 UTC (permalink / raw)
To: herbert; +Cc: netdev
In-Reply-To: <20070809033601.GA16912@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 9 Aug 2007 11:36:01 +0800
> Hi Dave:
>
> [NET]: Share correct feature code between bridging and bonding
>
> http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the
> bonding driver may produce bogus combinations of the checksum
> flags and SG/TSO.
>
> For example, if you bond devices with NETIF_F_HW_CSUM and
> NETIF_F_IP_CSUM you'll end up with a bonding device that
> has neither flag set. If both have TSO then this produces
> an illegal combination.
>
> The bridge device on the other hand has the correct code to
> deal with this.
>
> In fact, the same code can be used for both. So this patch
> moves that logic into net/core/dev.c and uses it for both
> bonding and bridging.
>
> In the process I've made small adjustments such as only
> setting GSO_ROBUST if at least one constituent device
> supports it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks a lot for fixing this bug Herbert!
^ permalink raw reply
* Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls
From: David Miller @ 2007-08-10 22:46 UTC (permalink / raw)
To: greearb; +Cc: jeff, auke-jan.h.kok, netdev, linux-kernel
In-Reply-To: <46BCE942.1030107@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Fri, 10 Aug 2007 15:40:02 -0700
> For GSO on output, is there a generic fallback for any driver that
> does not specifically implement GSO?
Absolutely, in fact that's mainly what it's there for.
I don't think there is any issue. The knob is there via
ethtool for people who really want to disable it.
^ permalink raw reply
* Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
From: Chris Snook @ 2007-08-10 22:43 UTC (permalink / raw)
To: Luck, Tony
Cc: Andreas Schwab, linux-kernel, linux-arch, torvalds, netdev, akpm,
ak, heiko.carstens, davem, schwidefsky, wensong, horms, wjiang,
cfriesen, zlynx, rpjday, jesper.juhl
In-Reply-To: <617E1C2C70743745A92448908E030B2A0224C88B@scsmsx411.amr.corp.intel.com>
Luck, Tony wrote:
>> Use atomic64_read to read an atomic64_t.
>
> Thanks Andreas!
>
> Chris: This bug is why the 8-byte loads got changed to 4-byte + sign-extend
> by your change to atomic_read().
I figured as much. Thanks for confirming this.
> With this applied together with shuffling the volatile from the
> declaration to the usage (in both atomic_read() and atomic_set()
> the generated code *almost* reverts to the original.
>
> There are some differences where ld4 have turned into ld8 though.
> Are these bugs in the use of atomic_add() and atomic_sub(). E.g.
> the first of these changes is in: ipc/msg.c:freeque() where we have:
>
> atomic_sub(msg->q_cbytes, &msg_bytes);
>
> Now the type of msg->q_cbytes is "unsigned long" ... so it seems a
> poor idea to subtract such a large typed object from "msg_bytes"
> which is a mere slip of an atomic_t.
>
> Or is there some other type-wrangling that needs to happen in
> include/asm-ia64/atomic.h? There are a total of nineteen of
> these ld4->ld8 transforms.
Possibly. Either that or we've uncovered some latent bugs. Maybe a
combination of the two. Can you list those 19 changes so we can
evaluate them? I'm told there were some *(volatile *) bugs fixed in gcc
recently, so it's also possible your 3.4.6 is showing those. I can test
that on a more recent gcc on ia64 if it's inconvenient for you to do so
on your test box.
-- Chris
^ permalink raw reply
* Re: RealTek 8169 support question
From: Chuck Lever @ 2007-08-10 22:40 UTC (permalink / raw)
To: Francois Romieu; +Cc: netdev ML
In-Reply-To: <20070810222346.GA9042@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
Francois Romieu wrote:
> Chuck Lever <chuck.lever@oracle.com> :
> [...]
>> I just bought a new Jetway mainboard with a pair of RTL 8169 NICs.
>
> Mini-ITX J7F4 ?
Yes. I wanted a low-power DSL router that will support IPv6 and have a
familiar GUI.
> Have your tried 2.6.23-git-latest or at least a post 2.6.23-rc1 kernel ?
Not yet. I wanted to check with "the Maintainer" to see if it was worth
trying. :-) The last time I tried a kernel build on one of these
little Via processors, it took forever. Will give it a shot.
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard
^ permalink raw reply
* Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls
From: Ben Greear @ 2007-08-10 22:40 UTC (permalink / raw)
To: David Miller; +Cc: jeff, auke-jan.h.kok, netdev, linux-kernel
In-Reply-To: <20070810.151039.31642625.davem@davemloft.net>
David Miller wrote:
> From: Ben Greear <greearb@candelatech.com>
>> I believe LRO is going to have to be disabled for routing/bridging,
>> so the stack will probably need to become aware of it at some point...
>
> The packet will be GSO'd on output I believe, so it won't
> break anything.
>
> Alternatively, we could make the driver only LRO accumulate if the
> packet is unicast and matches one of the MAC's programmed into the
> chip.
I think even this would fail if you are doing something clever with
NAT or other iptables stuff. Probably we're going to have to put this
in the hands of the users..who hopefully can determine whether they
can allow LRO or not...
For GSO on output, is there a generic fallback for any driver that
does not specifically implement GSO?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: [patch 28/28] Introduce strtol_check_range()
From: David Miller @ 2007-08-10 22:39 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam
In-Reply-To: <200708102112.l7ALCAd9009463@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:10 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Callers (especially "store" functions for sysfs or configfs attributes)
> that want to convert an input string to a number may often also want to
> check for simple input sanity or allowable range. strtol10_check_range()
> of netconsole does this, so extract it out into lib/vsprintf.c, make it
> generic w.r.t. base, and export it to the rest of the kernel and modules.
>
> [akpm@linux-foundation.org: cleanups]
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This depends upon 27/28, which needs some fixes, so please
resubmit once that patch is cured.
Thanks.
^ permalink raw reply
* Re: [patch 27/28] Introduce U16_MAX and U32_MAX
From: David Miller @ 2007-08-10 22:38 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam
In-Reply-To: <200708102112.l7ALCA2M009460@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:10 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> ... in kernel.h and clean up home-grown macros elsewhere in the tree.
>
> Leave out the one in reiserfs_fs.h as it is in the userspace-visible part
> of that header. Still, #undef the (equivalent) kernel version there to
> avoid seeing "redefined, previous definition was here" gcc warnings.
>
> [akpm@linux-foundation.org: fix U16_MAX, U32_MAX defns]
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I won't apply this one, for two reasons:
1) The reiserfs definition is better, it is _type_ based.
Please use (~(__u16)0) and (~(__u32)0), respectively.
2) The reiserfs definition is going to define an equivalent
value, so just adding an #undef and still letting reiserfs
override is wrong. Why put a common define in kernel.h
if other headers still keep their own crufty copy too?
^ permalink raw reply
* Re: [patch 26/28] netconsole: Support dynamic reconfiguration using configfs
From: David Miller @ 2007-08-10 22:35 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, Joel.Becker, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC9oD009457@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:09 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> This patch introduces support for dynamic reconfiguration (adding, removing
> and/or modifying parameters of netconsole targets at runtime) using a
> userspace interface exported via configfs. Documentation is also updated
> accordingly.
>
> Issues and brief design overview:
>
> (1) Kernel-initiated creation / destruction of kernel objects is not
> possible with configfs -- the lifetimes of the "config items" is managed
> exclusively from userspace. But netconsole must support boot/module
> params too, and these are parsed in kernel and hence netpolls must be
> setup from the kernel. Joel Becker suggested to separately manage the
> lifetimes of the two kinds of netconsole_target objects -- those created
> via configfs mkdir(2) from userspace and those specified from the
> boot/module option string. This adds complexity and some redundancy here
> and also means that boot/module param-created targets are not exposed
> through the configfs namespace (and hence cannot be updated / destroyed
> dynamically). However, this saves us from locking / refcounting
> complexities that would need to be introduced in configfs to support
> kernel-initiated item creation / destroy there.
>
> (2) In configfs, item creation takes place in the call chain of the
> mkdir(2) syscall in the driver subsystem. If we used an ioctl(2) to
> create / destroy objects from userspace, the special userspace program is
> able to fill out the structure to be passed into the ioctl and hence
> specify attributes such as local interface that are required at the time
> we set up the netpoll. For configfs, this information is not available at
> the time of mkdir(2). So, we keep all newly-created targets (via
> configfs) disabled by default. The user is expected to set various
> attributes appropriately (including the local network interface if
> required) and then write(2) "1" to the "enabled" attribute. Thus,
> netpoll_setup() is then called on the set parameters in the context of
> _this_ write(2) on the "enabled" attribute itself. This design enables
> the user to reconfigure existing netconsole targets at runtime to be
> attached to newly-come-up interfaces that may not have existed when
> netconsole was loaded or when the targets were actually created. All this
> effectively enables us to get rid of custom ioctls.
>
> (3) Ultra-paranoid configfs attribute show() and store() operations, with
> sanity and input range checking, using only safe string primitives, and
> compliant with the recommendations in Documentation/filesystems/sysfs.txt.
>
> (4) A new function netpoll_print_options() is created in the netpoll API,
> that just prints out the configured parameters for a netpoll structure.
> netpoll_parse_options() is modified to use that and it is also exported to
> be used from netconsole.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Cc: Joel Becker <Joel.Becker@oracle.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This looks good to me, applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 25/28] netconsole: Support multiple logging targets
From: David Miller @ 2007-08-10 22:33 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC8VN009454@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:07 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> This patch introduces support for multiple targets, independent of
> CONFIG_NETCONSOLE_DYNAMIC -- this is useful even in the default case and
> (including the infrastructure introduced in previous patches) doesn't really
> add too many bytes to module text. All the complexity (and size) comes with
> the dynamic reconfigurability / userspace interface patch, and so it's
> plausible users may want to keep this enabled but that disabled (say to avoid
> a dependency on CONFIG_CONFIGFS_FS too).
>
> Also update documentation to mention the use of ";" separator to specify
> multiple logging targets in the boot/module option string.
>
> Brief overview:
>
> We maintain a target_list (and corresponding lock). Get rid of the static
> "default_target" and introduce allocation and release functions for our
> netconsole_target objects (but keeping sure to preserve previous behaviour
> such as default values). During init_netconsole(), ";" is used as the
> separator to identify multiple target specifications in the boot/module option
> string. The target specifications are parsed and netpolls setup. During
> exit, the target_list is torn down and all items released.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
From: Luck, Tony @ 2007-08-10 22:33 UTC (permalink / raw)
To: Andreas Schwab
Cc: Chris Snook, linux-kernel, linux-arch, torvalds, netdev, akpm, ak,
heiko.carstens, davem, schwidefsky, wensong, horms, wjiang,
cfriesen, zlynx, rpjday, jesper.juhl
In-Reply-To: <jewsw3oyl8.fsf@sykes.suse.de>
> Use atomic64_read to read an atomic64_t.
Thanks Andreas!
Chris: This bug is why the 8-byte loads got changed to 4-byte + sign-extend
by your change to atomic_read().
With this applied together with shuffling the volatile from the
declaration to the usage (in both atomic_read() and atomic_set()
the generated code *almost* reverts to the original.
There are some differences where ld4 have turned into ld8 though.
Are these bugs in the use of atomic_add() and atomic_sub(). E.g.
the first of these changes is in: ipc/msg.c:freeque() where we have:
atomic_sub(msg->q_cbytes, &msg_bytes);
Now the type of msg->q_cbytes is "unsigned long" ... so it seems a
poor idea to subtract such a large typed object from "msg_bytes"
which is a mere slip of an atomic_t.
Or is there some other type-wrangling that needs to happen in
include/asm-ia64/atomic.h? There are a total of nineteen of
these ld4->ld8 transforms.
-Tony
^ permalink raw reply
* Re: [patch 24/28] netconsole: Introduce netconsole_netdev_notifier
From: David Miller @ 2007-08-10 22:33 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC7Vf009451@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:06 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> To update fields of underlying netpoll structure at runtime on corresponding
> NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
>
> ioctl(SIOCSIFHWADDR or SIOCSIFNAME) could be used to change the hardware/MAC
> address or name of the local interface that our netpoll is attached to.
> Whenever this happens, netdev notifier chain is called out with the
> NETDEV_CHANGEADDR or NETDEV_CHANGENAME event message. We respond to that and
> update the local_mac or dev_name field of the struct netpoll. This makes
> sense anyway, but is especially required for dynamic netconsole because the
> netpoll structure's internal members become user visible files when either
> sysfs or configfs are used. So this helps us to keep up with the MAC
> address/name changes and keep values in struct netpoll uptodate.
>
> [ Note that ioctl(SIOCSIFADDR) to change IP address of interface at
> runtime is not handled (to update local_ip of netpoll) on purpose --
> some setups may set the local_ip to a private address, not necessary
> the actual IP address of the sender host, as presently allowed. ]
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 23/28] netconsole: Introduce netconsole_target
From: David Miller @ 2007-08-10 22:32 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC6pL009448@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:05 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> Introduce a wrapper structure over netpoll to represent logging targets
> configured in netconsole. This will get extended with other members in
> further patches.
>
> This is done independent of the (to-be-introduced) NETCONSOLE_DYNAMIC config
> option so that we're able to drastically cut down on the #ifdef complexity of
> final netconsole.c. Also, struct netconsole_target would be required for
> multiple targets support also, and not just dynamic reconfigurability.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 22/28] netconsole: Add some useful tips to documentation
From: David Miller @ 2007-08-10 22:31 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC5fF009445@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:05 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> Add some useful general-purpose tips. Also suggest solution for the frequent
> problem of console loglevel set too low numerically (i.e. for high priority
> messages only) on the sender.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Acked-by: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 21/28] netconsole: Use netif_running() in write_msg()
From: David Miller @ 2007-08-10 22:30 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC4RO009442@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:04 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> Avoid unnecessarily disabling interrupts and calling netpoll_send_udp() if the
> corresponding local interface is not up.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 20/28] netconsole: Simplify boot/module option setup logic
From: David Miller @ 2007-08-10 22:30 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC4HF009439@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:03 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> Presently, boot/module parameters are set up quite differently for the case of
> built-in netconsole (__setup() -> obsolete_checksetup() ->
> netpoll_parse_options() -> strlen(config) == 0 in init_netconsole()) vs
> modular netconsole (module_param_string() -> string copied to the config
> variable -> strlen(config) != 0 init_netconsole() -> netpoll_parse_options()).
>
> This patch makes both of them similar by doing exactly the equivalent of a
> module_param_string() in option_setup() also -- just copying the param string
> passed from the kernel command line into "config" variable. So,
> strlen(config) != 0 in both cases, and netpoll_parse_options() is always
> called from init_netconsole(), thus making the setup logic for both cases
> similar.
>
> Now, option_setup() is only ever called / used for the built-in case, so we
> put it inside a #ifndef MODULE, otherwise gcc will complain about
> option_setup() being "defined but not used". Also, the "configured" variable
> is redundant with this patch and hence removed.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Acked-by: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 19/28] netconsole: Remove bogus check
From: David Miller @ 2007-08-10 22:28 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC3DC009436@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:03 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
> set by netpoll_setup(), which is called by init_netconsole() before
> register_console(), so write_msg() cannot be triggered unless netpoll_setup()
> successfully set np.dev. Also np.dev cannot go away from under us, because
> netpoll_setup() grabs us reference on it. So let's remove the bogus check.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Acked-by: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 18/28] netconsole: Cleanups, codingstyle, prettyfication
From: David Miller @ 2007-08-10 22:27 UTC (permalink / raw)
To: akpm; +Cc: netdev, satyam, k-keiichi, mpm
In-Reply-To: <200708102112.l7ALC27a009433@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:01 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> (1) Remove unwanted headers.
> (2) Mark __init and __exit as appropriate.
> (3) Various trivial codingstyle and prettification stuff.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Acked-by: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
^ permalink raw reply
* Re: [patch 17/28] drivers/atm/iphase.c: mostly kmalloc + memset conversion to kzalloc
From: David Miller @ 2007-08-10 22:26 UTC (permalink / raw)
To: akpm; +Cc: netdev, m.kozlowski
In-Reply-To: <200708102112.l7ALC1UV009424@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:01 -0700
> From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/atm/iphase.c | 111508 -> 111431 (-77 bytes)
> drivers/atm/iphase.o | 254740 -> 254260 (-480 bytes)
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6, thanks!
^ permalink raw reply
* Re: [patch 16/28] drivers/net/irda/irda-usb.c: mostly kmalloc + memset conversion to k[cz]alloc
From: David Miller @ 2007-08-10 22:25 UTC (permalink / raw)
To: akpm; +Cc: netdev, m.kozlowski, samuel
In-Reply-To: <200708102112.l7ALC0EM009421@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:00 -0700
> From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/irda/irda-usb.c | 59694 -> 59541 (-153 bytes)
> drivers/net/irda/irda-usb.o | 170588 -> 169256 (-1332 bytes)
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> Cc: Samuel Ortiz <samuel@sortiz.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6, thanks!
^ permalink raw reply
* BUG: when using 'brctl stp'
From: Daniel K. @ 2007-08-10 22:15 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel
I get this on the latest GIT, it was also present shortly after -rc1.
I have not tested with earlier kernels.
# brctl stp br0 on
[ 169.672008] BUG: sleeping function called from invalid context at kernel/mutex.c:86
[ 169.672532] in_atomic():1, irqs_disabled():0
[ 169.672832]
[ 169.672832] Call Trace:
[ 169.673406] [<ffffffff8125db3a>] mutex_lock+0x19/0x2f
[ 169.673696] [<ffffffff81067135>] __alloc_pages+0x71/0x2d3
[ 169.673996] [<ffffffff881e0abc>] :bridge:set_stp_state+0x12/0x37
[ 169.674293] [<ffffffff881e0a0a>] :bridge:store_bridge_parm+0x5f/0x79
[ 169.674587] [<ffffffff810ceb24>] sysfs_write_file+0xf2/0x134
[ 169.674879] [<ffffffff8108b3ad>] vfs_write+0xce/0x177
[ 169.675170] [<ffffffff8108b970>] sys_write+0x45/0x6e
[ 169.675463] [<ffffffff8100bc8e>] system_call+0x7e/0x83
[ 169.675769]
[ 169.676139] br0: starting userspace STP failed, staring kernel STP
# brctl stp br0 off
[ 171.774500] BUG: sleeping function called from invalid context at kernel/mutex.c:86
[ 171.775040] in_atomic():1, irqs_disabled():0
[ 171.775327]
[ 171.775328] Call Trace:
[ 171.775906] [<ffffffff8125db3a>] mutex_lock+0x19/0x2f
[ 171.776195] [<ffffffff81067135>] __alloc_pages+0x71/0x2d3
[ 171.776496] [<ffffffff881e0abc>] :bridge:set_stp_state+0x12/0x37
[ 171.776792] [<ffffffff881e0a0a>] :bridge:store_bridge_parm+0x5f/0x79
[ 171.777086] [<ffffffff810ceb24>] sysfs_write_file+0xf2/0x134
[ 171.777378] [<ffffffff8108b3ad>] vfs_write+0xce/0x177
[ 171.777669] [<ffffffff8108b970>] sys_write+0x45/0x6e
[ 171.777958] [<ffffffff8100bc8e>] system_call+0x7e/0x83
[ 171.778250]
Daniel K.
^ permalink raw reply
* Re: [patch 15/28] drivers/net/wan/hdlc_fr.c: kmalloc + memset conversion to kzalloc
From: David Miller @ 2007-08-10 22:25 UTC (permalink / raw)
To: akpm; +Cc: netdev, m.kozlowski, khc
In-Reply-To: <200708102111.l7ALBxJj009417@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:11:58 -0700
> From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/wan/hdlc_fr.c | 31260 -> 31223 (-37 bytes)
> drivers/net/wan/hdlc_fr.o | 144872 -> 144728 (-144 bytes)
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6, thanks!
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox