* Re: [PATCH] allow DSCP values in ip rulesB
From: David Miller @ 2018-11-17 4:29 UTC (permalink / raw)
To: mail; +Cc: netdev
In-Reply-To: <20181114143037.GA4650@rnd.infotecs.ru>
From: Pavel Balaev <mail@void.so>
Date: Wed, 14 Nov 2018 17:30:37 +0300
> Hello, for now IP rules supports only old TOS values and we cannot use
> DSCP.
>
> This patch adds support for DSCP values in IP rules:
>
> $ ip r add default via 192.168.0.6 table test
> $ ip ru add tos 0x80 table test
> $ ip ru
> 0: from all lookup local
> 32764: from all tos CS4 lookup test
> 32766: from all lookup main
> 32767: from all lookup default
> $ ip r get fibmatch 8.8.8.9 tos 0x80
> default tos CS4 via 192.168.0.6 dev lan table test
>
> Signed-off-by: Pavel Balaev <mail@void.so>
Please repost this with all of your follow-up comments added to
the commit message.
And provide a proper subsystem prefix in your Subject line, such
as "ipv4: ".
^ permalink raw reply
* Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response
From: David Miller @ 2018-11-17 4:38 UTC (permalink / raw)
To: dwesterg; +Cc: netdev, dinguyen, thor.thayer, dalon.westergreen
In-Reply-To: <20181115005047.28464-2-dwesterg@gmail.com>
From: Dalon Westergreen <dwesterg@gmail.com>
Date: Wed, 14 Nov 2018 16:50:40 -0800
> @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *buffer)
> /* enqueue the request to the pending transmit queue */
> queue_tx(priv, buffer);
>
> - return 1;
> + return 0;
NETDEV_TX_OK.
And now you can make all of these functions properly return netdev_tx_t instead of int.
^ permalink raw reply
* Re: [PATCH net-next v1 1/4] etf: Cancel timer if there are no pending skbs
From: David Miller @ 2018-11-17 4:39 UTC (permalink / raw)
To: vinicius.gomes
Cc: netdev, jesus.sanchez-palencia, jhs, xiyou.wangcong, jiri,
jesus.s.palencia, ilias.apalodimas
In-Reply-To: <20181115012635.7272-1-vinicius.gomes@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Wed, 14 Nov 2018 17:26:32 -0800
> From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
>
> There is no point in firing the qdisc watchdog if there are no future
> skbs pending in the queue and the watchdog had been set previously.
>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.s.palencia@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v1 2/4] etf: Use cached rb_root
From: David Miller @ 2018-11-17 4:40 UTC (permalink / raw)
To: vinicius.gomes
Cc: netdev, jesus.sanchez-palencia, jhs, xiyou.wangcong, jiri,
jesus.s.palencia, ilias.apalodimas
In-Reply-To: <20181115012635.7272-2-vinicius.gomes@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Wed, 14 Nov 2018 17:26:33 -0800
> From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
>
> ETF's peek() operation is heavily used so use an rb_root_cached instead
> and leverage rb_first_cached() which will run in O(1) instead of
> O(log n).
>
> Even if on 'timesortedlist_clear()' we could be using rb_erase(), we
> choose to use rb_erase_cached(), because if in the future we allow
> runtime changes to ETF parameters, and need to do a '_clear()', this
> might cause some hard to debug issues.
>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.s.palencia@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v1 3/4] etf: Split timersortedlist_erase()
From: David Miller @ 2018-11-17 4:40 UTC (permalink / raw)
To: vinicius.gomes
Cc: netdev, jesus.sanchez-palencia, jhs, xiyou.wangcong, jiri,
jesus.s.palencia, ilias.apalodimas
In-Reply-To: <20181115012635.7272-3-vinicius.gomes@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Wed, 14 Nov 2018 17:26:34 -0800
> From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
>
> This is just a refactor that will simplify the implementation of the
> next patch in this series which will drop all expired packets on the
> dequeue flow.
>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.s.palencia@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v1 4/4] etf: Drop all expired packets
From: David Miller @ 2018-11-17 4:40 UTC (permalink / raw)
To: vinicius.gomes
Cc: netdev, jesus.sanchez-palencia, jhs, xiyou.wangcong, jiri,
jesus.s.palencia, ilias.apalodimas
In-Reply-To: <20181115012635.7272-4-vinicius.gomes@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Wed, 14 Nov 2018 17:26:35 -0800
> From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
>
> Currently on dequeue() ETF only drops the first expired packet, which
> causes a problem if the next packet is already expired. When this
> happens, the watchdog will be configured with a time in the past, fire
> straight way and the packet will finally be dropped once the dequeue()
> function of the qdisc is called again.
>
> We can save quite a few cycles and improve the overall behavior of the
> qdisc if we drop all expired packets if the next packet is expired.
> This should allow ETF to recover faster from bad situations. But
> packet drops are still a very serious warning that the requirements
> imposed on the system aren't reasonable.
>
> This was inspired by how the implementation of hrtimers use the
> rb_tree inside the kernel.
>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.s.palencia@gmail.com>
Applied.
^ permalink raw reply
* Re: [v3, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC
From: Rob Herring @ 2018-11-17 14:56 UTC (permalink / raw)
To: Biao Huang
Cc: davem, honghui.zhang, yt.shen, liguo.zhang, mark.rutland,
nelson.chang, matthias.bgg, netdev, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, joabreu, andrew
In-Reply-To: <1542359926-28800-2-git-send-email-biao.huang@mediatek.com>
On Fri, Nov 16, 2018 at 05:18:46PM +0800, Biao Huang wrote:
> The commit adds the device tree binding documentation for the MediaTek DWMAC
> found on MediaTek MT2712.
>
> Change-Id: I3728666bf65927164bd82fa8dddb90df8270bd44
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> ---
> .../devicetree/bindings/net/mediatek-dwmac.txt | 77 ++++++++++++++++++++
> 1 file changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/mediatek-dwmac.txt
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.txt b/Documentation/devicetree/bindings/net/mediatek-dwmac.txt
> new file mode 100644
> index 0000000..7fd56e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.txt
> @@ -0,0 +1,77 @@
> +MediaTek DWMAC glue layer controller
> +
> +This file documents platform glue layer for stmmac.
> +Please see stmmac.txt for the other unchanged properties.
> +
> +The device node has following properties.
> +
> +Required properties:
> +- compatible: Should be "mediatek,mt2712-gmac" for MT2712 SoC
> +- reg: Address and length of the register set for the device
> +- interrupts: Should contain the MAC interrupts
How many?
> +- interrupt-names: Should contain a list of interrupt names corresponding to
> + the interrupts in the interrupts property, if available.
> + Should be "macirq" for the main MAC IRQ
> +- clocks: Must contain a phandle for each entry in clock-names.
> +- clock-names: The name of the clock listed in the clocks property. These are
> + "axi", "apb", "mac_ext", "mac_parent", "ptp_ref", "ptp_parent", "ptp_top"
> + for MT2712 SoC
Clocks should represent the physical clocks connected to a block. Parent
clocks are not in that category.
> +- mac-address: See ethernet.txt in the same directory
> +- phy-mode: See ethernet.txt in the same directory
> +
> +Optional properties:
> +- tx-delay: TX clock delay macro value. Range is 0~31. Default is 0.
> + It should be defined for rgmii/rgmii-rxid/mii interface.
> +- rx-delay: RX clock delay macro value. Range is 0~31. Default is 0.
> + It should be defined for rgmii/rgmii-txid/mii/rmii interface.
> +- fine-tune: This property will select coarse-tune delay or fine delay
> + for rgmii interface.
> + If fine-tune delay is enabled, tx-delay/rx-delay is 170+/-50ps
> + per stage.
> + Else coarse-tune delay is enabled, tx-delay/rx-delay is 0.55+/-0.2ns
> + per stage.
> + This property do not apply to non-rgmii PHYs.
> + Only coarse-tune delay is supported for mii/rmii PHYs.
Perhaps the delays should be in ps and the driver can figure out
fine-tune or not based on the value.
> +- rmii-rxc: Reference clock of rmii is from external PHYs,
> + and it can be connected to TXC or RXC pin on MT2712 SoC.
> + If ref_clk <--> TXC, disable it.
> + Else ref_clk <--> RXC, enable it.
> +- txc-inverse: Inverse tx clock for mii/rgmii.
> + Inverse tx clock inside MAC relative to reference clock for rmii,
> + and it rarely happen.
> +- rxc-inverse: Inverse rx clock for mii/rgmii interfaces.
> + Inverse reference clock for rmii.
These should all have vendor prefixes. 'snps' if these are all standard
GMAC controls or 'mediatek' if Mediatek specific.
> +
> +Example:
> + eth: ethernet@1101c000 {
> + compatible = "mediatek,mt2712-gmac";
> + reg = <0 0x1101c000 0 0x1300>;
> + interrupts = <GIC_SPI 237 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "macirq";
> + phy-mode ="rgmii-id";
> + mac-address = [00 55 7b b5 7d f7];
> + clock-names = "axi",
> + "apb",
> + "mac_ext",
> + "mac_parent",
> + "ptp_ref",
> + "ptp_parent",
> + "ptp_top";
> + clocks = <&pericfg CLK_PERI_GMAC>,
> + <&pericfg CLK_PERI_GMAC_PCLK>,
> + <&topckgen CLK_TOP_ETHER_125M_SEL>,
> + <&topckgen CLK_TOP_ETHERPLL_125M>,
> + <&topckgen CLK_TOP_ETHER_50M_SEL>,
> + <&topckgen CLK_TOP_APLL1_D3>,
> + <&topckgen CLK_TOP_APLL1>;
> + snps,txpbl = <32>;
> + snps,rxpbl = <32>;
> + snps,reset-gpio = <&pio 87 GPIO_ACTIVE_LOW>;
> + snps,reset-active-low;
> + tx-delay = <9>;
> + rx-delay = <9>;
> + fine-tune;
> + rmii-rxc;
> + txc-inverse;
> + rxc-inverse;
> + };
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH bpf-next v2] bpftool: make libbfd optional
From: Alexei Starovoitov @ 2018-11-17 4:47 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Network Development, Alexei Starovoitov, Daniel Borkmann,
Jakub Kicinski, Quentin Monnet
In-Reply-To: <20181112214410.14270-1-sdf@google.com>
On Mon, Nov 12, 2018 at 1:44 PM Stanislav Fomichev <sdf@google.com> wrote:
>
> Make it possible to build bpftool without libbfd. libbfd and libopcodes are
> typically provided in dev/dbg packages (binutils-dev in debian) which we
> usually don't have installed on the fleet machines and we'd like a way to have
> bpftool version that works without installing any additional packages.
> This excludes support for disassembling jit-ted code and prints an error if
> the user tries to use these features.
>
> Tested by:
> cat > FEATURES_DUMP.bpftool <<EOF
> feature-libbfd=0
> feature-disassembler-four-args=1
> feature-reallocarray=0
> feature-libelf=1
> feature-libelf-mmap=1
> feature-bpf=1
> EOF
> FEATURES_DUMP=$PWD/FEATURES_DUMP.bpftool make
> ldd bpftool | grep libbfd
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
applied, thanks
^ permalink raw reply
* Re: [PATCH bpf-next v2] filter: add BPF_ADJ_ROOM_DATA mode to bpf_skb_adjust_room()
From: Alexei Starovoitov @ 2018-11-17 4:52 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: kafai, ast, daniel, davem, netdev
In-Reply-To: <20181113163517.4185-1-nicolas.dichtel@6wind.com>
On Tue, Nov 13, 2018 at 05:35:17PM +0100, Nicolas Dichtel wrote:
> This new mode enables to add or remove an l2 header in a programmatic way
> with cls_bpf.
> For example, it enables to play with mpls headers.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Acked-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Daniel, thoughts?
^ permalink raw reply
* Re: [PATCH bpf-next v2] bpftool: make libbfd optional
From: Alexei Starovoitov @ 2018-11-17 4:57 UTC (permalink / raw)
To: Stanislav Fomichev; +Cc: netdev, ast, daniel, jakub.kicinski, quentin.monnet
In-Reply-To: <CAKH8qBtbrNCNJkjqNH3vm_s_+x6vHbp8MFWSLgROMCF5A=xtjA@mail.gmail.com>
On Fri, Nov 16, 2018 at 08:52:23PM -0800, Stanislav Fomichev wrote:
> I actually wanted to follow up with a v2 when
> https://lkml.org/lkml/2018/11/16/243 reaches bpf-next (I got an ack
> already).
it will go via perf tree, so not related.
> Alternatively, I can follow up with another patch on top of that to fix
> libbfd feature detection (it's semi broken on ubuntu/fedora now).
I think you'd need to wait until all trees merge.
pls don't top post.
> On Fri, Nov 16, 2018 at 8:47 PM Alexei Starovoitov <
> alexei.starovoitov@gmail.com> wrote:
>
> > On Mon, Nov 12, 2018 at 1:44 PM Stanislav Fomichev <sdf@google.com> wrote:
> > >
> > > Make it possible to build bpftool without libbfd. libbfd and libopcodes
> > are
> > > typically provided in dev/dbg packages (binutils-dev in debian) which we
> > > usually don't have installed on the fleet machines and we'd like a way
> > to have
> > > bpftool version that works without installing any additional packages.
> > > This excludes support for disassembling jit-ted code and prints an error
> > if
> > > the user tries to use these features.
> > >
> > > Tested by:
> > > cat > FEATURES_DUMP.bpftool <<EOF
> > > feature-libbfd=0
> > > feature-disassembler-four-args=1
> > > feature-reallocarray=0
> > > feature-libelf=1
> > > feature-libelf-mmap=1
> > > feature-bpf=1
> > > EOF
> > > FEATURES_DUMP=$PWD/FEATURES_DUMP.bpftool make
> > > ldd bpftool | grep libbfd
> > >
> > > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> >
> > applied, thanks
> >
^ permalink raw reply
* Re: [PATCH bpf-next v2] bpftool: make libbfd optional
From: Stanislav Fomichev @ 2018-11-17 5:06 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Stanislav Fomichev, netdev, ast, daniel, jakub.kicinski,
quentin.monnet
In-Reply-To: <20181117045712.i6ierstm66jbnckx@ast-mbp.dhcp.thefacebook.com>
On 11/16, Alexei Starovoitov wrote:
> On Fri, Nov 16, 2018 at 08:52:23PM -0800, Stanislav Fomichev wrote:
> > I actually wanted to follow up with a v2 when
> > https://lkml.org/lkml/2018/11/16/243 reaches bpf-next (I got an ack
> > already).
>
> it will go via perf tree, so not related.
My understanding was that you periodically merge whatever goes to Linus
back to bpf-next, so my plan was to wait for that event and propose a
v3.
> > Alternatively, I can follow up with another patch on top of that to fix
> > libbfd feature detection (it's semi broken on ubuntu/fedora now).
>
> I think you'd need to wait until all trees merge.
Sure, that's no problem. I'll follow up with another patch whenever that
happens.
> pls don't top post.
Sorry, Gmail :-/
> > On Fri, Nov 16, 2018 at 8:47 PM Alexei Starovoitov <
> > alexei.starovoitov@gmail.com> wrote:
> >
> > > On Mon, Nov 12, 2018 at 1:44 PM Stanislav Fomichev <sdf@google.com> wrote:
> > > >
> > > > Make it possible to build bpftool without libbfd. libbfd and libopcodes
> > > are
> > > > typically provided in dev/dbg packages (binutils-dev in debian) which we
> > > > usually don't have installed on the fleet machines and we'd like a way
> > > to have
> > > > bpftool version that works without installing any additional packages.
> > > > This excludes support for disassembling jit-ted code and prints an error
> > > if
> > > > the user tries to use these features.
> > > >
> > > > Tested by:
> > > > cat > FEATURES_DUMP.bpftool <<EOF
> > > > feature-libbfd=0
> > > > feature-disassembler-four-args=1
> > > > feature-reallocarray=0
> > > > feature-libelf=1
> > > > feature-libelf-mmap=1
> > > > feature-bpf=1
> > > > EOF
> > > > FEATURES_DUMP=$PWD/FEATURES_DUMP.bpftool make
> > > > ldd bpftool | grep libbfd
> > > >
> > > > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > >
> > > applied, thanks
> > >
^ permalink raw reply
* Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
From: David Miller @ 2018-11-17 5:11 UTC (permalink / raw)
To: alexei.starovoitov
Cc: mirq-linux, netdev, ast, benh, daniel, jhogan, linux-mips,
linuxppc-dev, mpe, paul.burton, paulus, ralf, sparclinux
In-Reply-To: <CAADnVQKzo_85bUPXnaqds0MxzrOu_BJwnZx25CbsNrjV=DHC3w@mail.gmail.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Fri, 16 Nov 2018 19:51:55 -0800
> Michal, could you please explain the reasoning?
By treating VLAN.CFI specially as "VLAN TAG PRESENT" we prevent
the usage of certain VLAN ID encodings.
So he's trying to get rid of VLAN_TAG_PRESENT completely and this
was the final patch series necessary to accomplish that.
^ permalink raw reply
* [PATCH v1] tg3: optionally use eth_platform_get_mac_address() to get mac address
From: thesven73 @ 2018-11-17 15:56 UTC (permalink / raw)
To: svendev, siva.kallam, prashant, mchan, andrew
Cc: davem, linux-kernel, netdev, arnd
This function will try to determine the mac address via the devicetree,
or via an architecture-specific method (e.g. a PROM on SPARC).
The SPARC-specific code in this driver (#ifdef SPARC) did exactly this,
and is therefore removed.
Note that you can now specify the tg3 mac address via the devicetree,
on any platform, not just SPARC:
Devicetree example:
(see Documentation/devicetree/bindings/pci/pci.txt)
&pcie {
host@0 {
#address-cells = <3>;
#size-cells = <2>;
reg = <0 0 0 0 0>;
bcm5778: bcm5778@0 {
reg = <0 0 0 0 0>;
mac-address = [CA 11 AB 1E 10 01];
};
};
};
Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
---
drivers/net/ethernet/broadcom/tg3.c | 42 ++---------------------------
1 file changed, 2 insertions(+), 40 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e6f28c7942ab..cfffddba06ce 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -66,11 +66,6 @@
#include <uapi/linux/net_tstamp.h>
#include <linux/ptp_clock_kernel.h>
-#ifdef CONFIG_SPARC
-#include <asm/idprom.h>
-#include <asm/prom.h>
-#endif
-
#define BAR_0 0
#define BAR_2 2
@@ -16984,32 +16979,6 @@ static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent)
return err;
}
-#ifdef CONFIG_SPARC
-static int tg3_get_macaddr_sparc(struct tg3 *tp)
-{
- struct net_device *dev = tp->dev;
- struct pci_dev *pdev = tp->pdev;
- struct device_node *dp = pci_device_to_OF_node(pdev);
- const unsigned char *addr;
- int len;
-
- addr = of_get_property(dp, "local-mac-address", &len);
- if (addr && len == ETH_ALEN) {
- memcpy(dev->dev_addr, addr, ETH_ALEN);
- return 0;
- }
- return -ENODEV;
-}
-
-static int tg3_get_default_macaddr_sparc(struct tg3 *tp)
-{
- struct net_device *dev = tp->dev;
-
- memcpy(dev->dev_addr, idprom->id_ethaddr, ETH_ALEN);
- return 0;
-}
-#endif
-
static int tg3_get_device_address(struct tg3 *tp)
{
struct net_device *dev = tp->dev;
@@ -17017,10 +16986,8 @@ static int tg3_get_device_address(struct tg3 *tp)
int addr_ok = 0;
int err;
-#ifdef CONFIG_SPARC
- if (!tg3_get_macaddr_sparc(tp))
+ if (!eth_platform_get_mac_address(&tp->pdev->dev, dev->dev_addr))
return 0;
-#endif
if (tg3_flag(tp, IS_SSB_CORE)) {
err = ssb_gige_get_macaddr(tp->pdev, &dev->dev_addr[0]);
@@ -17082,13 +17049,8 @@ static int tg3_get_device_address(struct tg3 *tp)
}
}
- if (!is_valid_ether_addr(&dev->dev_addr[0])) {
-#ifdef CONFIG_SPARC
- if (!tg3_get_default_macaddr_sparc(tp))
- return 0;
-#endif
+ if (!is_valid_ether_addr(&dev->dev_addr[0]))
return -EINVAL;
- }
return 0;
}
--
2.17.1
^ permalink raw reply related
* Re: [PATCH v2] tg3: optionally get mac address from devicetree
From: Sven Van Asbroeck @ 2018-11-17 15:58 UTC (permalink / raw)
To: Andrew Lunn
Cc: Sven Van Asbroeck, siva.kallam, prashant, mchan, David Miller,
Linux Kernel Mailing List, netdev, Arnd Bergmann
In-Reply-To: <20181115200018.GC32274@lunn.ch>
Please this cancel this patch. As suggested by Dave Miller, it has
been replaced by:
[PATCH v1] tg3: optionally use eth_platform_get_mac_address() to get mac address
^ permalink raw reply
* Re: [PATCH v4] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
From: Andrew Lunn @ 2018-11-17 6:28 UTC (permalink / raw)
To: David Miller; +Cc: ms, sergei.shtylyov, f.fainelli, netdev, linux-kernel
In-Reply-To: <20181116.202547.692151883173974691.davem@davemloft.net>
On Fri, Nov 16, 2018 at 08:25:47PM -0800, David Miller wrote:
> From: Martin Schiller <ms@dev.tdt.de>
> Date: Wed, 14 Nov 2018 12:54:49 +0100
>
> > This commit re-enables support for slow GPIO pins. It was initially
> > introduced by commit 2d6c9091ab76 ("net: mdio-gpio: support access that
> > may sleep") and got lost by commit 7e5fbd1e0700 ("net: mdio-gpio:
> > Convert to use gpiod functions where possible").
> >
> > Also add a warning about slow GPIO pins like it is done in i2c-gpio.
> >
> > Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>
> Applied, thanks.
Hi David
We were intending that v6 would get merged, and into net. I guess it
is too late now, but could you also add the v4 you merged into
net. You can find the fixes: tag in v6.
Thanks
Andrew
^ permalink raw reply
* Re: [PATCH V3 4/7] net: maclorawan: Add maclorawan module declaration
From: Jian-Hong Pan @ 2018-11-17 6:32 UTC (permalink / raw)
To: David S. Miller
Cc: Andreas Färber, netdev,
<linux-arm-kernel@lists.infradead.org\,
linux-kernel@vger.kernel.org>,, Marcel Holtmann, Dollar Chen,
Ken Yu, linux-wpan - ML, Stefan Schmidt
In-Reply-To: <20181116.203250.116640520195643915.davem@davemloft.net>
David Miller <davem@davemloft.net> 於 2018年11月17日 週六 下午12:32寫道：
>
> From: Jian-Hong Pan <starnight@g.ncu.edu.tw>
> Date: Thu, 15 Nov 2018 00:01:25 +0800
>
> > + * @rx1_window: RX1 window opening time in mini-seconds
> > + * @rx2_window: RX2 window opening time in mini-seconds
>
> What is a "mini-second"?
Spelling mistake. It should be millisecond.
Thanks for pointing out
^ permalink raw reply
* Re: [PATCH net-next] udp: fix jump label misuse
From: David Miller @ 2018-11-17 7:02 UTC (permalink / raw)
To: pabeni; +Cc: netdev, willemb, eric.dumazet
In-Reply-To: <f26bbd5e7b1a53a0406665089ead9cace940ddc8.1542244924.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Thu, 15 Nov 2018 02:34:50 +0100
> The commit 60fb9567bf30 ("udp: implement complete book-keeping for
> encap_needed") introduced a severe misuse of jump label APIs, which
> syzbot, as reported by Eric, was able to exploit.
>
> When multiple sockets/process can concurrently request (and than
> disable) the udp encap, we need to track the activation counter with
> *_inc()/*_dec() jump label variants, or we can experience bad things
> at disable time.
>
> Fixes: 60fb9567bf30 ("udp: implement complete book-keeping for encap_needed")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks Paolo.
^ permalink raw reply
* Re: [PATCH net-next] selftests: add explicit test for multiple concurrent GRO sockets
From: David Miller @ 2018-11-17 7:03 UTC (permalink / raw)
To: pabeni; +Cc: netdev, willemb
In-Reply-To: <e36409dd1b43c2786b99d919339237ed562e98b2.1542248618.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Thu, 15 Nov 2018 03:24:05 +0100
> This covers for proper accounting of encap needed static keys
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied.
^ permalink raw reply
* KASAN: use-after-free Read in __lock_sock
From: syzbot @ 2018-11-17 7:18 UTC (permalink / raw)
To: davem, linux-kernel, linux-sctp, marcelo.leitner, netdev, nhorman,
syzkaller-bugs, vyasevich
Hello,
syzbot found the following crash on:
HEAD commit: ccda4af0f4b9 Linux 4.20-rc2
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=156cd533400000
kernel config: https://syzkaller.appspot.com/x/.config?x=4a0a89f12ca9b0f5
dashboard link: https://syzkaller.appspot.com/bug?extid=9276d76e83e3bcde6c99
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
Unfortunately, I don't have any reproducer for this crash yet.
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+9276d76e83e3bcde6c99@syzkaller.appspotmail.com
netlink: 5 bytes leftover after parsing attributes in process
`syz-executor5'.
==================================================================
BUG: KASAN: use-after-free in __lock_acquire+0x36d9/0x4c20
kernel/locking/lockdep.c:3218
Read of size 8 at addr ffff8881d26d60e0 by task syz-executor1/13725
CPU: 0 PID: 13725 Comm: syz-executor1 Not tainted 4.20.0-rc2+ #333
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x244/0x39d lib/dump_stack.c:113
print_address_description.cold.7+0x9/0x1ff mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.8+0x242/0x309 mm/kasan/report.c:412
__asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433
__lock_acquire+0x36d9/0x4c20 kernel/locking/lockdep.c:3218
lock_acquire+0x1ed/0x520 kernel/locking/lockdep.c:3844
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:168
spin_lock_bh include/linux/spinlock.h:334 [inline]
__lock_sock+0x203/0x350 net/core/sock.c:2253
lock_sock_nested+0xfe/0x120 net/core/sock.c:2774
lock_sock include/net/sock.h:1492 [inline]
sctp_sock_dump+0x122/0xb20 net/sctp/diag.c:324
sctp_for_each_transport+0x2b5/0x370 net/sctp/socket.c:5091
sctp_diag_dump+0x3ac/0x660 net/sctp/diag.c:527
__inet_diag_dump+0xa8/0x140 net/ipv4/inet_diag.c:1049
inet_diag_dump+0x9b/0x110 net/ipv4/inet_diag.c:1065
netlink_dump+0x606/0x1080 net/netlink/af_netlink.c:2244
__netlink_dump_start+0x59a/0x7c0 net/netlink/af_netlink.c:2352
netlink_dump_start include/linux/netlink.h:216 [inline]
inet_diag_handler_cmd+0x2ce/0x3f0 net/ipv4/inet_diag.c:1170
__sock_diag_cmd net/core/sock_diag.c:232 [inline]
sock_diag_rcv_msg+0x31d/0x410 net/core/sock_diag.c:263
netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2477
sock_diag_rcv+0x2a/0x40 net/core/sock_diag.c:274
netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
netlink_unicast+0x5a5/0x760 net/netlink/af_netlink.c:1336
netlink_sendmsg+0xa18/0xfc0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:621 [inline]
sock_sendmsg+0xd5/0x120 net/socket.c:631
sock_write_iter+0x35e/0x5c0 net/socket.c:900
call_write_iter include/linux/fs.h:1857 [inline]
do_iter_readv_writev+0x8b0/0xa80 fs/read_write.c:680
do_iter_write+0x185/0x5f0 fs/read_write.c:959
vfs_writev+0x1f1/0x360 fs/read_write.c:1004
do_writev+0x11a/0x310 fs/read_write.c:1039
__do_sys_writev fs/read_write.c:1112 [inline]
__se_sys_writev fs/read_write.c:1109 [inline]
__x64_sys_writev+0x75/0xb0 fs/read_write.c:1109
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x457569
Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f2cdabbac78 EFLAGS: 00000246 ORIG_RAX: 0000000000000014
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000457569
RDX: 0000000000000001 RSI: 000000002051c000 RDI: 000000000000000e
RBP: 000000000072c0e0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f2cdabbb6d4
R13: 00000000004c33b1 R14: 00000000004d97c8 R15: 00000000ffffffff
Allocated by task 13672:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553
kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:490
kmem_cache_alloc+0x12e/0x730 mm/slab.c:3554
sk_prot_alloc+0x69/0x2e0 net/core/sock.c:1463
sk_alloc+0x10d/0x1690 net/core/sock.c:1523
inet_create+0x509/0x1070 net/ipv4/af_inet.c:321
__sock_create+0x536/0x930 net/socket.c:1277
sock_create net/socket.c:1317 [inline]
__sys_socket+0x106/0x260 net/socket.c:1347
__do_sys_socket net/socket.c:1356 [inline]
__se_sys_socket net/socket.c:1354 [inline]
__x64_sys_socket+0x73/0xb0 net/socket.c:1354
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe
Freed by task 13680:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kmem_cache_free+0x83/0x290 mm/slab.c:3760
sk_prot_free net/core/sock.c:1504 [inline]
__sk_destruct+0x728/0xa80 net/core/sock.c:1588
sk_destruct+0x78/0x90 net/core/sock.c:1596
__sk_free+0xcf/0x300 net/core/sock.c:1607
sk_free+0x42/0x50 net/core/sock.c:1618
sock_put include/net/sock.h:1693 [inline]
sctp_close+0x8d4/0xad0 net/sctp/socket.c:1569
inet_release+0x104/0x1f0 net/ipv4/af_inet.c:428
__sock_release+0xd7/0x250 net/socket.c:579
sock_close+0x19/0x20 net/socket.c:1141
__fput+0x385/0xa30 fs/file_table.c:278
____fput+0x15/0x20 fs/file_table.c:309
task_work_run+0x1e8/0x2a0 kernel/task_work.c:113
get_signal+0x1558/0x1980 kernel/signal.c:2347
do_signal+0x9c/0x21c0 arch/x86/kernel/signal.c:816
exit_to_usermode_loop+0x2e5/0x380 arch/x86/entry/common.c:162
prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
syscall_return_slowpath arch/x86/entry/common.c:268 [inline]
do_syscall_64+0x6be/0x820 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
The buggy address belongs to the object at ffff8881d26d6040
which belongs to the cache SCTP(33:syz1) of size 1776
The buggy address is located 160 bytes inside of
1776-byte region [ffff8881d26d6040, ffff8881d26d6730)
The buggy address belongs to the page:
page:ffffea000749b580 count:1 mapcount:0 mapping:ffff8881b517f200 index:0x0
flags: 0x2fffc0000000200(slab)
raw: 02fffc0000000200 ffff8881c6685748 ffffea0007538388 ffff8881b517f200
raw: 0000000000000000 ffff8881d26d6040 0000000100000002 ffff8881b6b4e7c0
page dumped because: kasan: bad access detected
page->mem_cgroup:ffff8881b6b4e7c0
Memory state around the buggy address:
ffff8881d26d5f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff8881d26d6000: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
> ffff8881d26d6080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881d26d6100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881d26d6180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with
syzbot.
^ permalink raw reply
* Re: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes
From: David Miller @ 2018-11-17 7:19 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, jiri, xiyou.wangcong, jhs, oss-drivers
In-Reply-To: <20181115062351.22763-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 14 Nov 2018 22:23:44 -0800
> This series updates the GRED Qdisc. The Qdisc matches nfp offload very
> well, but before we can offload it there are a number of improvements
> to make.
>
> First few patches add extack messages to the Qdisc and pass extack
> to netlink validation.
>
> Next a new netlink attribute group is added, to allow GRED to be
> extended more easily. Currently GRED passes C structures as attributes,
> and even an array of C structs for virtual queue configuration. User
> space has hard coded the expected length of that array, so adding new
> fields is not possible.
>
> New two-level attribute group is added:
>
> [TCA_GRED_VQ_LIST]
> [TCA_GRED_VQ_ENTRY]
> [TCA_GRED_VQ_DP]
> [TCA_GRED_VQ_FLAGS]
> [TCA_GRED_VQ_STAT_*]
> [TCA_GRED_VQ_ENTRY]
> [TCA_GRED_VQ_DP]
> [TCA_GRED_VQ_FLAGS]
> [TCA_GRED_VQ_STAT_*]
> [TCA_GRED_VQ_ENTRY]
> ...
>
> Statistics are dump only. Patch 4 switches the byte counts to be 64 bit,
> and patch 5 introduces the new stats attributes for dump. Patch 6
> switches RED flags to be per-virtual queue, and patch 7 allows them
> to be dumped and set at virtual queue granularity.
Nice work, series applied.
^ permalink raw reply
* Re: [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex
From: David Miller @ 2018-11-17 7:20 UTC (permalink / raw)
To: sunil.kovvuri; +Cc: netdev, arnd, linux-soc, skardach, sgoutham
In-Reply-To: <1542279586-27252-5-git-send-email-sunil.kovvuri@gmail.com>
From: sunil.kovvuri@gmail.com
Date: Thu, 15 Nov 2018 16:29:29 +0530
> From: Stanislaw Kardach <skardach@marvell.com>
>
> The resource locks does not need to be a spinlock as they are not
> used in any interrupt handling routines (only in bottom halves).
> Therefore relax them into a mutex so that later on we may use them
> in routines that might sleep.
>
> Signed-off-by: Stanislaw Kardach <skardach@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
This is confusing because software interrupts are often called bottom
halves, and in which sleeping and thus mutexes are not allowed.
^ permalink raw reply
* [PATCH 0/7] IP101GR: devicetree based configuration of SEL_INTR32
From: Martin Blumenstingl @ 2018-11-17 18:20 UTC (permalink / raw)
To: netdev, devicetree, f.fainelli, andrew, mark.rutland, robh+dt,
davem
Cc: linux-kernel, Martin Blumenstingl
The IP101GR is a 32-pin QFN package variant of the IP101G/IP101GA
Ethernet PHY. Due to it's limited amount of pins the RXER (receive
error) and INTR32 (interrupt) functions share pin 21.
The goal of this series is:
- some small cleanups in patches 3, 4 and 5
- allowing the kernel to detect IRQ floods on boards where the IP101GR
is configured in RXER mode but the RXER line is configured on the
host SoC as interrupt line (patch 6)
- configuration of the SEL_INTR32 register so we can use the interrupt
function on boards where the RXER/INTR32 pin (pin 21) is routed to
one of the host SoC's interrupt inputs (patches 1, 2, 7)
A use-case where this is needed is the Endless Mini (EC-100). I have
tested my changes on that board. This also confirms that Heiner
Kallweit's recent icplus.c PHY driver changes are working (at least on
my setup).
This series is based on net-next commit 9c549a6b057386d ("selftests:
add explicit test for multiple concurrent GRO sockets")
Martin Blumenstingl (7):
dt-bindings: vendor-prefix: add prefix for IC Plus Corp.
dt-bindings: net: phy: add bindings for the IC Plus Corp. IP101A/G
PHYs
net: phy: icplus: keep all ip101a_g functions together
net: phy: icplus: use the BIT macro where possible
net: phy: icplus: rename IP101A_G_NO_IRQ to IP101A_G_IRQ_ALL_MASK
net: phy: icplus: implement .did_interrupt for IP101A/G
net: phy: icplus: allow configuring the interrupt function on IP101GR
.../bindings/net/icplus-ip101ag.txt | 19 +++
.../devicetree/bindings/vendor-prefixes.txt | 1 +
drivers/net/phy/icplus.c | 125 +++++++++++++++---
3 files changed, 125 insertions(+), 20 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/icplus-ip101ag.txt
--
2.19.1
^ permalink raw reply
* [PATCH 1/7] dt-bindings: vendor-prefix: add prefix for IC Plus Corp.
From: Martin Blumenstingl @ 2018-11-17 18:20 UTC (permalink / raw)
To: netdev, devicetree, f.fainelli, andrew, mark.rutland, robh+dt,
davem
Cc: linux-kernel, Martin Blumenstingl
In-Reply-To: <20181117182007.14791-1-martin.blumenstingl@googlemail.com>
IC Plus Corp. has various Ethernet related products such as Ethernet
transceivers, Ethernet controllers, Ethernet switches, etc.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4b1a2a8fcc16..cc6b2c0d3b49 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -170,6 +170,7 @@ holtek Holtek Semiconductor, Inc.
hwacom HwaCom Systems Inc.
i2se I2SE GmbH
ibm International Business Machines (IBM)
+icplus IC Plus Corp.
idt Integrated Device Technologies, Inc.
ifi Ingenieurburo Fur Ic-Technologie (I/F/I)
ilitek ILI Technology Corporation (ILITEK)
--
2.19.1
^ permalink raw reply related
* [PATCH 2/7] dt-bindings: net: phy: add bindings for the IC Plus Corp. IP101A/G PHYs
From: Martin Blumenstingl @ 2018-11-17 18:20 UTC (permalink / raw)
To: netdev, devicetree, f.fainelli, andrew, mark.rutland, robh+dt,
davem
Cc: linux-kernel, Martin Blumenstingl
In-Reply-To: <20181117182007.14791-1-martin.blumenstingl@googlemail.com>
The IP101A and IP101G series both have various models. Depending on the
board implementation we need a special property for the IP101GR (32-pin
LQFP package) PHY:
pin 21 ("RXER/INTR_32") outputs the "receive error" signal by default
(LOW means "normal operation", HIGH means that there's either a decoding
error of the received signal or that the PHY is receiving LPI). This pin
can also be switched to INTR32 mode, where the interrupt signal is
routed to this pin. The other PHYs don't need this special handling
because they have more pins available so the interrupt function gets a
dedicated pin.
This adds two properties to either select the "receive error" or
"interrupt" function of pin 21. Not specifying any function means that
the default set by the bootloader is used. This is required because the
IP101GR cannot be differentiated between other IP101 PHYs as the PHY
identification registers on all of these is 0x02430c54.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
.../bindings/net/icplus-ip101ag.txt | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/icplus-ip101ag.txt
diff --git a/Documentation/devicetree/bindings/net/icplus-ip101ag.txt b/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
new file mode 100644
index 000000000000..a784592bbb15
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/icplus-ip101ag.txt
@@ -0,0 +1,19 @@
+IC Plus Corp. IP101A / IP101G Ethernet PHYs
+
+There are different models of the IP101G Ethernet PHY:
+- IP101GR (32-pin QFN package)
+- IP101G (die only, no package)
+- IP101GA (48-pin LQFP package)
+
+There are different models of the IP101A Ethernet PHY (which is the
+predecessor of the IP101G):
+- IP101A (48-pin LQFP package)
+- IP101AH (48-pin LQFP package)
+
+Optional properties for the IP101GR (32-pin QFN package):
+
+- icplus,select-rx-error:
+ pin 21 ("RXER/INTR_32") will output the receive error status.
+ interrupts are not routed outside the PHY in this mode.
+- icplus,select-interrupt:
+ pin 21 ("RXER/INTR_32") will output the interrupt signal.
--
2.19.1
^ permalink raw reply related
* [PATCH 4/7] net: phy: icplus: use the BIT macro where possible
From: Martin Blumenstingl @ 2018-11-17 18:20 UTC (permalink / raw)
To: netdev, devicetree, f.fainelli, andrew, mark.rutland, robh+dt,
davem
Cc: linux-kernel, Martin Blumenstingl
In-Reply-To: <20181117182007.14791-1-martin.blumenstingl@googlemail.com>
This makes the code consistent by using the BIT() macro instead of
manual bit-shifting for some of the fields. No functional changes.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/net/phy/icplus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c
index 3d3e9134c762..3ec470adde3d 100644
--- a/drivers/net/phy/icplus.c
+++ b/drivers/net/phy/icplus.c
@@ -36,11 +36,11 @@ MODULE_LICENSE("GPL");
/* IP101A/G - IP1001 */
#define IP10XX_SPEC_CTRL_STATUS 16 /* Spec. Control Register */
-#define IP1001_RXPHASE_SEL (1<<0) /* Add delay on RX_CLK */
-#define IP1001_TXPHASE_SEL (1<<1) /* Add delay on TX_CLK */
+#define IP1001_RXPHASE_SEL BIT(0) /* Add delay on RX_CLK */
+#define IP1001_TXPHASE_SEL BIT(1) /* Add delay on TX_CLK */
#define IP1001_SPEC_CTRL_STATUS_2 20 /* IP1001 Spec. Control Reg 2 */
#define IP1001_APS_ON 11 /* IP1001 APS Mode bit */
-#define IP101A_G_APS_ON 2 /* IP101A/G APS Mode bit */
+#define IP101A_G_APS_ON BIT(1) /* IP101A/G APS Mode bit */
#define IP101A_G_IRQ_CONF_STATUS 0x11 /* Conf Info IRQ & Status Reg */
#define IP101A_G_IRQ_PIN_USED BIT(15) /* INTR pin used */
#define IP101A_G_NO_IRQ BIT(11) /* IRQ's inactive */
--
2.19.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox