[PATCH] NTB: correct ntb_spad_count comment typo

[PATCH] NTB: correct ntb_spad_count comment typo

[Aaron Sierra]

The comment for ntb_spad_count incorrectly referred to ntb_mw_count.

Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
---
 include/linux/ntb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ntb.h b/include/linux/ntb.h
index 6f47562..50a7dbe 100644
--- a/include/linux/ntb.h
+++ b/include/linux/ntb.h
@@ -892,15 +892,15 @@ static inline int ntb_spad_is_unsafe(struct ntb_dev *ntb)
 	if (!ntb->ops->spad_is_unsafe)
 		return 0;
 
 	return ntb->ops->spad_is_unsafe(ntb);
 }
 
 /**
- * ntb_mw_count() - get the number of scratchpads
+ * ntb_spad_count() - get the number of scratchpads
  * @ntb:	NTB device context.
  *
  * Hardware and topology may support a different number of scratchpads.
  *
  * Return: the number of scratchpads.
  */
 static inline int ntb_spad_count(struct ntb_dev *ntb)
-- 
1.9.1

RE: correct ntb_spad_count comment typo

[Allen Hubbe]

From: Aaron Sierra
> The comment for ntb_spad_count incorrectly referred to ntb_mw_count.
> 
> Signed-off-by: Aaron Sierra <asierra@xes-inc.com>

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
>  include/linux/ntb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> index 6f47562..50a7dbe 100644
> --- a/include/linux/ntb.h
> +++ b/include/linux/ntb.h
> @@ -892,15 +892,15 @@ static inline int ntb_spad_is_unsafe(struct ntb_dev *ntb)
>  	if (!ntb->ops->spad_is_unsafe)
>  		return 0;
> 
>  	return ntb->ops->spad_is_unsafe(ntb);
>  }
> 
>  /**
> - * ntb_mw_count() - get the number of scratchpads
> + * ntb_spad_count() - get the number of scratchpads
>   * @ntb:	NTB device context.
>   *
>   * Hardware and topology may support a different number of scratchpads.
>   *
>   * Return: the number of scratchpads.
>   */
>  static inline int ntb_spad_count(struct ntb_dev *ntb)
> --
> 1.9.1

RE: correct ntb_spad_count comment typo

[Allen Hubbe]

From: Allen Hubbe
> From: Aaron Sierra
> > The comment for ntb_spad_count incorrectly referred to ntb_mw_count.
> >
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> 
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
> 

Actually, the commit subject line should include the subsystem name.

"NTB: Correct ntb_spad_count comment typo"

John might fix this after accepting the patch as is, but it would be easier if you amend the commit and send v2 with a new subject line.

Thanks,
Allen

> > ---
> >  include/linux/ntb.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> > index 6f47562..50a7dbe 100644
> > --- a/include/linux/ntb.h
> > +++ b/include/linux/ntb.h
> > @@ -892,15 +892,15 @@ static inline int ntb_spad_is_unsafe(struct ntb_dev *ntb)
> >  	if (!ntb->ops->spad_is_unsafe)
> >  		return 0;
> >
> >  	return ntb->ops->spad_is_unsafe(ntb);
> >  }
> >
> >  /**
> > - * ntb_mw_count() - get the number of scratchpads
> > + * ntb_spad_count() - get the number of scratchpads
> >   * @ntb:	NTB device context.
> >   *
> >   * Hardware and topology may support a different number of scratchpads.
> >   *
> >   * Return: the number of scratchpads.
> >   */
> >  static inline int ntb_spad_count(struct ntb_dev *ntb)
> > --
> > 1.9.1
> 
> 
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb"
> group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-
> ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-
> ntb/000001d2509b%242d829050%248887b0f0%24%40dell.com.
> For more options, visit https://groups.google.com/d/optout.

Re: correct ntb_spad_count comment typo

[Aaron Sierra]

----- Original Message -----
> From: "Allen Hubbe" <Allen.Hubbe@dell.com>
> Sent: Wednesday, December 7, 2016 9:09:45 AM

> From: Allen Hubbe
>> From: Aaron Sierra
>> > The comment for ntb_spad_count incorrectly referred to ntb_mw_count.
>> >
>> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
>> 
>> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
>> 
> 
> Actually, the commit subject line should include the subsystem name.
> 
> "NTB: Correct ntb_spad_count comment typo"

Allen,
First of all, thanks for taking time to review my patch!

This is the exact subject that I sent out:

    [PATCH] NTB: correct ntb_spad_count comment typo

Hopefully, this is just a glitch between me and you.

> 
> John might fix this after accepting the patch as is, but it would be easier if
> you amend the commit and send v2 with a new subject line.
> 

Can anyone else confirm or deny the need for a v2?

-Aaron S.

RE: correct ntb_spad_count comment typo

[Allen Hubbe]

From: Aaron Sierra
> This is the exact subject that I sent out:
> 
>     [PATCH] NTB: correct ntb_spad_count comment typo
> 
> Hopefully, this is just a glitch between me and you.

You're right, I replied with the wrong subject.

Thanks for the patch!  Already acked.

Allen