[PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Saul Wold]

This tune file is needed to enable a GAS option specific to this cpu family
in order to disable the usage of lock prefix instructions.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/conf/machine/include/tune-i586-nlp.inc | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc

diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
new file mode 100644
index 0000000..6815a16
--- /dev/null
+++ b/meta/conf/machine/include/tune-i586-nlp.inc
@@ -0,0 +1,20 @@
+#
+# Settings for the GAS(1) cpu-type quark/x1000 which has issues
+# with lock-prefix so use that option to omit them.
+#
+
+DEFAULTTUNE ?= "i586-nlp"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/tune-i586.inc
+
+# x86 with no lock prefix
+TUNEVALID[nlp] = "IA32 with Lock Prefix omitted"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "nlp", " -Wa,-momit-lock-prefix=yes", "", d)}"
+
+# Quark tune feature 
+AVAILTUNES = "i586-nlp"
+TUNE_FEATURES_tune-i586-nlp = "${TUNE_FEATURES_tune-i586} nlp"
+TUNE_PKGARCH_tune-i586-nlp = "i586-nlp"
+PACKAGE_EXTRA_ARCHS_tune-i586-nlp = "${PACKAGE_EXTRA_ARCHS_tune-i586} i586-nlp"
+
-- 
2.1.0

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Richard Purdie]

On Tue, 2015-06-23 at 08:22 -0700, Saul Wold wrote:
> This tune file is needed to enable a GAS option specific to this cpu family
> in order to disable the usage of lock prefix instructions.
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/conf/machine/include/tune-i586-nlp.inc | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
> 
> diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
> new file mode 100644
> index 0000000..6815a16
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-i586-nlp.inc
> @@ -0,0 +1,20 @@
> +#
> +# Settings for the GAS(1) cpu-type quark/x1000 which has issues
> +# with lock-prefix so use that option to omit them.
> +#
> +
> +DEFAULTTUNE ?= "i586-nlp"
> +
> +# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
> +require conf/machine/include/tune-i586.inc
> +
> +# x86 with no lock prefix
> +TUNEVALID[nlp] = "IA32 with Lock Prefix omitted"
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "nlp", " -Wa,-momit-lock-prefix=yes", "", d)}"
> +
> +# Quark tune feature 
> +AVAILTUNES = "i586-nlp"
> +TUNE_FEATURES_tune-i586-nlp = "${TUNE_FEATURES_tune-i586} nlp"
> +TUNE_PKGARCH_tune-i586-nlp = "i586-nlp"
> +PACKAGE_EXTRA_ARCHS_tune-i586-nlp = "${PACKAGE_EXTRA_ARCHS_tune-i586} i586-nlp"

Since i586 doesn't work with this hardware, should this inherit the i586
tune?

Cheers,

Richard

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Darren Hart]

On 6/23/15, 9:02 AM, "Richard Purdie" <richard.purdie@linuxfoundation.org>
wrote:

>On Tue, 2015-06-23 at 08:22 -0700, Saul Wold wrote:
>> This tune file is needed to enable a GAS option specific to this cpu
>>family
>> in order to disable the usage of lock prefix instructions.
>> 
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>  meta/conf/machine/include/tune-i586-nlp.inc | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>  create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
>> 
>> diff --git a/meta/conf/machine/include/tune-i586-nlp.inc
>>b/meta/conf/machine/include/tune-i586-nlp.inc
>> new file mode 100644
>> index 0000000..6815a16
>> --- /dev/null
>> +++ b/meta/conf/machine/include/tune-i586-nlp.inc
>> @@ -0,0 +1,20 @@
>> +#
>> +# Settings for the GAS(1) cpu-type quark/x1000 which has issues
>> +# with lock-prefix so use that option to omit them.
>> +#
>> +
>> +DEFAULTTUNE ?= "i586-nlp"
>> +
>> +# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
>> +require conf/machine/include/tune-i586.inc
>> +
>> +# x86 with no lock prefix
>> +TUNEVALID[nlp] = "IA32 with Lock Prefix omitted"
>> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "nlp", "
>>-Wa,-momit-lock-prefix=yes", "", d)}"
>> +
>> +# Quark tune feature
>> +AVAILTUNES = "i586-nlp"
>> +TUNE_FEATURES_tune-i586-nlp = "${TUNE_FEATURES_tune-i586} nlp"
>> +TUNE_PKGARCH_tune-i586-nlp = "i586-nlp"
>> +PACKAGE_EXTRA_ARCHS_tune-i586-nlp = "${PACKAGE_EXTRA_ARCHS_tune-i586}
>>i586-nlp"
>
>Since i586 doesn't work with this hardware, should this inherit the i586
>tune?

Hrm... The thing we need to avoid is quark machines accepting an i586
package in lieu of a i586-nlp package. I don't think that's a problem here
is it? The PACKAGE_EXTRA_ARCHS makes it so the i586-nlp package can be
used on machines that require i586, but not vice versa - correct?

I don't see a conflict here, but maybe I'm missing something.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Phil Blundell]

On Tue, 2015-06-23 at 10:17 -0700, Darren Hart wrote:
> Hrm... The thing we need to avoid is quark machines accepting an i586
> package in lieu of a i586-nlp package. I don't think that's a problem here
> is it? The PACKAGE_EXTRA_ARCHS makes it so the i586-nlp package can be
> used on machines that require i586, but not vice versa - correct?

No, exactly the opposite to that. 

p.

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Darren Hart]

On 6/23/15, 10:19 AM, "Phil Blundell" <pb@pbcl.net> wrote:

>On Tue, 2015-06-23 at 10:17 -0700, Darren Hart wrote:
>> Hrm... The thing we need to avoid is quark machines accepting an i586
>> package in lieu of a i586-nlp package. I don't think that's a problem
>>here
>> is it? The PACKAGE_EXTRA_ARCHS makes it so the i586-nlp package can be
>> used on machines that require i586, but not vice versa - correct?
>
>No, exactly the opposite to that.

Right, duh. For some reason I was looking at this from the wrong angle
yesterday I guess.


-- 
Darren Hart
Intel Open Source Technology Center

[PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Saul Wold]

This tune file is needed to enable a GAS option specific to this cpu family
in order to disable the usage of lock prefix instructions.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/conf/machine/include/tune-i586-nlp.inc | 19 +++++++++++++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc

diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
new file mode 100644
index 0000000..94e22c1
--- /dev/null
+++ b/meta/conf/machine/include/tune-i586-nlp.inc
@@ -0,0 +1,19 @@
+# Settings for the GCC(1) cpu-type "quark":
+#
+#
+#
+DEFAULTTUNE ?= "i586-nlp-32"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/x86/arch-x86.inc
+
+# x86 with no lock prefix
+TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "i586-nlp", " -march=i586 -Wa,-momit-lock-prefix=yes", "", d)}"
+
+# Quark tune feature
+AVAILTUNES = "i586-nlp-32"
+TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
+BASE_LIB_tune-i586-nlp-32 = "lib"
+TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
+PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
-- 
2.1.0

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Darren Hart]

On 6/29/15 7:10 AM, Saul Wold wrote:
> This tune file is needed to enable a GAS option specific to this cpu family
> in order to disable the usage of lock prefix instructions.
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/conf/machine/include/tune-i586-nlp.inc | 19 +++++++++++++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
> 
> diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
> new file mode 100644
> index 0000000..94e22c1
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-i586-nlp.inc
> @@ -0,0 +1,19 @@
> +# Settings for the GCC(1) cpu-type "quark":
> +#
> +#
> +#
> +DEFAULTTUNE ?= "i586-nlp-32"
> +
> +# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
> +require conf/machine/include/x86/arch-x86.inc
> +
> +# x86 with no lock prefix
> +TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "i586-nlp", " -march=i586 -Wa,-momit-lock-prefix=yes", "", d)}"
> +
> +# Quark tune feature
> +AVAILTUNES = "i586-nlp-32"
> +TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
> +BASE_LIB_tune-i586-nlp-32 = "lib"
> +TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
> +PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
> 

I believe this explicit assignment, instead of appending to tune-i586,
addresses the issue Phil raised?

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

[Richard Purdie]

On Wed, 2015-07-01 at 09:03 -0700, Darren Hart wrote:
> > +# Quark tune feature
> > +AVAILTUNES = "i586-nlp-32"
> > +TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
> > +BASE_LIB_tune-i586-nlp-32 = "lib"
> > +TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
> > +PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
> > 
> 
> I believe this explicit assignment, instead of appending to tune-i586,
> addresses the issue Phil raised?

Correct, this looks much better and has been merged.

Cheers,

Richard