should we switch off patchwork for oe-core and bitbake projects

should we switch off patchwork for oe-core and bitbake projects

[Khem Raj]

Hi

patchwork instance that we have currently handles patches for
oe-devel, oe-core and bitbake
layers which use oe-devel maintain and use the patch queues ok so it
makes sense to have it
there. But patch flow for oe-core and bitbake is handled differently
via pull requests. Would it
make sense to turn it off for these two projects. Is someone using
patchwork and/or finds
it useful to have the patchwork catch those patches please let me know

-Khem

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

On Wed, Feb 01, 2012 at 08:04:14AM -0800, Khem Raj wrote:
> Hi
> 
> patchwork instance that we have currently handles patches for
> oe-devel, oe-core and bitbake
> layers which use oe-devel maintain and use the patch queues ok so it
> makes sense to have it
> there. But patch flow for oe-core and bitbake is handled differently
> via pull requests. Would it
> make sense to turn it off for these two projects. Is someone using
> patchwork and/or finds
> it useful to have the patchwork catch those patches please let me know

I'm using it sometimes to check if some patch I've sent to list wasn't
overlooked.

But I can live without it if it adds some administrative or other burden
on servers.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[McClintock Matthew-B29882]

On Wed, Feb 1, 2012 at 10:04 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Hi
>
> patchwork instance that we have currently handles patches for
> oe-devel, oe-core and bitbake
> layers which use oe-devel maintain and use the patch queues ok so it
> makes sense to have it
> there. But patch flow for oe-core and bitbake is handled differently
> via pull requests. Would it
> make sense to turn it off for these two projects. Is someone using
> patchwork and/or finds
> it useful to have the patchwork catch those patches please let me know

Patchworks is useful for pulling patches into a git repo and having
discussion on a patch documented. I don't think it should just be
turned off, it can be left there for all the see and use.

-M

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Wed, Feb 1, 2012 at 15:07, McClintock Matthew-B29882 <
B29882@freescale.com> wrote:

> On Wed, Feb 1, 2012 at 10:04 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > Hi
> >
> > patchwork instance that we have currently handles patches for
> > oe-devel, oe-core and bitbake
> > layers which use oe-devel maintain and use the patch queues ok so it
> > makes sense to have it
> > there. But patch flow for oe-core and bitbake is handled differently
> > via pull requests. Would it
> > make sense to turn it off for these two projects. Is someone using
> > patchwork and/or finds
> > it useful to have the patchwork catch those patches please let me know
>
> Patchworks is useful for pulling patches into a git repo and having
> discussion on a patch documented. I don't think it should just be
> turned off, it can be left there for all the see and use.


The major issue with it is the burden work of keeping it clean regarding of
the merged patches. Otherwise it ends being useless due the amount of not
archived patches.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 1819 bytes --]

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[McClintock Matthew-B29882]

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

On Feb 1, 2012 11:49 AM, "Otavio Salvador" <otavio@ossystems.com.br<mailto:otavio@ossystems.com.br>> wrote:
>
> On Wed, Feb 1, 2012 at 15:07, McClintock Matthew-B29882 <B29882@freescale.com<mailto:B29882@freescale.com>> wrote:
>>
>> On Wed, Feb 1, 2012 at 10:04 AM, Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>> wrote:
>> > Hi
>> >
>> > patchwork instance that we have currently handles patches for
>> > oe-devel, oe-core and bitbake
>> > layers which use oe-devel maintain and use the patch queues ok so it
>> > makes sense to have it
>> > there. But patch flow for oe-core and bitbake is handled differently
>> > via pull requests. Would it
>> > make sense to turn it off for these two projects. Is someone using
>> > patchwork and/or finds
>> > it useful to have the patchwork catch those patches please let me know
>>
>> Patchworks is useful for pulling patches into a git repo and having
>> discussion on a patch documented. I don't think it should just be
>> turned off, it can be left there for all the see and use.
>
>
> The major issue with it is the burden work of keeping it clean regarding of the merged patches. Otherwise it ends being useless due the amount of not archived patches

I'm saying leave it there even if its not maintained. I can still go search for patches sent by me or other specific people.

-M

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br<mailto:otavio@ossystems.com.br>  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2723 bytes --]

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Khem Raj]

On Wed, Feb 1, 2012 at 9:51 AM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> I'm saying leave it there even if its not maintained. I can still go search
> for patches sent by me or other specific people.

thats what mailing list archives are for.

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On Wed, Feb 01, 2012 at 10:07:14AM -0800, Khem Raj wrote:
> On Wed, Feb 1, 2012 at 9:51 AM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
> > I'm saying leave it there even if its not maintained. I can still go search
> > for patches sent by me or other specific people.
> 
> thats what mailing list archives are for.

is there something like
oe/contrib/patchwork/pw-am.sh
for some mailing list archive?

When I see some interesting patch in ML, easiest way for me to get it to
development branch is to open patchwork web (from any computer) and then
call pw-am.sh NUMBER in screen session on my development workstation.

Even when reading mail in mutt on the same machine it's easier for me to
use pw-am.sh to get that patch to my chroot for OE builds.

And that git hook marking them as applied works very well.. so usually I
just have to mark cover letters as applied.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[McClintock Matthew-B29882]

On Wed, Feb 1, 2012 at 12:19 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Feb 01, 2012 at 10:07:14AM -0800, Khem Raj wrote:
>> On Wed, Feb 1, 2012 at 9:51 AM, McClintock Matthew-B29882
>> <B29882@freescale.com> wrote:
>> > I'm saying leave it there even if its not maintained. I can still go search
>> > for patches sent by me or other specific people.
>>
>> thats what mailing list archives are for.
>
> is there something like
> oe/contrib/patchwork/pw-am.sh
> for some mailing list archive?
>
> When I see some interesting patch in ML, easiest way for me to get it to
> development branch is to open patchwork web (from any computer) and then
> call pw-am.sh NUMBER in screen session on my development workstation.
>
> Even when reading mail in mutt on the same machine it's easier for me to
> use pw-am.sh to get that patch to my chroot for OE builds.
>
> And that git hook marking them as applied works very well.. so usually I
> just have to mark cover letters as applied.

My usage would be the same.

-M

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Khem Raj]

On Wed, Feb 1, 2012 at 10:19 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Feb 01, 2012 at 10:07:14AM -0800, Khem Raj wrote:
>> On Wed, Feb 1, 2012 at 9:51 AM, McClintock Matthew-B29882
>> <B29882@freescale.com> wrote:
>> > I'm saying leave it there even if its not maintained. I can still go search
>> > for patches sent by me or other specific people.
>>
>> thats what mailing list archives are for.
>
> is there something like
> oe/contrib/patchwork/pw-am.sh
> for some mailing list archive?
>

not exactly but if we enable mbox archive download on the ml
you can see the mails in mbox formats and download it. then it would
be git am'able

> When I see some interesting patch in ML, easiest way for me to get it to
> development branch is to open patchwork web (from any computer) and then
> call pw-am.sh NUMBER in screen session on my development workstation.
>
> Even when reading mail in mutt on the same machine it's easier for me to
> use pw-am.sh to get that patch to my chroot for OE builds.
>
> And that git hook marking them as applied works very well.. so usually I
> just have to mark cover letters as applied.
>

yes it works fine for most of the times however for oe-core
the patches get sent to ml and then picked and again resent
as pull request sometimes nudged sometimes unmodified and patchwork
does not close them automatically.

so purpose of patchwork in this case would be different then It is just to host
the patches for oe-core but has a different usage for
oe-devel where the patches are picked and closed from the patchwork.
This could be confusing at times especially
for new people. But if we see enough value to keep it
that way then we can think of making some changes so it
detects the resends somehow if the patch hashes are not same
etc and close them.

Re: [bitbake-devel] should we switch off patchwork for oe-core and bitbake projects

[Denys Dmytriyenko]

On Wed, Feb 01, 2012 at 07:19:09PM +0100, Martin Jansa wrote:
> On Wed, Feb 01, 2012 at 10:07:14AM -0800, Khem Raj wrote:
> > On Wed, Feb 1, 2012 at 9:51 AM, McClintock Matthew-B29882
> > <B29882@freescale.com> wrote:
> > > I'm saying leave it there even if its not maintained. I can still go search
> > > for patches sent by me or other specific people.
> > 
> > thats what mailing list archives are for.
> 
> is there something like
> oe/contrib/patchwork/pw-am.sh
> for some mailing list archive?
> 
> When I see some interesting patch in ML, easiest way for me to get it to
> development branch is to open patchwork web (from any computer) and then
> call pw-am.sh NUMBER in screen session on my development workstation.
> 
> Even when reading mail in mutt on the same machine it's easier for me to
> use pw-am.sh to get that patch to my chroot for OE builds.
> 
> And that git hook marking them as applied works very well.. so usually I
> just have to mark cover letters as applied.

I'd vote for keeping patchworks as well - there are rare patches submitted to 
oe-core w/o corresponding pull requests...

-- 
Denys