Re: [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2519 bytes --]

On Tue, Jan 07, 2014 at 03:18:37PM +0100, Alexandre Belloni wrote:
> When using a defconfig, using yes '' | make oldconfig may not result in
> the correct configuration being set. For example:

>  $ grep USB_ETH .config
>  CONFIG_USB_ETH=y
>  CONFIG_USB_ETH_RNDIS=y
>  CONFIG_USB_ETH_EEM=y
>  $ make savedefconfig
>  scripts/kconfig/conf --savedefconfig=defconfig Kconfig
>  $ cp defconfig .config
>  ‘defconfig’ -> ‘.config’
>  $ yes '' | make oldconfig
>  [...]
>  #
>  # configuration written to .config
>  #
>  $ grep USB_ETH .config
>  CONFIG_USB_ETH=m
>  CONFIG_USB_ETH_RNDIS=y
>  CONFIG_USB_ETH_EEM=y
> 
> Using make olddefconfig solves that but we'll use oldnoconfig for
> backward compatibility with older kernels.

Looks good, I have few kernel recipes where I had to fixup resulting
.config after "make savedefconfig", "yes '' | make oldconfig" combo
exactly because of some =y changing to -m.

1) Do you know since when oldnoconfig is supported?

IIRC oldest kernel I've in BSPs is 2.6.24. 

2) Could you send similar patch for
meta-openembedded/meta-oe/recipes-kernel/linux/linux.inc
?

>  $ cp defconfig .config
>  ‘defconfig’ -> ‘.config’
>  $ make oldnoconfig
>  scripts/kconfig/conf --olddefconfig Kconfig
>  #
>  # configuration written to .config
>  #
>  $ grep USB_ETH .config
>  CONFIG_USB_ETH=y
>  CONFIG_USB_ETH_RNDIS=y
>  CONFIG_USB_ETH_EEM=y
> 
> For more information, please refer to:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fbe98bb9ed3dae23e320c6b113e35f129538d14a
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 61a6d102d7a8..644d7937923d 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -313,7 +313,7 @@ kernel_do_configure() {
>  	if [ -f "${WORKDIR}/defconfig" ] && [ ! -f "${B}/.config" ]; then
>  		cp "${WORKDIR}/defconfig" "${B}/.config"
>  	fi
> -	yes '' | oe_runmake oldconfig
> +	oe_runmake oldnoconfig
>  }
>  
>  do_savedefconfig() {
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]