From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Hart, Darren" <darren.hart@intel.com>,
Martin Jansa <martin.jansa@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig
Date: Tue, 07 Jan 2014 21:32:26 +0100 [thread overview]
Message-ID: <52CC645A.5040107@free-electrons.com> (raw)
In-Reply-To: <1389118253.5785.25.camel@dvhart-mobl4.amr.corp.intel.com>
On 07/01/2014 19:11, Hart, Darren wrote:
>
> Please check for the functionality, not KERNEL_VERSION. The
> KERNEL_VERSION doesn't allow for backports and such which might add this
> ability. Grep the Makefile for the target, for example, if the above OR
> statement isn't adequate.
>
I guess the OR is perfectly fine then. For whatever reason make
oldnoconfig fails, we'll fall back to the old behavior.
> As Bruce stated, it seems that the fix would be to use the updated
> Kconfig, not default to setting things to NO. The problem with that
> approach is it doesn't accept defaults for non-specified options (which
> when updating kernel versions, is often the preferred approach).
>
I think you got it wrong:
- I am already using an updated kconfig (I even backported it on the
older kernel version)
- make oldnoconfig is NOT setting things to NO but to the default value
of the unspecified options (exactly what we need). The choice of the
name was not wise and It has been renamed olddefconfig since 3.7
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-07 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 14:18 [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig Alexandre Belloni
2014-01-07 14:35 ` Martin Jansa
2014-01-07 15:20 ` Alexandre Belloni
2014-01-07 15:54 ` Martin Jansa
2014-01-07 18:11 ` Hart, Darren
2014-01-07 20:32 ` Alexandre Belloni [this message]
2014-01-07 21:32 ` Hart, Darren
2014-01-07 15:32 ` Bruce Ashfield
2014-01-07 20:27 ` Alexandre Belloni
2014-01-07 20:39 ` Bruce Ashfield
2014-01-07 20:52 ` Alexandre Belloni
2014-01-07 21:14 ` Bruce Ashfield
2014-01-29 13:10 ` Alexandre Belloni
2014-01-29 15:03 ` Bruce Ashfield
2014-02-06 13:48 ` Bruce Ashfield
2014-02-06 21:48 ` Bruce Ashfield
2014-02-07 14:02 ` Alexandre Belloni
2014-02-07 15:11 ` Bruce Ashfield
2014-02-07 15:43 ` Alexandre Belloni
2014-02-07 16:10 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC645A.5040107@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=darren.hart@intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox