Re: [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 14-01-07 03:52 PM, Alexandre Belloni wrote:
> On 07/01/2014 21:39, Bruce Ashfield wrote:
>
>>>
>>> As shown in my commit log, using yes '' | make oldconfig is still
>>> getting it wrong.
>>
>> But that was also my point. Since the target suggested in this
>> patch hasn't always existed (and hence has a kernel version binding),
>> why not use olddefconfig with this patch, and leave the functionality
>> closer to its existing behaviour ? We'd still have a kernel capability
>> binding, but we'd not have the =y converted to =m, and the default of
>> 'y' for new functionality would be maintained.
>>
>
> Hum, I'm not sure I follow you. oldnoconfig and olddefconfig are exactly
> the same. oldnoconfig has been renamed olddefconfig in 3.7 and
> oldnoconfig is an alias to olddefconfig since then. I'm using
> oldnoconfig only to be able to use that on a wider range of kernel versions.

I need to go run some of my own tests (and poke that the code). I'm
running out of time for the day, so need to have a closer look when
things slow down.

I'm not so much concerned about the differences between:

   defconfig -> savedefconfig -> config

and

   defconfig -> new kernel (oldconfig) -> config

vs

   defconfig -> new kernel (olddefconfig) -> config

i.e. What do the new config options offered by the new kernel
generate in the final .config between the two techniques.

Personally, I think the make target that is run should be configurable
via a variable (yes, I know we all hate new variables), but getting
this right for everyone is hard, and also not forcing everyone to write
their own kernel_do_configure() if they don't like this behaviour.

Bruce

>
>