From: "Kory Maincent" <kory.maincent@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org, thomas.petazzoni@bootlin.com
Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
Date: Sat, 19 Dec 2020 12:03:20 +0100 [thread overview]
Message-ID: <20201219120320.3f318211@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <befdc92a15ad20dc490201f6f87a56e79fe5714e.camel@linuxfoundation.org>
On Fri, 18 Dec 2020 13:36:10 +0000
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
> >
> > TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > +export libdir := "${exec_prefix}/${baselib}"
> > +export incdir := "${exec_prefix}/include"
>
> In general we try and avoid :=, is there a reason its needed here
> rather than just "=" ? If so, it might be something that should be
> mentioned in the commit message?
Ok, the point was to avoid these ${incdir} and ${libdir} get modified by the
"export ${prefix}". In fact, I need to do it only with the PKG_CONFIG_PATH
variable. Yes, I will mention it.
Regards,
Köry
>
> Cheers,
> Richard
>
prev parent reply other threads:[~2020-12-19 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
2020-12-18 8:52 ` Kory Maincent
2020-12-18 12:06 ` Peter Kjellerstedt
2020-12-18 14:07 ` Kory Maincent
2020-12-18 18:59 ` Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie
2020-12-19 11:03 ` Kory Maincent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219120320.3f318211@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox