Re: [OE-core] [PATCH v2] ltp: fix rpc build error

["Peter Kjellerstedt" <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Köry Maincent <kory.maincent@bootlin.com>
> Sent: den 18 december 2020 15:08
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org;
> thomas.petazzoni@bootlin.com
> Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
> 
> On Fri, 18 Dec 2020 12:06:06 +0000
> Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> 
> > > I did not notice but it brings an error and I sent a V3 with it.
> > > Your review returns this error:
> > > bb.data_smart.ExpansionError: Failure expanding variable incdir,
> > > expression was ${incdir} which triggered exception Exception:
> > > variable incdir references itself!
> >
> > Duh, of course. That is because there is no incdir variable, so
> > "${incdir}" will expand to "\${incdir}". The real variable is called
> > includedir.
> >
> > This of course brings the question whether ltp expects incdir or
> > includedir, and if it is the latter, then your changes so far have not
> > made any difference when it comes to includedir, which means they
> > shouldn't be needed.
> 
> Your right it needs only ${libdir}.
> In fact, the issue was the recipe could not find tirpc pkgconfig.
> I have chosen to export libdir because
> PKG_CONFIG_DIR=${STAGING_DIR_HOST}${libdir}/pkgconfig
> But maybe it is better to add the path to PKG_CONFIG_PATH?

If that is the only reason for the exported libdir, then I agree, it is 
better to add:

PKG_CONFIG_PATH .= ":${STAGING_DIR_HOST}${exec_prefix}/${baselib}/pkgconfig"

Preferably with a comment explaining why it is being done.

> Regards,
> 
> Köry

//Peter