public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Kory Maincent <kory.maincent@bootlin.com>,
	 openembedded-core@lists.openembedded.org
Cc: thomas.petazzoni@bootlin.com
Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
Date: Fri, 18 Dec 2020 13:36:10 +0000	[thread overview]
Message-ID: <befdc92a15ad20dc490201f6f87a56e79fe5714e.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201217140756.30688-1-kory.maincent@bootlin.com>

On Thu, 2020-12-17 at 15:07 +0100, Kory Maincent wrote:
> Add support to tirpc tests build.
> Export incdir and libdir to have the right path.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change since v1:
>  - Use PACKAGECONFIG to enable rpc tests
>  - Improve ${libdir} and ${incdir} export
> 
> 
>  meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
> b/meta/recipes-extended/ltp/ltp_20200930.bb
> index 7acf15b360..9da5d90353 100644
> --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> @@ -42,14 +42,14 @@ inherit autotools-brokensep pkgconfig
>  
>  TARGET_CC_ARCH += "${LDFLAGS}"
>  
> +export libdir := "${exec_prefix}/${baselib}"
> +export incdir := "${exec_prefix}/include"

In general we try and avoid :=, is there a reason its needed here
rather than just "=" ? If so, it might be something that should be
mentioned in the commit message?

Cheers,
Richard


  parent reply	other threads:[~2020-12-18 13:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
2020-12-18  8:52   ` Kory Maincent
2020-12-18 12:06     ` Peter Kjellerstedt
2020-12-18 14:07       ` Kory Maincent
2020-12-18 18:59         ` Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie [this message]
2020-12-19 11:03   ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=befdc92a15ad20dc490201f6f87a56e79fe5714e.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=kory.maincent@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox