public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>
Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
Date: Fri, 18 Dec 2020 12:06:06 +0000	[thread overview]
Message-ID: <8a74e57385a4497c9e65bb3d433207df@XBOX03.axis.com> (raw)
In-Reply-To: <20201218095214.267d7c2a@kmaincent-XPS-13-7390>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Kory Maincent
> Sent: den 18 december 2020 09:52
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: openembedded-core@lists.openembedded.org;
> thomas.petazzoni@bootlin.com
> Subject: Re: [OE-core] [PATCH v2] ltp: fix rpc build error
> 
> Hello Peter,
> 
> On Thu, 17 Dec 2020 16:21:20 +0000
> Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> 
> > >
> > >  TARGET_CC_ARCH += "${LDFLAGS}"
> > >
> > > +export libdir := "${exec_prefix}/${baselib}"
> > > +export incdir := "${exec_prefix}/include"
> >
> > This should be a little bit better:
> >
> > export libdir := "${libdir}"
> > export incdir := "${incdir}"
> 
> Thanks,
> I did not notice but it brings an error and I sent a V3 with it.
> Your review returns this error:
> bb.data_smart.ExpansionError: Failure expanding variable incdir,
> expression was ${incdir} which triggered exception Exception: variable
> incdir references itself!

Duh, of course. That is because there is no incdir variable, so 
"${incdir}" will expand to "\${incdir}". The real variable is called 
includedir. 

This of course brings the question whether ltp expects incdir or 
includedir, and if it is the latter, then your changes so far have not 
made any difference when it comes to includedir, which means they 
shouldn't be needed.

> 
> Regards,
> 
> Köry,

//Peter


  reply	other threads:[~2020-12-18 12:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 14:07 [PATCH v2] ltp: fix rpc build error Kory Maincent
2020-12-17 16:21 ` [OE-core] " Peter Kjellerstedt
2020-12-18  8:52   ` Kory Maincent
2020-12-18 12:06     ` Peter Kjellerstedt [this message]
2020-12-18 14:07       ` Kory Maincent
2020-12-18 18:59         ` Peter Kjellerstedt
2020-12-18 13:36 ` Richard Purdie
2020-12-19 11:03   ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a74e57385a4497c9e65bb3d433207df@XBOX03.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=kory.maincent@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox